From: Stefan Agner <stefan@agner.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bai Ping <ping.bai@nxp.com>,
kbuild-all@01.org, linux-gpio@vger.kernel.org,
Rob Herring <robh@kernel.org>,
kbuild test robot <fengguang.wu@intel.com>
Subject: Re: [pinctrl:devel 63/65] drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type
Date: Thu, 11 Jan 2018 13:27:13 +0100 [thread overview]
Message-ID: <bf63b551282772456e40645df318479f@agner.ch> (raw)
In-Reply-To: <CACRpkdbtkzLWccs_D=xTh=0LTt9xs=hGUERLafrrhcEHK3H88Q@mail.gmail.com>
On 2018-01-11 10:32, Linus Walleij wrote:
> On Wed, Jan 10, 2018 at 7:11 PM, Stefan Agner <stefan@agner.ch> wrote:
>> Hi Linus,
>>
>> On 2018-01-09 17:40, kbuild test robot wrote:
>>> tree:
>>> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git
>>> devel
>>> head: a3a093ae02e2ae81499ad9e78516dccd72906c25
>>> commit: ba33f4f42e968854d8367fc4e55b07f835c55832 [63/65] pinctrl:
>>> imx6ul: add IOMUXC SNVS pinctrl driver for i.MX 6ULL
>>> config: arm-multi_v7_defconfig (attached as .config)
>>> compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
>>> reproduce:
>>> wget
>>> https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
>>> -O ~/bin/make.cross
>>> chmod +x ~/bin/make.cross
>>> git checkout ba33f4f42e968854d8367fc4e55b07f835c55832
>>> # save the attached .config to linux build tree
>>> make.cross ARCH=arm
>>>
>>> All warnings (new ones prefixed by >>):
>>>
>>> drivers/pinctrl/freescale/pinctrl-imx6ul.c: In function
>>> 'imx6ul_pinctrl_probe':
>>>>> drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
>>> return imx_pinctrl_probe(pdev, pinctrl_info);
>>> ^~~~~~~~~~~~
>>
>>
>> I think this happened because you only applied patch 5 of the imx
>> constify patchset, is that correct?
>
> I have applied patches 1-4 now... patch 5 I can't even find in
> my inbox :(
>
> So I guess not.
>
> Can you have a look at my devel branch and send or resend a
> patch if something is still wrong?
> https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=devel
All patches are applied now. Note that Patch 5 ("pinctrl: imx6ul: add
IOMUXC SNVS pinctrl driver for i.MX 6ULL") is not authored by me, so
that is a bit confusing when looking at the git history.
The above warning has been triggered because patch 5 has been applied
before patch 1. I guess for strict bisectability it should be
reordered.. ("pinctrl: imx6ul: add IOMUXC SNVS pinctrl driver for i.MX
6ULL" should be after "pinctrl: imx: use struct imx_pinctrl_soc_info as
a const").
--
Stefan
prev parent reply other threads:[~2018-01-11 12:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-09 16:40 [pinctrl:devel 63/65] drivers/pinctrl/freescale/pinctrl-imx6ul.c:343:33: warning: passing argument 2 of 'imx_pinctrl_probe' discards 'const' qualifier from pointer target type kbuild test robot
2018-01-10 18:11 ` Stefan Agner
2018-01-11 9:21 ` Linus Walleij
2018-01-11 9:32 ` Linus Walleij
2018-01-11 12:27 ` Stefan Agner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf63b551282772456e40645df318479f@agner.ch \
--to=stefan@agner.ch \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).