Linux GPIO subsystem development
 help / color / mirror / Atom feed
From: Claudiu Beznea <claudiu.beznea@tuxon.dev>
To: Mark Brown <broonie@kernel.org>
Cc: geert+renesas@glider.be, mturquette@baylibre.com,
	sboyd@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, biju.das.jz@bp.renesas.com,
	prabhakar.mahadev-lad.rj@bp.renesas.com, lgirdwood@gmail.com,
	magnus.damm@gmail.com, linus.walleij@linaro.org,
	support.opensource@diasemi.com, perex@perex.cz, tiwai@suse.com,
	p.zabel@pengutronix.de, Adam.Thomson.Opensource@diasemi.com,
	linux-renesas-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org,
	Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>,
	stable@vger.kernel.org
Subject: Re: [PATCH 22/31] ASoC: da7213: Populate max_register to regmap_config
Date: Wed, 6 Nov 2024 15:56:28 +0200	[thread overview]
Message-ID: <bfe67d69-66ad-4121-8c54-a874c7727002@tuxon.dev> (raw)
In-Reply-To: <d3c28a8b-878c-4894-aa23-5b360153b85d@sirena.org.uk>

Hi, Mark,

On 06.11.2024 15:43, Mark Brown wrote:
> On Wed, Nov 06, 2024 at 10:18:17AM +0200, Claudiu wrote:
>> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com>
>>
>> On the Renesas RZ/G3S SMARC Carrier II board having a DA7212 codec (using
>> da7213 driver) connected to one SSIF-2 available on the Renesas RZ/G3S SoC
>> it has been discovered that using the runtime PM API for suspend/resume
>> (as will be proposed in the following commits) leads to the codec not
>> being propertly initialized after resume. This is because w/o
>> max_register populated to regmap_config the regcache_rbtree_sync()
>> breaks on base_reg > max condition and the regcache_sync_block() call is
>> skipped.
>>
>> Fixes: ef5c2eba2412 ("ASoC: codecs: Add da7213 codec")
>> Cc: stable@vger.kernel.org
> 
> Why is this a stable fix when it only enables further work?

I thought that not syncing the cached registers might impact other setups
as well.

Also, Renesas is contributing to CIP (Civil Infrastructure Project) which
is based on stable releases. The audio support in this series will be
backported to CIP kernels. Marking it for stable ease the work to backport
the RZ/G3S audio support to CIP.

With this, would you prefer to drop the "Cc: stable@vger.kernel.org"?

Thank you,
Claudiu Beznea

  reply	other threads:[~2024-11-06 13:56 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-06  8:17 [PATCH 00/31] Add audio support for the Renesas RZ/G3S SoC Claudiu
2024-11-06  8:17 ` [PATCH 01/31] clk: renesas: r9a08g045-cpg: Add clocks, resets and power domains support for SSI Claudiu
2024-11-06  8:17 ` [PATCH 02/31] clk: versaclock3: Prepare for the addition of 5L35023 device Claudiu
2024-11-06  8:17 ` [PATCH 03/31] dt-bindings: clock: versaclock3: Document 5L35023 Versa3 clock generator Claudiu
2024-11-07 10:49   ` Krzysztof Kozlowski
2024-11-06  8:17 ` [PATCH 04/31] clk: versaclock3: Add support for the 5L35023 variant Claudiu
2024-11-06  8:18 ` [PATCH 05/31] pinctrl: renesas: rzg2l: Add audio clock pins Claudiu
2024-11-06  8:18 ` [PATCH 06/31] ASoC: sh: rz-ssi: Terminate all the DMA transactions Claudiu
2024-11-06  8:18 ` [PATCH 07/31] ASoC: sh: rz-ssi: Use only the proper amount of dividers Claudiu
2024-11-06  8:18 ` [PATCH 08/31] ASoC: sh: rz-ssi: Fix typo on SSI_RATES macro comment Claudiu
2024-11-06  8:18 ` [PATCH 09/31] ASoC: sh: rz-ssi: Remove pdev member of struct rz_ssi_priv Claudiu
2024-11-06  8:18 ` [PATCH 10/31] ASoC: sh: rz-ssi: Remove the rz_ssi_get_dai() function Claudiu
2024-11-06  8:18 ` [PATCH 11/31] ASoC: sh: rz-ssi: Remove the 2nd argument of rz_ssi_stream_is_play() Claudiu
2024-11-06 14:59   ` Geert Uytterhoeven
2024-11-06  8:18 ` [PATCH 12/31] ASoC: sh: rz-ssi: Use a proper bitmask for clear bits Claudiu
2024-11-06 14:56   ` Geert Uytterhoeven
2024-11-06 15:17     ` Claudiu Beznea
2024-11-06 15:21       ` Geert Uytterhoeven
2024-11-06 15:25         ` Claudiu Beznea
2024-11-06  8:18 ` [PATCH 13/31] ASoC: sh: rz-ssi: Use readl_poll_timeout_atomic() Claudiu
2024-11-06  8:18 ` [PATCH 14/31] ASoC: sh: rz-ssi: Use temporary variable for struct device Claudiu
2024-11-06  8:18 ` [PATCH 15/31] ASoC: sh: rz-ssi: Use goto label names that specify their actions Claudiu
2024-11-06  8:18 ` [PATCH 16/31] ASoC: sh: rz-ssi: Rely on the ASoC subsystem to runtime resume/suspend the SSI Claudiu
2024-11-06  8:18 ` [PATCH 17/31] ASoC: sh: rz-ssi: Enable runtime PM autosuspend support Claudiu
2024-11-06  8:18 ` [PATCH 18/31] ASoC: sh: rz-ssi: Add runtime PM support Claudiu
2024-11-06  8:18 ` [PATCH 19/31] ASoC: sh: rz-ssi: Issue software reset in hw_params API Claudiu
2024-11-06  8:18 ` [PATCH 20/31] ASoC: sh: rz-ssi: Add suspend to RAM support Claudiu
2024-11-06  8:18 ` [PATCH 21/31] ASoC: dt-bindings: renesas,rz-ssi: Document the Renesas RZ/G3S SoC Claudiu
2024-11-07 10:51   ` Krzysztof Kozlowski
2024-11-06  8:18 ` [PATCH 22/31] ASoC: da7213: Populate max_register to regmap_config Claudiu
2024-11-06 13:43   ` Mark Brown
2024-11-06 13:56     ` Claudiu Beznea [this message]
2024-11-06 17:19       ` Chris Paterson
2024-11-06  8:18 ` [PATCH 23/31] ASoC: da7213: Return directly the value of regcache_sync() Claudiu
2024-11-06  8:18 ` [PATCH 24/31] ASoC: da7213: Add suspend to RAM support Claudiu
2024-11-06  8:18 ` [PATCH 25/31] ASoC: da7213: Avoid setting PLL when closing audio stream Claudiu
2024-11-06  8:18 ` [PATCH 26/31] ASoC: da7213: Extend support for the MCK in range [2, 50] MHz Claudiu
2024-11-06  8:18 ` [PATCH 27/31] arm64: dts: renesas: r9a08g045: Add SSI nodes Claudiu
2024-11-06  8:18 ` [PATCH 28/31] arm64: dts: renesas: rzg3s-smarc-som: Add versa3 clock generator node Claudiu
2024-11-06  8:18 ` [PATCH 29/31] arm64: dts: renesas: Add da7212 audio codec node Claudiu
2024-11-06  8:18 ` [PATCH 30/31] arm64: dts: renesas: rzg3s-smarc: Enable SSI3 Claudiu
2024-11-06  8:18 ` [PATCH 31/31] arm64: dts: renesas: rzg3s-smarc: Add sound card Claudiu
2024-11-07  0:21 ` (subset) [PATCH 00/31] Add audio support for the Renesas RZ/G3S SoC Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bfe67d69-66ad-4121-8c54-a874c7727002@tuxon.dev \
    --to=claudiu.beznea@tuxon.dev \
    --cc=Adam.Thomson.Opensource@diasemi.com \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=broonie@kernel.org \
    --cc=claudiu.beznea.uj@bp.renesas.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mturquette@baylibre.com \
    --cc=p.zabel@pengutronix.de \
    --cc=perex@perex.cz \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=stable@vger.kernel.org \
    --cc=support.opensource@diasemi.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox