From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from layka.disroot.org (layka.disroot.org [178.21.23.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1304F20468D; Mon, 3 Feb 2025 12:40:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.21.23.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738586423; cv=none; b=hEiBGCzunqjS3tpalGUO8RnIeje4+A3PJH1ZHtQqDb7XIlx/DNLeqRIQ6BB2RiuKzg9qyOACvPSBo3hZ2JB7K9/hgy9qa9zKrE+bde0u6jz0AMrBtqgUiId+W5Fgcwq6Dt671RjIhosbE74Pu3ANu9lxA1Wmh5AjBsm+Ntfnw7I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738586423; c=relaxed/simple; bh=AkDFsgM8ht/4xOTKn+YGxCP4v6cjlpjp8uRWn5voH7o=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=p+Jl7/QB4J7x5+L3u6xAPXXe+wUQE7B0L3Dr7akbvtjo6Uk2M83BtoP9Q6TZBP+UXOW4OH0VCoGlp/pRTGdEnQ2JbgsCHNZOBXGsyhk+JRLzSvzvL36zHlP2gOBY2TKYiYdO6mE71dyCMnCptjF0oLoaS/N/3gAlMN48t0Ma55g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org; spf=pass smtp.mailfrom=disroot.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b=NiCsXrG7; arc=none smtp.client-ip=178.21.23.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=disroot.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=disroot.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=disroot.org header.i=@disroot.org header.b="NiCsXrG7" Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id E576025CAA; Mon, 3 Feb 2025 13:40:17 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id kOJee6X8J05I; Mon, 3 Feb 2025 13:40:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1738586417; bh=AkDFsgM8ht/4xOTKn+YGxCP4v6cjlpjp8uRWn5voH7o=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=NiCsXrG7LpnG5w/NFwLl1Xf4k91ChodYcxZdyx5YPPOd49ovtD7MWdYY8MSqveHJL AjJK0tAADkF89VLXYecmauRE5Gbv5iijR/wWAk4bwUHJvvvhXCYprAkat0d0TGYHIf ykOg1aVULxEsuMRLAo+lnp61mnypYcYTcGh8agQvcbDbQ93GggzGqmU2WdUo/fnERe cf0a6u52bgH+nL3XJ9zgtBTU2ZwrsvKehCSZyQANT07sLZRkG2mrLpJPC599dAG4RR gPgmAg3QdVtp9K9GV7ZrzkCmvJgfX0tErHPHs9P/aQnPsTEdcVAPpr+zHZOgyA1afb 2mgxyQClmL60Q== Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Mon, 03 Feb 2025 12:40:16 +0000 From: Kaustabh Chakraborty To: Krzysztof Kozlowski Cc: Rob Herring , Conor Dooley , Alim Akhtar , Sylwester Nawrocki , Chanwoo Choi , Michael Turquette , Stephen Boyd , Tomasz Figa , Linus Walleij , Greg Kroah-Hartman , Jiri Slaby , Lee Jones , Liam Girdwood , Mark Brown , Vinod Koul , Kishon Vijay Abraham I , Marek Szyprowski , David Airlie , Simona Vetter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Andi Shyti , Ulf Hansson , Jaehoon Chung , Vivek Gautam , Thinh Nguyen , Kees Cook , Tony Luck , "Guilherme G . Piccoli" , Sergey Lisov , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-serial@vger.kernel.org, linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, linux-mmc@vger.kernel.org, linux-hardening@vger.kernel.org, Kaustabh Chakraborty Subject: Re: [PATCH 02/33] dt-bindings: clock: add clock definitions for exynos7870 CMU In-Reply-To: <20250203-enigmatic-remarkable-beagle-709955@krzk-bin> References: <20250203-exynos7870-v1-0-2b6df476a3f0@disroot.org> <20250202190758.14986-1-kauschluss@disroot.org> <20250203-enigmatic-remarkable-beagle-709955@krzk-bin> Message-ID: X-Sender: kauschluss@disroot.org Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On 2025-02-03 07:54, Krzysztof Kozlowski wrote: > On Mon, Feb 03, 2025 at 12:37:58AM +0530, Kaustabh Chakraborty wrote: >> From: Sergey Lisov >> >> Add unique identifiers for exynos7870 clocks for every bank. It adds all >> clocks of CMU_MIF, CMU_DISPAUD, CMU_G3D, CMU_ISP, CMU_MFCMSCL, and >> CMU_PERI. >> >> Signed-off-by: Sergey Lisov >> Signed-off-by: Kaustabh Chakraborty >> --- >> include/dt-bindings/clock/exynos7870.h | 324 +++++++++++++++++++++++++ >> 1 file changed, 324 insertions(+) > > Look at git log - that's never a separate commit. Hmm, I see past examples which are mixed. 2ae5c2c3f8d586b709cf67efe94488be397d7544 Exynos850 CMU (c. 2021). CMU definitions are in a separate commit. 591020a516720e9eba1c4b1748cb73b6748e445f Exynos7885 CMU (c. 2021). CMU definitions are in a separate commit. while 96bd6224f07b8bf73e0359f15a3d7678118494e6 Exynos5433 CMU (c. 2015). CMU definitions and driver are in a single commit. Let me know if I should still continue with the approach you mentioned. > > Best regards, > Krzysztof