From: Randy Dunlap <rdunlap@infradead.org>
To: Dipen Patel <dipenp@nvidia.com>,
thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-gpio@vger.kernel.org, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, warthog618@gmail.com,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
robh+dt@kernel.org
Subject: Re: [RFC v2 03/11] hte: Add tegra194 HTE kernel provider
Date: Fri, 1 Oct 2021 16:44:05 -0700 [thread overview]
Message-ID: <c16a75ee-b0db-5433-1902-762d29bd854c@infradead.org> (raw)
In-Reply-To: <20210930232617.6396-4-dipenp@nvidia.com>
On 9/30/21 4:26 PM, Dipen Patel wrote:
> +-----------
> +The Nvidia tegra194 HTE provider driver implements two GTE
> +(Generic Timestamping Engine) instances 1) GPIO GTE and 2) LIC IRQ GTE. The
> +both GTEs instances get the timestamp from the system counter TSC which has
> +31.25MHz clock rate, and the driver converts clock tick rate to nano seconds
> +before storing it as timestamp value.
> +
> +GPIO GTE
> +--------
> +
> +This GTE instance timestamps GPIO in real time, for that to happen GPIO
> +needs to be configured as input and IRQ needs to ba enabled. The only always on
> +(AON) gpio controller instance supports timestamping GPIOs in realtime and it
Here we have text that tells what AON means, but in the first paragraph above,
there is nothing that tells us what LIC means. Please add that.
--
~Randy
next prev parent reply other threads:[~2021-10-01 23:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 23:26 [RFC v2 00/11] Intro to Hardware timestamping engine Dipen Patel
2021-09-30 23:26 ` [RFC v2 01/11] Documentation: Add HTE subsystem guide Dipen Patel
2021-10-02 0:18 ` Randy Dunlap
2021-11-03 0:36 ` Dipen Patel
2021-09-30 23:26 ` [RFC v2 02/11] drivers: Add hardware timestamp engine (HTE) Dipen Patel
2021-10-01 23:53 ` Randy Dunlap
2021-11-03 0:37 ` Dipen Patel
2021-09-30 23:26 ` [RFC v2 03/11] hte: Add tegra194 HTE kernel provider Dipen Patel
2021-10-01 23:44 ` Randy Dunlap [this message]
2021-10-02 0:07 ` Randy Dunlap
2021-11-03 1:15 ` Dipen Patel
2021-09-30 23:26 ` [RFC v2 04/11] dt-bindings: Add HTE bindings Dipen Patel
2021-10-03 21:53 ` Linus Walleij
2021-10-08 22:11 ` Rob Herring
2021-11-03 21:43 ` Dipen Patel
2021-09-30 23:26 ` [RFC v2 05/11] hte: Add Tegra194 IRQ HTE test driver Dipen Patel
2021-09-30 23:26 ` [RFC v2 06/11] gpiolib: Add HTE support Dipen Patel
2021-10-03 22:01 ` Linus Walleij
2021-09-30 23:26 ` [RFC v2 07/11] gpio: tegra186: Add HTE in gpio-tegra186 driver Dipen Patel
2021-10-08 22:16 ` Rob Herring
2021-11-03 5:05 ` Dipen Patel
2021-09-30 23:26 ` [RFC v2 08/11] gpiolib: cdev: Add hardware timestamp clock type Dipen Patel
2021-10-03 21:59 ` Linus Walleij
2021-10-03 22:09 ` Linus Walleij
2021-09-30 23:26 ` [RFC v2 09/11] tools: gpio: Add new hardware " Dipen Patel
2021-10-03 22:02 ` Linus Walleij
2021-09-30 23:26 ` [RFC v2 10/11] hte: Add tegra GPIO HTE test driver Dipen Patel
2021-10-01 23:47 ` Randy Dunlap
2021-11-03 5:07 ` Dipen Patel
2021-09-30 23:26 ` [RFC v2 11/11] MAINTAINERS: Added HTE Subsystem Dipen Patel
2021-10-02 0:08 ` Randy Dunlap
2021-10-02 4:00 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c16a75ee-b0db-5433-1902-762d29bd854c@infradead.org \
--to=rdunlap@infradead.org \
--cc=bgolaszewski@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dipenp@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).