From: Hans de Goede <hdegoede@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-gpio@vger.kernel.org,
Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v1 0/5] pinctrl: baytrail: Clean up (part 3)
Date: Thu, 12 Dec 2019 12:13:44 +0100 [thread overview]
Message-ID: <c2453fea-f423-6238-61b2-34b4e5be4998@redhat.com> (raw)
In-Reply-To: <20191212102557.87754-1-andriy.shevchenko@linux.intel.com>
Hi Andy,
On 12-12-2019 11:25, Andy Shevchenko wrote:
> This is a part 3 of clean up pin control driver for Intel Baytrail.
> After this applied the driver will use all available data structures
> from pinctrl-intel.h header.
>
> Note, that patch which exposes common pin control data structrure for drivers
> will be used by Lynxpoint as well.
>
> This has been tested on the tablet with SD card detection and buttons pressed.
>
> Based on our pinctrl/intel for-next branch.
>
> Andy Shevchenko (5):
> pinctrl: baytrail: Move IRQ valid mask initialization to a dedicated
> callback
> pinctrl: intel: Share struct intel_pinctrl for wider use
> pinctrl: baytrail: Keep pointer to struct device instead of its
> container
> pinctrl: baytrail: Use local variable to keep device pointer
> pinctrl: baytrail: Reuse struct intel_pinctrl in the driver
>
> drivers/pinctrl/intel/pinctrl-baytrail.c | 272 +++++++++++------------
> drivers/pinctrl/intel/pinctrl-intel.c | 35 +--
> drivers/pinctrl/intel/pinctrl-intel.h | 44 ++++
> 3 files changed, 173 insertions(+), 178 deletions(-)
>
>
> base-commit: ab68b220e81fd03383c0d9e1a87b51f9bbe4db77
From a quick look this series looks good to me:
Acked-by: Hans de Goede <hdegoede@redhat.com>
I've also added this to my personal tree for testing purposes, I will let
you know if I hit any problems.
Regards,
Hans
next prev parent reply other threads:[~2019-12-12 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 10:25 [PATCH v1 0/5] pinctrl: baytrail: Clean up (part 3) Andy Shevchenko
2019-12-12 10:25 ` [PATCH v1 1/5] pinctrl: baytrail: Move IRQ valid mask initialization to a dedicated callback Andy Shevchenko
2019-12-12 10:25 ` [PATCH v1 2/5] pinctrl: intel: Share struct intel_pinctrl for wider use Andy Shevchenko
2019-12-12 10:25 ` [PATCH v1 3/5] pinctrl: baytrail: Keep pointer to struct device instead of its container Andy Shevchenko
2019-12-12 10:25 ` [PATCH v1 4/5] pinctrl: baytrail: Use local variable to keep device pointer Andy Shevchenko
2019-12-12 10:25 ` [PATCH v1 5/5] pinctrl: baytrail: Reuse struct intel_pinctrl in the driver Andy Shevchenko
2019-12-12 11:13 ` Hans de Goede [this message]
2019-12-13 13:01 ` [PATCH v1 0/5] pinctrl: baytrail: Clean up (part 3) Mika Westerberg
2019-12-13 13:41 ` Linus Walleij
2019-12-13 14:47 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2453fea-f423-6238-61b2-34b4e5be4998@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).