From: Andrew Lunn <andrew@lunn.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Conor Dooley <conor@kernel.org>,
Antonio Borneo <antonio.borneo@foss.st.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
Christophe Roullier <christophe.roullier@foss.st.com>,
Fabien Dessenne <fabien.dessenne@foss.st.com>,
Valentin Caron <valentin.caron@foss.st.com>
Subject: Re: [PATCH v3 02/10] dt-bindings: pincfg-node: Add properties 'skew-delay-{in,out}put'
Date: Wed, 15 Oct 2025 18:37:32 +0200 [thread overview]
Message-ID: <c2a0f301-ec5e-42d7-9df9-09a852a199ad@lunn.ch> (raw)
In-Reply-To: <CACRpkdZT20cdH+G6Gjw8PopAkir+gGgMtRR4pkjnXFrmDkdfog@mail.gmail.com>
> I don't recall the reason for this way of defining things, but one reason
> could be that the skew-delay incurred by two inverters is very
> dependent on the production node of the silicon, and can be
> nanoseconds or picoseconds, these days mostly picoseconds.
> Example: Documentation/devicetree/bindings/net/adi,adin.yaml
I'm missing the big picture here, and i don't see an example of these
properties being used. However, since you reference an old networking
example, for RGMII delays....
adi,rx-internal-delay-ps should be deprecated, we now have the generic
rx-internal-delay-ps. The point about using -ps is however still
valid.
However, i would not like to see pinctl DT properties used in place of
rx-internal-delay-ps. How the Ethernet MAC driver implements
rx-internal-delay-ps is left open, so calling a pinctl API to set the
skew is fine by me. And if the real use case has nothing to do with
networking, then i don't care.
Andrew
next prev parent reply other threads:[~2025-10-15 16:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 14:04 [PATCH v3 00/10] pinctrl: stm32: Support I/O synchronization Antonio Borneo
2025-10-14 14:04 ` [PATCH v3 01/10] pinctrl: pinconf-generic: Add properties 'skew-delay-{in,out}put' Antonio Borneo
2025-10-14 14:04 ` [PATCH v3 02/10] dt-bindings: pincfg-node: " Antonio Borneo
2025-10-14 18:04 ` Conor Dooley
2025-10-14 19:33 ` Linus Walleij
2025-10-14 19:39 ` Conor Dooley
2025-10-15 12:52 ` Antonio Borneo
2025-10-16 22:34 ` Linus Walleij
2025-10-15 16:37 ` Andrew Lunn [this message]
2025-10-16 22:41 ` Linus Walleij
2025-10-14 14:04 ` [PATCH v3 03/10] pinctrl: stm32: Rework stm32_pconf_parse_conf() Antonio Borneo
2025-10-14 14:04 ` [PATCH v3 04/10] pinctrl: stm32: Simplify handling of backup pin status Antonio Borneo
2025-10-14 14:04 ` [PATCH v3 05/10] pinctrl: stm32: Drop useless spinlock save and restore Antonio Borneo
2025-10-14 14:04 ` [PATCH v3 06/10] pinctrl: stm32: Avoid keeping a bool value in a u32 variable Antonio Borneo
2025-10-14 14:04 ` [PATCH v3 07/10] pinctrl: stm32: Support I/O synchronization parameters Antonio Borneo
2025-10-14 14:04 ` [PATCH v3 08/10] dt-bindings: pinctrl: stm32: Use properties from pincfg-node.yaml Antonio Borneo
2025-10-14 18:05 ` Conor Dooley
2025-10-14 14:04 ` [PATCH v3 09/10] dt-bindings: pinctrl: stm32: Support I/O synchronization parameters Antonio Borneo
2025-10-14 18:10 ` Conor Dooley
2025-10-15 12:56 ` Antonio Borneo
2025-10-15 14:35 ` Conor Dooley
2025-10-20 15:09 ` Antonio Borneo
2025-10-20 22:08 ` Linus Walleij
2025-10-21 11:49 ` Antonio Borneo
2025-10-21 12:26 ` Linus Walleij
2025-10-14 14:04 ` [PATCH v3 10/10] arm64: dts: st: Add I/O sync to eth pinctrl in stm32mp25-pinctrl.dtsi Antonio Borneo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2a0f301-ec5e-42d7-9df9-09a852a199ad@lunn.ch \
--to=andrew@lunn.ch \
--cc=alexandre.torgue@foss.st.com \
--cc=antonio.borneo@foss.st.com \
--cc=brgl@bgdev.pl \
--cc=christophe.roullier@foss.st.com \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabien.dessenne@foss.st.com \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh@kernel.org \
--cc=valentin.caron@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).