Re: [PATCH v4 2/4] pinctrl: samsung: add dedicated SoC eint suspend/resume callbacks

[Krzysztof Kozlowski <krzk@kernel.org>]

On 07/03/2025 11:29, Peter Griffin wrote:
> gs101 needs it's own suspend/resume callbacks to use the newly
> added eint_fltcon_offset for saving & restoring fltcon0 & fltcon1
> registers. It also differs to previous SoCs in that fltcon1
> register doesn't always exist for each bank.
> 
> exynosautov920 also has dedicated logic for using eint_con_offset
> and eint_mask_offset for saving & restoring it's registers.
> 
> Refactor the existing platform specific suspend/resume callback
> so that each SoC variant has their own callback containing the
> SoC specific logic.
> 


> Additionally we now call drvdata->suspend() & drvdata->resume()
> from within the loop that iterates the banks in
> samsung_pinctrl_suspend() and samsung_pinctrl_resume().
>
> This simplifies the logic, and allows us to remove the
> clk_enable() and clk_disable() from the callbacks.

Can you make this a separate commit? This would be nicely self-contained
and without any functional impact.

Getting own suspend/resume would be the next commit.


Best regards,
Krzysztof