From mboxrd@z Thu Jan 1 00:00:00 1970 From: Haojian Zhuang Subject: Re: [PATCH] pinctrl: single: Remove invalid message Date: Sun, 17 Dec 2017 13:25:13 +0800 Message-ID: References: <20171214165115.27150-1-tony@atomide.com> Reply-To: haojian.zhuang@linaro.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:41016 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750770AbdLQFlW (ORCPT ); Sun, 17 Dec 2017 00:41:22 -0500 Received: by mail-pg0-f68.google.com with SMTP id o2so7914767pgc.8 for ; Sat, 16 Dec 2017 21:41:21 -0800 (PST) In-Reply-To: <20171214165115.27150-1-tony@atomide.com> Content-Language: en-US Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Tony Lindgren , Linus Walleij Cc: Grygorii Strashko , Nishanth Menon , linux-gpio@vger.kernel.org, linux-omap@vger.kernel.org On 2017/12/15 0:51, Tony Lindgren wrote: > Pinctrl single should just show how many pins were found, the physical > address is already in the dev information. So let's remove the wrong > information that claims to show the physical address but really prints > a virtual address that is now hashed. > > Signed-off-by: Tony Lindgren > --- > drivers/pinctrl/pinctrl-single.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-single.c b/drivers/pinctrl/pinctrl-single.c > --- a/drivers/pinctrl/pinctrl-single.c > +++ b/drivers/pinctrl/pinctrl-single.c > @@ -1774,8 +1774,7 @@ static int pcs_probe(struct platform_device *pdev) > dev_warn(pcs->dev, "initialized with no interrupts\n"); > } > > - dev_info(pcs->dev, "%i pins at pa %p size %u\n", > - pcs->desc.npins, pcs->base, pcs->size); > + dev_info(pcs->dev, "%i pins, size %u\n", pcs->desc.npins, pcs->size); > > return pinctrl_enable(pcs->pctl); > > Hi Tony, If there's only one pinctrl region in SoC, it's fine to remove the pa part. But there're always multiple pinctrl regions in Hisilicon SoCs. It causes multiple pinctrl register bases are used. Will it cause debug information harder to read when pa parts are removed? Best Regards Haojian