From: Ceclan Dumitru-Ioan <mitrutzceclan@gmail.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, andy@kernel.org,
linux-gpio@vger.kernel.org,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Michael Walle" <michael@walle.cc>,
"Andy Shevchenko" <andy.shevchenko@gmail.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"ChiaEn Wu" <chiaen_wu@richtek.com>,
"Niklas Schnelle" <schnelle@linux.ibm.com>,
"Leonard Göhrs" <l.goehrs@pengutronix.de>,
"Mike Looijmans" <mike.looijmans@topic.nl>,
"Haibo Chen" <haibo.chen@nxp.com>,
"Hugo Villeneuve" <hvilleneuve@dimonoff.com>,
"Ceclan Dumitru" <dumitru.ceclan@analog.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: ad7173: add AD7173 driver
Date: Tue, 3 Oct 2023 13:33:36 +0300 [thread overview]
Message-ID: <c52afe87-eaa0-eb7f-090f-b22aec95e49d@gmail.com> (raw)
In-Reply-To: <20230930150531.083c51d4@jic23-huawei>
On 9/30/23 17:05, Jonathan Cameron wrote:
> On Thu, 28 Sep 2023 15:54:43 +0300
> Dumitru Ceclan <mitrutzceclan@gmail.com> wrote>> +config AD7173
>> + tristate "Analog Devices AD7173 driver"
>> + depends on SPI_MASTER
>> + select AD_SIGMA_DELTA
>> + select GPIO_REGMAP
> If you are selecting it, why does it have if guards in the driver.
> I prefer the select here, so drop this if guards.
From what i checked, selecting GPIO_REGMAP does not select GPIOLIB but only REGMAP.
Also, in the thread from V1 Arnd Bergmann suggested:
" I think the best way to handle these is to remove both
the 'select' and the #ifdef in the driver and instead use
'if (IS_ENABLED(CONFIG_GPIOLIB))' to handle optional gpio
providers in the code. "
next prev parent reply other threads:[~2023-10-03 10:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 12:54 [PATCH v2 1/2] dt-bindings: adc: add AD7173 Dumitru Ceclan
2023-09-28 12:54 ` [PATCH v2 2/2] iio: adc: ad7173: add AD7173 driver Dumitru Ceclan
2023-09-28 13:29 ` Ceclan Dumitru-Ioan
2023-09-28 23:29 ` kernel test robot
2023-09-30 13:29 ` Jonathan Cameron
2023-09-30 14:05 ` Jonathan Cameron
2023-10-03 10:33 ` Ceclan Dumitru-Ioan [this message]
2023-10-03 10:45 ` Andy Shevchenko
2023-10-03 10:57 ` Ceclan Dumitru-Ioan
2023-10-03 11:02 ` Andy Shevchenko
2023-10-03 11:39 ` Arnd Bergmann
2023-10-04 7:07 ` Michael Walle
2023-10-04 22:02 ` kernel test robot
2023-09-30 9:45 ` [PATCH v2 1/2] dt-bindings: adc: add AD7173 Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c52afe87-eaa0-eb7f-090f-b22aec95e49d@gmail.com \
--to=mitrutzceclan@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@kernel.org \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=chiaen_wu@richtek.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dumitru.ceclan@analog.com \
--cc=haibo.chen@nxp.com \
--cc=hvilleneuve@dimonoff.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.goehrs@pengutronix.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@walle.cc \
--cc=mike.looijmans@topic.nl \
--cc=robh+dt@kernel.org \
--cc=schnelle@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).