From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 072E0E75445 for ; Tue, 3 Oct 2023 10:33:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231682AbjJCKdp (ORCPT ); Tue, 3 Oct 2023 06:33:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231680AbjJCKdo (ORCPT ); Tue, 3 Oct 2023 06:33:44 -0400 Received: from mail-ed1-x52f.google.com (mail-ed1-x52f.google.com [IPv6:2a00:1450:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98EE2B3; Tue, 3 Oct 2023 03:33:40 -0700 (PDT) Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-533cbbd0153so1207978a12.0; Tue, 03 Oct 2023 03:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696329219; x=1696934019; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J/WhFVjfA28clBMUuGiPeq+RU/kn5UwfaZNEZffja6o=; b=Ckg/6iY3LPQp0Q0jQvFiQrKLTbnIzAGBtd2IP1uSwXxqVgcs5TkCybmFpjdwi6C/TG 1L1ObxgsCPiG76gR9/0iPyWy8lX89HmAcit4FmxBZ4zxVNjl3Mt0eIFgeFH2HQRZEqgT HUGZuik0FU1uwIN6PBTnsXOD0nE61WqFtcXHiD30sVwt618owRy20J/7Cz6xycbYfGoZ iR4Z7KGzYo9jNJLfOiMXFi+1kVZq9f7MLy7vGb4J20WjMKmdMrQByFpupQwq5SfEmIag FLkf9htJ4oFPbhkv6oYGhaj9UMB6Kg2TFG5FluwEh2hcSEs58++TU5+/Aoggxd9NINs1 ZhDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696329219; x=1696934019; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=J/WhFVjfA28clBMUuGiPeq+RU/kn5UwfaZNEZffja6o=; b=ToFLjjTZh6vwUxfvh09IjQW+l7wAt6K3AV7F075/YfRGQ64KLUyRe2eVNW6ZCRbsi/ QQwBX7k+QNqtpE0I8xPYiNvz+8j9NktIFbcwKI0Hbc+2JJtzx73pIROzmAf9tDPn3Cv7 Xe+rNXvdKJE0IYlawUJ3GQ7+gPw8am+xV6gZCwLEGJAb5Q+IAu2AjaU/GgLseQjMHaMq Q/H+1oqNMzA1tZ0aQdSofmm/5/Fd1zwAlXCERtDVry7M7e46Dl9azqnjbiGYY6XbNKVw 9MPuWlCfaP+qDwSEoAEWJem7aJcP4k88CZElYjb1MVHjs4EbA6yNLW0ZlGyWyd7blhd8 xtVQ== X-Gm-Message-State: AOJu0YxnsMxuFsgaQMGFqcXhh/pA6ropTPRmPY9CmZkYt421e78Nk9nj fbXfH5sjzgbjIz3yB4yN/Wb4OLbFLg7fAQLV X-Google-Smtp-Source: AGHT+IFfx16hk+3TKsdvFVRiT8Hmfx8XAO9TSLCnESlY/wH2HQ9arzhYWBibHzQolmpk/cd4rMuhSQ== X-Received: by 2002:a17:906:101a:b0:9b2:babb:5fe9 with SMTP id 26-20020a170906101a00b009b2babb5fe9mr12719211ejm.23.1696329218778; Tue, 03 Oct 2023 03:33:38 -0700 (PDT) Received: from [10.76.84.110] ([5.2.194.157]) by smtp.gmail.com with ESMTPSA id h27-20020a170906261b00b0099bd86f9248sm835102ejc.63.2023.10.03.03.33.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Oct 2023 03:33:38 -0700 (PDT) Message-ID: Date: Tue, 3 Oct 2023 13:33:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 2/2] iio: adc: ad7173: add AD7173 driver Content-Language: en-US To: Jonathan Cameron Cc: linus.walleij@linaro.org, brgl@bgdev.pl, andy@kernel.org, linux-gpio@vger.kernel.org, Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Walle , Andy Shevchenko , Arnd Bergmann , ChiaEn Wu , Niklas Schnelle , =?UTF-8?Q?Leonard_G=c3=b6hrs?= , Mike Looijmans , Haibo Chen , Hugo Villeneuve , Ceclan Dumitru , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230928125443.615006-1-mitrutzceclan@gmail.com> <20230928125443.615006-2-mitrutzceclan@gmail.com> <20230930150531.083c51d4@jic23-huawei> From: Ceclan Dumitru-Ioan In-Reply-To: <20230930150531.083c51d4@jic23-huawei> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 9/30/23 17:05, Jonathan Cameron wrote: > On Thu, 28 Sep 2023 15:54:43 +0300 > Dumitru Ceclan wrote>> +config AD7173 >> + tristate "Analog Devices AD7173 driver" >> + depends on SPI_MASTER >> + select AD_SIGMA_DELTA >> + select GPIO_REGMAP > If you are selecting it, why does it have if guards in the driver. > I prefer the select here, so drop this if guards. >From what i checked, selecting GPIO_REGMAP does not select GPIOLIB but only REGMAP. Also, in the thread from V1 Arnd Bergmann suggested: " I think the best way to handle these is to remove both the 'select' and the #ifdef in the driver and instead use 'if (IS_ENABLED(CONFIG_GPIOLIB))' to handle optional gpio providers in the code. "