From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [rft, PATCH v1 1/1] pinctrl: qcom: lpass-lpi: Remove unused member in struct lpi_pingroup
Date: Tue, 21 Nov 2023 08:14:09 +0100 [thread overview]
Message-ID: <c622c2a5-665f-4ee3-b3dd-fafb3adf6191@linaro.org> (raw)
In-Reply-To: <20231120193353.1670732-1-andriy.shevchenko@linux.intel.com>
On 20/11/2023 20:26, Andy Shevchenko wrote:
> The group is not used anywhere, remove it. And if needed, it should be
> struct pingroup anyway.
>
> While at it, replace kernel.h with what exactly being used.
Missing Reported-by and Closes by for LKP... Unless you discovered it
without its report?
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> _Seems_ like this (I only read the code), hence rft.
>
> drivers/pinctrl/qcom/pinctrl-lpass-lpi.h | 6 +----
> .../pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c | 16 -------------
> .../pinctrl/qcom/pinctrl-sc8280xp-lpass-lpi.c | 20 ----------------
> .../pinctrl/qcom/pinctrl-sm6115-lpass-lpi.c | 20 ----------------
> .../pinctrl/qcom/pinctrl-sm8250-lpass-lpi.c | 15 ------------
> .../pinctrl/qcom/pinctrl-sm8350-lpass-lpi.c | 16 -------------
> .../pinctrl/qcom/pinctrl-sm8450-lpass-lpi.c | 24 -------------------
Missing sm8550.
> 7 files changed, 1 insertion(+), 116 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h
> index 206b2c0ca828..a9b2f65c1ebe 100644
> --- a/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h
> +++ b/drivers/pinctrl/qcom/pinctrl-lpass-lpi.h
> @@ -6,8 +6,8 @@
> #ifndef __PINCTRL_LPASS_LPI_H__
> #define __PINCTRL_LPASS_LPI_H__
>
> +#include <linux/array_size.h>
> #include <linux/bits.h>
> -#include <linux/kernel.h>
>
> #include "../core.h"
>
> @@ -45,11 +45,8 @@ struct pinctrl_pin_desc;
>
> #define LPI_PINGROUP(id, soff, f1, f2, f3, f4) \
> { \
> - .group.name = "gpio" #id, \
> - .group.pins = gpio##id##_pins, \
Aren't these used by core pinctrl code?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-21 7:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 19:26 [rft, PATCH v1 1/1] pinctrl: qcom: lpass-lpi: Remove unused member in struct lpi_pingroup Andy Shevchenko
2023-11-20 23:39 ` kernel test robot
2023-11-21 3:47 ` kernel test robot
2023-11-21 7:14 ` Krzysztof Kozlowski [this message]
2023-11-21 17:15 ` Andy Shevchenko
2023-11-22 15:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c622c2a5-665f-4ee3-b3dd-fafb3adf6191@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=konrad.dybcio@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).