Re: [PATCH 1/2] gpiolib: introduce devm_fwnode_gpiod_get_optional() wrapper

[Matti Vaittinen <mazziesaccount@gmail.com>]

On 23/01/2026 11:51, Michael Tretter wrote:
> From: Stefan Kerkmann <s.kerkmann@pengutronix.de>
> 
> The helper makes it easier to handle optional GPIOs and simplifies the
> error handling code.
> 
> Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
>   include/linux/gpio/consumer.h | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
> 
> diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
> index cafeb7a40ad1..9328b67e26c0 100644
> --- a/include/linux/gpio/consumer.h
> +++ b/include/linux/gpio/consumer.h
> @@ -607,6 +607,23 @@ struct gpio_desc *devm_fwnode_gpiod_get(struct device *dev,
>   					   flags, label);
>   }
>   
> +static inline
> +struct gpio_desc *devm_fwnode_gpiod_get_optional(struct device *dev,
> +						 struct fwnode_handle *fwnode,
> +						 const char *con_id,
> +						 enum gpiod_flags flags,
> +						 const char *label)

I would like to see the kerneldoc for this. Other than that, it looks 
great to me.

> +{
> +	struct gpio_desc *desc;
> +
> +	desc = devm_fwnode_gpiod_get_index(dev, fwnode, con_id, 0,
> +					   flags, label);
> +	if (IS_ERR(desc) && PTR_ERR(desc) == -ENOENT)
> +		return NULL;
> +
> +	return desc;
> +}
> +
>   struct acpi_gpio_params {
>   	unsigned int crs_entry_index;
>   	unsigned short line_index;
> 

Yours,
	-- Matti


-- 
---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~