[PATCH 0/2] gpiolib: introduce devm_fwnode_gpiod_get_optional

[PATCH 0/2] gpiolib: introduce devm_fwnode_gpiod_get_optional

[Michael Tretter]

There are various helpers to simplify the handling of optional gpios.
The devm_fwnode_gpiod_get() lacks the _optional variant, and drivers
have to explicitly handle the error for optional gpios.

Introduce a devm_fwnode_gpiod_get_optional helper and simplify the
BD71815 voltage regulator driver by using this helper.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
Michael Tretter (1):
      regulator: bd71815: switch to devm_fwnode_gpiod_get_optional

Stefan Kerkmann (1):
      gpiolib: introduce devm_fwnode_gpiod_get_optional() wrapper

 drivers/regulator/bd71815-regulator.c | 15 ++++++---------
 include/linux/gpio/consumer.h         | 17 +++++++++++++++++
 2 files changed, 23 insertions(+), 9 deletions(-)
---
base-commit: c072629f05d7bca1148ab17690d7922a31423984
change-id: 20260123-gpio-devm_fwnode_gpiod_get_optional-e96227cd393b

Best regards,
-- 
Michael Tretter <m.tretter@pengutronix.de>

[PATCH 1/2] gpiolib: introduce devm_fwnode_gpiod_get_optional() wrapper

[Michael Tretter]

From: Stefan Kerkmann <s.kerkmann@pengutronix.de>

The helper makes it easier to handle optional GPIOs and simplifies the
error handling code.

Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 include/linux/gpio/consumer.h | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
index cafeb7a40ad1..9328b67e26c0 100644
--- a/include/linux/gpio/consumer.h
+++ b/include/linux/gpio/consumer.h
@@ -607,6 +607,23 @@ struct gpio_desc *devm_fwnode_gpiod_get(struct device *dev,
 					   flags, label);
 }
 
+static inline
+struct gpio_desc *devm_fwnode_gpiod_get_optional(struct device *dev,
+						 struct fwnode_handle *fwnode,
+						 const char *con_id,
+						 enum gpiod_flags flags,
+						 const char *label)
+{
+	struct gpio_desc *desc;
+
+	desc = devm_fwnode_gpiod_get_index(dev, fwnode, con_id, 0,
+					   flags, label);
+	if (IS_ERR(desc) && PTR_ERR(desc) == -ENOENT)
+		return NULL;
+
+	return desc;
+}
+
 struct acpi_gpio_params {
 	unsigned int crs_entry_index;
 	unsigned short line_index;

-- 
2.47.3

Re: [PATCH 1/2] gpiolib: introduce devm_fwnode_gpiod_get_optional() wrapper

[Matti Vaittinen]

On 23/01/2026 11:51, Michael Tretter wrote:
> From: Stefan Kerkmann <s.kerkmann@pengutronix.de>
> 
> The helper makes it easier to handle optional GPIOs and simplifies the
> error handling code.
> 
> Signed-off-by: Stefan Kerkmann <s.kerkmann@pengutronix.de>
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
>   include/linux/gpio/consumer.h | 17 +++++++++++++++++
>   1 file changed, 17 insertions(+)
> 
> diff --git a/include/linux/gpio/consumer.h b/include/linux/gpio/consumer.h
> index cafeb7a40ad1..9328b67e26c0 100644
> --- a/include/linux/gpio/consumer.h
> +++ b/include/linux/gpio/consumer.h
> @@ -607,6 +607,23 @@ struct gpio_desc *devm_fwnode_gpiod_get(struct device *dev,
>   					   flags, label);
>   }
>   
> +static inline
> +struct gpio_desc *devm_fwnode_gpiod_get_optional(struct device *dev,
> +						 struct fwnode_handle *fwnode,
> +						 const char *con_id,
> +						 enum gpiod_flags flags,
> +						 const char *label)

I would like to see the kerneldoc for this. Other than that, it looks 
great to me.

> +{
> +	struct gpio_desc *desc;
> +
> +	desc = devm_fwnode_gpiod_get_index(dev, fwnode, con_id, 0,
> +					   flags, label);
> +	if (IS_ERR(desc) && PTR_ERR(desc) == -ENOENT)
> +		return NULL;
> +
> +	return desc;
> +}
> +
>   struct acpi_gpio_params {
>   	unsigned int crs_entry_index;
>   	unsigned short line_index;
> 

Yours,
	-- Matti


-- 
---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

[PATCH 2/2] regulator: bd71815: switch to devm_fwnode_gpiod_get_optional

[Michael Tretter]

Use the devm_fwnode_gpiod_get_optional variant to simplify the error
handling code.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
---
 drivers/regulator/bd71815-regulator.c | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

diff --git a/drivers/regulator/bd71815-regulator.c b/drivers/regulator/bd71815-regulator.c
index 8da57a7bb2f1..668714f35464 100644
--- a/drivers/regulator/bd71815-regulator.c
+++ b/drivers/regulator/bd71815-regulator.c
@@ -571,15 +571,12 @@ static int bd7181x_probe(struct platform_device *pdev)
 		return -ENODEV;
 	}
 
-	ldo4_en = devm_fwnode_gpiod_get(&pdev->dev,
-					dev_fwnode(pdev->dev.parent),
-					"rohm,vsel", GPIOD_ASIS, "ldo4-en");
-	if (IS_ERR(ldo4_en)) {
-		ret = PTR_ERR(ldo4_en);
-		if (ret != -ENOENT)
-			return ret;
-		ldo4_en = NULL;
-	}
+	ldo4_en = devm_fwnode_gpiod_get_optional(&pdev->dev,
+						 dev_fwnode(pdev->dev.parent),
+						 "rohm,vsel", GPIOD_ASIS,
+						 "ldo4-en");
+	if (IS_ERR(ldo4_en))
+		return PTR_ERR(ldo4_en);
 
 	/* Disable to go to ship-mode */
 	ret = regmap_update_bits(regmap, BD71815_REG_PWRCTRL, RESTARTEN, 0);

-- 
2.47.3

Re: [PATCH 2/2] regulator: bd71815: switch to devm_fwnode_gpiod_get_optional

[Matti Vaittinen]

On 23/01/2026 11:51, Michael Tretter wrote:
> Use the devm_fwnode_gpiod_get_optional variant to simplify the error
> handling code.
> 
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>

Thanks!

Reviewed-by: Matti Vaittinen <mazziesaccount@gmail.com>

Yours,
	-- Matti
---
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~

Re: [PATCH 2/2] regulator: bd71815: switch to devm_fwnode_gpiod_get_optional

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 196 bytes --]

On Fri, Jan 23, 2026 at 10:51:06AM +0100, Michael Tretter wrote:
> Use the devm_fwnode_gpiod_get_optional variant to simplify the error
> handling code.

Acked-by: Mark Brown <broonie@kernel.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 0/2] gpiolib: introduce devm_fwnode_gpiod_get_optional

[Bartosz Golaszewski]

On Fri, Jan 23, 2026 at 10:51 AM Michael Tretter
<m.tretter@pengutronix.de> wrote:
>
> There are various helpers to simplify the handling of optional gpios.
> The devm_fwnode_gpiod_get() lacks the _optional variant, and drivers
> have to explicitly handle the error for optional gpios.
>
> Introduce a devm_fwnode_gpiod_get_optional helper and simplify the
> BD71815 voltage regulator driver by using this helper.
>
> Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> ---
> Michael Tretter (1):
>       regulator: bd71815: switch to devm_fwnode_gpiod_get_optional
>
> Stefan Kerkmann (1):
>       gpiolib: introduce devm_fwnode_gpiod_get_optional() wrapper
>
>  drivers/regulator/bd71815-regulator.c | 15 ++++++---------
>  include/linux/gpio/consumer.h         | 17 +++++++++++++++++
>  2 files changed, 23 insertions(+), 9 deletions(-)
> ---
> base-commit: c072629f05d7bca1148ab17690d7922a31423984
> change-id: 20260123-gpio-devm_fwnode_gpiod_get_optional-e96227cd393b
>
> Best regards,
> --
> Michael Tretter <m.tretter@pengutronix.de>
>

If you can send a v2 with added kerneldoc, I can queue this up for
v7.0 and Mark can then queue patch 2 in the next cycle. Unless it's
urgent, let me know if it is.

Bart

Re: [PATCH 0/2] gpiolib: introduce devm_fwnode_gpiod_get_optional

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 295 bytes --]

On Mon, Jan 26, 2026 at 02:50:27PM +0100, Bartosz Golaszewski wrote:

> If you can send a v2 with added kerneldoc, I can queue this up for
> v7.0 and Mark can then queue patch 2 in the next cycle. Unless it's
> urgent, let me know if it is.

I'm happy for you to just apply patch 2 if you want.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 0/2] gpiolib: introduce devm_fwnode_gpiod_get_optional

[Bartosz Golaszewski]

On Mon, Jan 26, 2026 at 3:01 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Mon, Jan 26, 2026 at 02:50:27PM +0100, Bartosz Golaszewski wrote:
>
> > If you can send a v2 with added kerneldoc, I can queue this up for
> > v7.0 and Mark can then queue patch 2 in the next cycle. Unless it's
> > urgent, let me know if it is.
>
> I'm happy for you to just apply patch 2 if you want.

Sure, just please leave your Ack under v2.

Bart

Re: [PATCH 0/2] gpiolib: introduce devm_fwnode_gpiod_get_optional

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 304 bytes --]

On Mon, Jan 26, 2026 at 04:14:14PM +0100, Bartosz Golaszewski wrote:
> On Mon, Jan 26, 2026 at 3:01 PM Mark Brown <broonie@kernel.org> wrote:

> > I'm happy for you to just apply patch 2 if you want.

> Sure, just please leave your Ack under v2.

I think he carried it forward from v1 already?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 0/2] gpiolib: introduce devm_fwnode_gpiod_get_optional

[Bartosz Golaszewski]

On Mon, Jan 26, 2026 at 4:20 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Mon, Jan 26, 2026 at 04:14:14PM +0100, Bartosz Golaszewski wrote:
> > On Mon, Jan 26, 2026 at 3:01 PM Mark Brown <broonie@kernel.org> wrote:
>
> > > I'm happy for you to just apply patch 2 if you want.
>
> > Sure, just please leave your Ack under v2.
>
> I think he carried it forward from v1 already?

Indeed. Thanks.

Bart

Re: [PATCH 0/2] gpiolib: introduce devm_fwnode_gpiod_get_optional

[Michael Tretter]

On Mon, 26 Jan 2026 14:50:27 +0100, Bartosz Golaszewski wrote:
> On Fri, Jan 23, 2026 at 10:51 AM Michael Tretter
> <m.tretter@pengutronix.de> wrote:
> >
> > There are various helpers to simplify the handling of optional gpios.
> > The devm_fwnode_gpiod_get() lacks the _optional variant, and drivers
> > have to explicitly handle the error for optional gpios.
> >
> > Introduce a devm_fwnode_gpiod_get_optional helper and simplify the
> > BD71815 voltage regulator driver by using this helper.
> >
> > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > ---
> > Michael Tretter (1):
> >       regulator: bd71815: switch to devm_fwnode_gpiod_get_optional
> >
> > Stefan Kerkmann (1):
> >       gpiolib: introduce devm_fwnode_gpiod_get_optional() wrapper
> >
> >  drivers/regulator/bd71815-regulator.c | 15 ++++++---------
> >  include/linux/gpio/consumer.h         | 17 +++++++++++++++++
> >  2 files changed, 23 insertions(+), 9 deletions(-)
> > ---
> > base-commit: c072629f05d7bca1148ab17690d7922a31423984
> > change-id: 20260123-gpio-devm_fwnode_gpiod_get_optional-e96227cd393b
> >
> > Best regards,
> > --
> > Michael Tretter <m.tretter@pengutronix.de>
> >
> 
> If you can send a v2 with added kerneldoc, I can queue this up for
> v7.0 and Mark can then queue patch 2 in the next cycle. Unless it's
> urgent, let me know if it is.

The patch isn't urgent. I just sent v2 with added kerneldoc, anyway.

Thanks!

Michael