linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Antonio Borneo <antonio.borneo@foss.st.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: "Rob Herring" <robh@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	"Clément Le Goffic" <legoffic.clement@gmail.com>,
	"Amelie Delaunay" <amelie.delaunay@foss.st.com>,
	"Pascal Paillet" <p.paillet@foss.st.com>
Subject: Re: [PATCH v2 02/15] dt-bindings: pinctrl: stm32: use strings for enum property 'st,package'
Date: Thu, 20 Nov 2025 10:50:49 +0100	[thread overview]
Message-ID: <c74339727ef2d9c106129cba2de58cc20645ce9a.camel@foss.st.com> (raw)
In-Reply-To: <CACRpkdYuRas_jgi5K9hbxtJLrxxQ+wS-dJcunT5m48qS0tKXAA@mail.gmail.com>

On Wed, 2025-11-19 at 15:16 +0100, Linus Walleij wrote:
> On Tue, Nov 18, 2025 at 5:20 PM Antonio Borneo
> <antonio.borneo@foss.st.com> wrote:
> 
> > The property 'st,package' reports the SoC package used in the
> > board DT and is used to inform the driver about which pins are
> > available for use by the pinctrl driver.
> > It has historically been declared as an uint32 enum, where each
> > value is a power of 2.
> > 
> > Deprecate the use of the numeric value and replace it with more
> > readable string values.
> > 
> > Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
> 
> I think Krzysztof is right about this, deprecate the property and
> (re-)introduce it on the top level in:
> Documentation/devicetree/bindings/arm/stm32/stm32.yaml
> 

Yes, I agree with Krzysztof comment. This is not a property that belongs to pinctrl.
I will deprecate it in the existing bindings.


> It may be a bit quirky to get to this property from the pin control
> Linux driver, but it is the right thing to do.
> 
> The Vexpress has some inspirational top-level custom properties:
> Documentation/devicetree/bindings/arm/arm,vexpress-juno.yaml

I was looking for some top-level custom property, but I've missed this. Thanks for the hint.

Best Regards,
Antonio

  reply	other threads:[~2025-11-20  9:51 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-18 16:19 [PATCH v2 00/15] pinctrl: stm32: rework SoC package and add STM32MP21 Antonio Borneo
2025-11-18 16:19 ` [PATCH v2 01/15] pinctrl: stm32: accept string value for property 'st,package' Antonio Borneo
2025-11-18 16:19 ` [PATCH v2 02/15] dt-bindings: pinctrl: stm32: use strings for enum " Antonio Borneo
2025-11-19  7:27   ` Krzysztof Kozlowski
2025-11-19 14:16   ` Linus Walleij
2025-11-20  9:50     ` Antonio Borneo [this message]
2025-11-18 16:19 ` [PATCH v2 03/15] arm: dts: stm32: update property 'st,package' to new bindings Antonio Borneo
2025-11-18 16:19 ` [PATCH v2 04/15] arm64: dts: st: " Antonio Borneo
2025-11-18 16:19 ` [PATCH v2 05/15] pinctrl: stm32: add new package to stm32mp257 pinctrl support Antonio Borneo
2025-11-20  4:25   ` kernel test robot
2025-11-18 16:19 ` [PATCH v2 06/15] dt-bindings: " Antonio Borneo
2025-11-18 16:19 ` [PATCH v2 07/15] arm64: dts: st: add new package file for stm32mp25 pinctrl Antonio Borneo
2025-11-18 16:19 ` [PATCH v2 08/15] pinctrl: stm32: add stm32mp215 pinctrl support Antonio Borneo
2025-11-18 16:19 ` [PATCH v2 09/15] dt-bindings: pinctrl: stm32: support for stm32mp215 and additional packages Antonio Borneo
2025-11-18 16:19 ` [PATCH v2 10/15] arm64: dts: st: introduce stm32mp21 pinctrl files Antonio Borneo
2025-11-18 16:19 ` [PATCH v2 11/15] arm64: dts: st: add interrupt to optee node on stm32mp21 Antonio Borneo
2025-11-18 16:19 ` [PATCH v2 12/15] arm64: dts: st: add exti1 and exti2 nodes " Antonio Borneo
2025-11-18 16:19 ` [PATCH v2 13/15] arm64: dts: st: add pinctrl " Antonio Borneo
2025-11-18 16:19 ` [PATCH v2 14/15] arm64: dts: st: add pinctrl to usart2 on stm32mp215f-dk board Antonio Borneo
2025-11-18 16:19 ` [PATCH v2 15/15] arm64: dts: st: add heartbeat LED " Antonio Borneo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c74339727ef2d9c106129cba2de58cc20645ce9a.camel@foss.st.com \
    --to=antonio.borneo@foss.st.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=amelie.delaunay@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=legoffic.clement@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=p.paillet@foss.st.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).