linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrey Gusakov <andrey.gusakov@cogentembedded.com>,
	Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
	LUU HOAI <hoai.luu.ub@renesas.com>
Subject: Re: [PATCH v2] pinctrl: renesas: r8a779[56]x: add MediaLB pins
Date: Thu, 14 Oct 2021 22:26:58 +0300	[thread overview]
Message-ID: <c8234074-a22e-72f9-fbe7-e65d6af74eec@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdU2Nr1V035Ntz-XNrc10t7femUFt_WV+Q3EHiWZD5HmkQ@mail.gmail.com>

Hi,

> 
> Obviously not only the mlb_3pin groups, but also the functions have to
> be moved to the automotive[] arrays ;-)
> 
> I'll fix these up while applying, so no need to resend.

Looking at error mail from build robot (cited below).

Looks like also must put definitions of mlb_3pin_groups[] / mlb_3pin_mux[] / mlb_3pin_pins[] under GEN3 
ifdefs.

What are the proper steps now - send a v3 of the original patch, or send a fix to what is in linux-next ?

Nikita


 > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
 > head:   8006b911c90a4ec09958447d24c8a4c3538f5723
 > commit: 23f87fe82c0341ff79807fb5f92a05a33ce1b055 [7355/7806] pinctrl: renesas: r8a779[56]x: Add 
MediaLB pins
 > config: sh-buildonly-randconfig-r002-20211014 (attached as .config)
 > compiler: sh4-linux-gcc (GCC) 11.2.0
 > reproduce (this is a W=1 build):
 >          wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
 >          chmod +x ~/bin/make.cross
 >          # 
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=23f87fe82c0341ff79807fb5f92a05a33ce1b055
 >          git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
 >          git fetch --no-tags linux-next master
 >          git checkout 23f87fe82c0341ff79807fb5f92a05a33ce1b055
 >          # save the attached .config to linux build tree
 >          COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=sh
 >
 > If you fix the issue, kindly add following tag as appropriate
 > Reported-by: kernel test robot <lkp@intel.com>
 >
 > All errors (new ones prefixed by >>):
 >
 >>> drivers/pinctrl/renesas/pfc-r8a77965.c:5030:27: error: 'mlb_3pin_groups' defined but not used 
[-Werror=unused-const-variable=]
 >      5030 | static const char * const mlb_3pin_groups[] = {
 >           |                           ^~~~~~~~~~~~~~~
 >>> drivers/pinctrl/renesas/pfc-r8a77965.c:2616:27: error: 'mlb_3pin_mux' defined but not used 
[-Werror=unused-const-variable=]
 >      2616 | static const unsigned int mlb_3pin_mux[] = {
 >           |                           ^~~~~~~~~~~~
 >>> drivers/pinctrl/renesas/pfc-r8a77965.c:2613:27: error: 'mlb_3pin_pins' defined but not used 
[-Werror=unused-const-variable=]
 >      2613 | static const unsigned int mlb_3pin_pins[] = {
 >           |                           ^~~~~~~~~~~~~
 >     cc1: all warnings being treated as errors
 > --
 >>> drivers/pinctrl/renesas/pfc-r8a77951.c:4807:27: error: 'mlb_3pin_groups' defined but not used 
[-Werror=unused-const-variable=]
 >      4807 | static const char * const mlb_3pin_groups[] = {
 >           |                           ^~~~~~~~~~~~~~~
 >>> drivers/pinctrl/renesas/pfc-r8a77951.c:2460:27: error: 'mlb_3pin_mux' defined but not used 
[-Werror=unused-const-variable=]
 >      2460 | static const unsigned int mlb_3pin_mux[] = {
 >           |                           ^~~~~~~~~~~~
 >>> drivers/pinctrl/renesas/pfc-r8a77951.c:2457:27: error: 'mlb_3pin_pins' defined but not used 
[-Werror=unused-const-variable=]
 >      2457 | static const unsigned int mlb_3pin_pins[] = {
 >           |                           ^~~~~~~~~~~~~
 >     cc1: all warnings being treated as errors
 >
 >
 > vim +/mlb_3pin_groups +5030 drivers/pinctrl/renesas/pfc-r8a77965.c
 >
 >    5029	
 >> 5030	static const char * const mlb_3pin_groups[] = {
 >    5031		"mlb_3pin",
 >    5032	};
 >    5033	
 >


  reply	other threads:[~2021-10-14 19:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-29 21:13 [PATCH] pinctrl: renesas: r8a779[56]x: add MediaLB pins Nikita Yushchenko
2021-10-07 16:48 ` Geert Uytterhoeven
2021-10-07 20:02   ` [PATCH v2] " Nikita Yushchenko
2021-10-08 12:48     ` Geert Uytterhoeven
2021-10-14 19:26       ` Nikita Yushchenko [this message]
2021-10-14 19:39         ` Geert Uytterhoeven
2021-10-15  7:57           ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c8234074-a22e-72f9-fbe7-e65d6af74eec@cogentembedded.com \
    --to=nikita.yoush@cogentembedded.com \
    --cc=andrey.gusakov@cogentembedded.com \
    --cc=geert@linux-m68k.org \
    --cc=hoai.luu.ub@renesas.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=vladimir.barinov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).