Re: [PATCH v3 0/3] arm64: dts: imx8mp: add support for the ABB SoM and carrier

[Heiko Schocher <hs@denx.de>]

Hello Rob,

On 05.11.24 14:11, Rob Herring (Arm) wrote:
> 
> On Tue, 05 Nov 2024 07:42:03 +0100, Heiko Schocher wrote:
>> The board uses an ABB specific SoM from ADLink, based on NXP
>> i.MX8MP SoC. The SoM is used on 3 different carrier boards,
>> with small differences.
>>
>> series is based on:
>> 819837584309 - (tag: v6.12-rc5, origin/master, origin/HEAD) Linux 6.12-rc5
>>
>> patches are now checked with
>>
>> make W=1 dt_binding_check
>> make W=1 dtbs_check
>> make W=1 CHECK_DTBS=y {for each dtb introduced in this series)
>>
>> as Krzysztof suggested.
>>
>> Changes in v3:
>> added Reviewed-by from Krzysztof
>> - worked in comments from Krzysztof
>>    gpio-line-names should match the actual number of
>>    gpios of the device.
>> - added comments from Shawn Guo
>>    removed unneeded new lines
>>    sort nodes, properties alphabetical
>>    rename pcie0-refclk -> clock-xxx
>>    used GPIO_ACTIVE_HIGH instead of 0
>> - added comments from Fabio Estevam
>>    instead of settting each brightness-level in
>>    brightness-levels add num-interpolated-steps
>> - changes from me
>>    fix gpio-line-names for semtech gpio controller
>>    in imx8mp-aristainetos3-proton2s.dts as patch
>>    "dt-bindings: pinctrl: sx150xq: allow gpio line naming"
>>    of this series adds the dtb checks for them and 17 entries
>>    needed now.
>>
>> Changes in v2:
>> reworked the compatible strings for ABB imx8mp based boards
>> called dtb checks, no errors for this patch
>> patch dt-bindings: pinctrl: sx150xq: allow gpio line naming new in v2
>> - worked in comments from Krzysztof
>>    - removed unneeded dtbos and build now dtbs for each
>>      carrierboard.
>>    - removed user spidev entries, as I do not know the
>>      real spi devices connected to...
>>    - call dtb check targets as described in cover letter
>>      and fixed warnings except warnings see below:
>> not fixed dtb check warnings
>> - pci (warning pops up for each new dtb from this patch, but
>>    also for a lot of other boards, which are already in tree)
>> imx8mp-aristainetos3-adpismarc.dtb: pcie-ep@33800000: reg: [[864026624, 4194304], [402653184, 134217728]] is too short
>>          from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie-ep.yaml#
>> imx8mp-aristainetos3-adpismarc.dtb: pcie-ep@33800000: reg-names: ['dbi', 'addr_space'] is too short
>>          from schema $id: http://devicetree.org/schemas/pci/fsl,imx6q-pcie-ep.yaml#
>> - proton2s dtb specific:
>>    - rs485
>>      imx8mp-aristainetos3-proton2s.dtb: serial@30a60000: rs485-rts-delay:0: 0 is not of type 'array'
>>          from schema $id: http://devicetree.org/schemas/serial/fsl-imx-uart.yaml#
>>      imx8mp-aristainetos3-proton2s.dtb: serial@30a60000: rs485-rts-delay:1: 0 is not of type 'array'
>>          from schema $id: http://devicetree.org/schemas/serial/fsl-imx-uart.yaml#
>>      imx8mp-aristainetos3-proton2s.dtb: serial@30a60000: Unevaluated properties are not allowed ('linux,rs485-enabled-at-boot-time', 'rs485-rts-active-low', 'rs485-rts-delay' were unexpected)
>>          from schema $id: http://devicetree.org/schemas/serial/fsl-imx-uart.yaml#
>>      do not see, what I am doing wrong, also rs485 works fine
>>    - led driver
>>      imx8mp-aristainetos3-proton2s.dtb: /soc@0/bus@30800000/i2c@30a30000/tlc59108@40: failed to match any schema with compatible: ['ti,tlc59108']
>>      I use the comaptible entry used in drivers/leds/leds-tlc591xx.c
>>      Ah, may because file
>>      Documentation/devicetree/bindings/leds/leds-tlc591xx.txt
>>      is not converted to yaml?
>>    - pinctrl driver
>>      adding 'gpio-line-names' leads in a warning as this property
>>      is not checked yet (and so a warning is dropped).
>>      add this check in new patch
>>      dt-bindings: pinctrl: sx150xq: allow gpio line naming
>>      in v2
>>
>> Heiko Schocher (3):
>>    dt-bindings: arm: fsl: Add ABB SoM and carrier
>>    dt-bindings: pinctrl: sx150xq: allow gpio line naming
>>    arm64: dts: imx8mp: add aristainetos3 board support
>>
>>   .../devicetree/bindings/arm/fsl.yaml          |    9 +
>>   .../bindings/pinctrl/semtech,sx1501q.yaml     |   43 +
>>   arch/arm64/boot/dts/freescale/Makefile        |    5 +
>>   .../imx8mp-aristainetos3-adpismarc.dts        |   37 +
>>   .../imx8mp-aristainetos3-helios-lvds.dtso     |  113 ++
>>   .../freescale/imx8mp-aristainetos3-helios.dts |   98 ++
>>   .../imx8mp-aristainetos3-proton2s.dts         |  161 +++
>>   .../imx8mp-aristainetos3a-som-v1.dtsi         | 1107 +++++++++++++++++
>>   8 files changed, 1573 insertions(+)
>>   create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-adpismarc.dts
>>   create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-helios-lvds.dtso
>>   create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-helios.dts
>>   create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-proton2s.dts
>>   create mode 100644 arch/arm64/boot/dts/freescale/imx8mp-aristainetos3a-som-v1.dtsi
>>
>> --
>> 2.20.1
>>
>>
>>
> 
> 
> My bot found new DTB warnings on the .dts files added or changed in this
> series.
> 
> Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
> are fixed by another series. Ultimately, it is up to the platform
> maintainer whether these warnings are acceptable or not. No need to reply
> unless the platform maintainer has comments.
> 
> If you already ran DT checks and didn't see these error(s), then
> make sure dt-schema is up to date:
> 
>    pip3 install dtschema --upgrade
> 
> 
> New warnings running 'make CHECK_DTBS=y freescale/imx8mp-aristainetos3-adpismarc.dtb freescale/imx8mp-aristainetos3-helios.dtb freescale/imx8mp-aristainetos3-proton2s.dtb' for 20241105064206.43626-1-hs@denx.de:
> 
> arch/arm64/boot/dts/freescale/imx8mp-aristainetos3-proton2s.dtb: /soc@0/bus@30800000/i2c@30a30000/tlc59108@40: failed to match any schema with compatible: ['ti,tlc59108']

Yep, reason I explained above in commit comment:

 >>    - led driver
 >>      imx8mp-aristainetos3-proton2s.dtb: /soc@0/bus@30800000/i2c@30a30000/tlc59108@40: failed to 
match any schema with compatible: ['ti,tlc59108']
 >>      I use the comaptible entry used in drivers/leds/leds-tlc591xx.c
 >>      Ah, may because file
 >>      Documentation/devicetree/bindings/leds/leds-tlc591xx.txt
 >>      is not converted to yaml?

So the compatible entry is fully okay, just the check is poping up,
as yaml file is missing...

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs@denx.de