Re: [PATCH v2 2/3] pinctrl: Ingenic: Correct the pullup and pulldown parameters of JZ4780

[Zhou Yanjie <zhouyanjie@wanyeetech.com>]

Hi Paul,

在 2020/9/6 下午10:26, Paul Cercueil 写道:
> Hi Zhou,
>
> Le lun. 31 août 2020 à 23:43, 周琰杰 (Zhou Yanjie) 
> <zhouyanjie@wanyeetech.com> a écrit :
>> Correct the pullup and pulldown parameters of JZ4780 to make them
>> consistent with the parameters on the datasheet.
>>
>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>> ---
>>
>> Notes:
>>     v2:
>>     New patch.
>>
>>  drivers/pinctrl/pinctrl-ingenic.c | 12 ++++++++++--
>>  1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/pinctrl/pinctrl-ingenic.c 
>> b/drivers/pinctrl/pinctrl-ingenic.c
>> index 00f29fd684fa..ae7b8876d3b4 100644
>> --- a/drivers/pinctrl/pinctrl-ingenic.c
>> +++ b/drivers/pinctrl/pinctrl-ingenic.c
>> @@ -1035,6 +1035,14 @@ static const struct ingenic_chip_info 
>> jz4770_chip_info = {
>>      .pull_downs = jz4770_pull_downs,
>>  };
>>
>> +static const u32 jz4780_pull_ups[6] = {
>> +    0x3fffffff, 0xfff0f3fc, 0x0fffffff, 0xffff4fff, 0xffff7b7c, 
>> 0x7fa7f00f,
>> +};
>
> PE15 has a pull-up in my datasheet.
>

Yep,  you are right, it has a pull-up, I will fix it in the next version.

Thanks and best regards!

> The rest looks good.
>
> Cheers,
> -Paul
>
>> +
>> +static const u32 jz4780_pull_downs[6] = {
>> +    0x00000000, 0x000f0c03, 0x00000000, 0x0000b000, 0x00000483, 
>> 0x00580ff0,
>> +};
>> +
>>  static int jz4780_uart2_data_pins[] = { 0x66, 0x67, };
>>  static int jz4780_uart2_hwflow_pins[] = { 0x65, 0x64, };
>>  static int jz4780_uart4_data_pins[] = { 0x54, 0x4a, };
>> @@ -1301,8 +1309,8 @@ static const struct ingenic_chip_info 
>> jz4780_chip_info = {
>>      .num_groups = ARRAY_SIZE(jz4780_groups),
>>      .functions = jz4780_functions,
>>      .num_functions = ARRAY_SIZE(jz4780_functions),
>> -    .pull_ups = jz4770_pull_ups,
>> -    .pull_downs = jz4770_pull_downs,
>> +    .pull_ups = jz4780_pull_ups,
>> +    .pull_downs = jz4780_pull_downs,
>>  };
>>
>>  static const u32 x1000_pull_ups[4] = {
>> -- 
>> 2.11.0
>>
>