From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Guodong Liu <guodong.liu@mediatek.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sean Wang <sean.wang@kernel.org>
Cc: Sean Wang <sean.wang@mediatek.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v4 3/3] pinctrl: canonical rsel resistance selection property
Date: Mon, 14 Feb 2022 11:02:33 +0100 [thread overview]
Message-ID: <c9ab3f7c-9b12-0c51-3de2-4abf42cdfb74@collabora.com> (raw)
In-Reply-To: <20220214030631.4969-4-guodong.liu@mediatek.com>
Il 14/02/22 04:06, Guodong Liu ha scritto:
> Change "mediatek,rsel_resistance_in_si_unit" to
> "mediatek,rsel-resistance-in-si-unit"
>
> Fixes: fb34a9ae383a ("pinctrl: mediatek: support rsel feature")
> Signed-off-by: Guodong Liu <guodong.liu@mediatek.com>
A note for maintainers: luckily, this property hasn't been used in any device-tree
yet, so we luckily (since naming convention was not compliant) don't have to worry
about retro-compatibility for old DTs; so...
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-paris.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c
> index d4e02c5d74a8..38c0f0c4cf95 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-paris.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c
> @@ -989,7 +989,7 @@ int mtk_paris_pinctrl_probe(struct platform_device *pdev,
> hw->nbase = hw->soc->nbase_names;
>
> if (of_find_property(hw->dev->of_node,
> - "mediatek,rsel_resistance_in_si_unit", NULL))
> + "mediatek,rsel-resistance-in-si-unit", NULL))
> hw->rsel_si_unit = true;
> else
> hw->rsel_si_unit = false;
>
prev parent reply other threads:[~2022-02-14 10:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 3:06 [PATCH v4 0/3] pinctrl: mediatek: Support pinctrl driver on mt8186 Guodong Liu
2022-02-14 3:06 ` [PATCH v4 1/3] dt-bindings: pinctrl: mt8186: add pinctrl file and binding document Guodong Liu
2022-02-14 9:58 ` AngeloGioacchino Del Regno
2022-02-16 3:28 ` Guodong Liu
2022-02-14 3:06 ` [PATCH v4 2/3] pinctrl: add pinctrl driver on mt8186 Guodong Liu
2022-02-14 9:59 ` AngeloGioacchino Del Regno
2022-02-14 3:06 ` [PATCH v4 3/3] pinctrl: canonical rsel resistance selection property Guodong Liu
2022-02-14 10:02 ` AngeloGioacchino Del Regno [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9ab3f7c-9b12-0c51-3de2-4abf42cdfb74@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=guodong.liu@mediatek.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).