From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86880C43217 for ; Mon, 14 Feb 2022 10:37:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348511AbiBNKhT (ORCPT ); Mon, 14 Feb 2022 05:37:19 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:49168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349454AbiBNKgb (ORCPT ); Mon, 14 Feb 2022 05:36:31 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C6F96715B8; Mon, 14 Feb 2022 02:02:48 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 1E7051F43053 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1644832956; bh=EZtxgxaV8/I+n1d7kbiGccMyE4bZCHZgIhArtvVlxB4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=htFbV/VNcgY4e6NmjbTgWCT0U8vZZXgz2EkFHdw5T7VYpUSU/xek0vZEQ8ZV9UFQO Qx3ahY8d7vxDW3H0k4fBsj1X070vtiA5LoDwnQN2JMeAr4j1v8S/wUkCopc4LTqkX8 c/ZKYxcnJLgjFbnF3R027FjtRqM5nhPH+SnY3ic7mN7X/BqlYsrJVLUQmrM31GIB0I PYfrNvgMjWw4gmBmzwVBibGvDRRhWjA1EqE3dRYHEhoK2U9DDpKwKWtt+T3ifVqWIq 6g50M5CWKaxFaAwnMUe3CRfkFxGQ2v/BHquLmIwyODtbFc8X0I4nX0Bvizjx9biB6w SGzfEywYKl8KQ== Message-ID: Date: Mon, 14 Feb 2022 11:02:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v4 3/3] pinctrl: canonical rsel resistance selection property Content-Language: en-US To: Guodong Liu , Linus Walleij , Rob Herring , Matthias Brugger , Sean Wang Cc: Sean Wang , linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220214030631.4969-1-guodong.liu@mediatek.com> <20220214030631.4969-4-guodong.liu@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220214030631.4969-4-guodong.liu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Il 14/02/22 04:06, Guodong Liu ha scritto: > Change "mediatek,rsel_resistance_in_si_unit" to > "mediatek,rsel-resistance-in-si-unit" > > Fixes: fb34a9ae383a ("pinctrl: mediatek: support rsel feature") > Signed-off-by: Guodong Liu A note for maintainers: luckily, this property hasn't been used in any device-tree yet, so we luckily (since naming convention was not compliant) don't have to worry about retro-compatibility for old DTs; so... Reviewed-by: AngeloGioacchino Del Regno > --- > drivers/pinctrl/mediatek/pinctrl-paris.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-paris.c b/drivers/pinctrl/mediatek/pinctrl-paris.c > index d4e02c5d74a8..38c0f0c4cf95 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-paris.c > +++ b/drivers/pinctrl/mediatek/pinctrl-paris.c > @@ -989,7 +989,7 @@ int mtk_paris_pinctrl_probe(struct platform_device *pdev, > hw->nbase = hw->soc->nbase_names; > > if (of_find_property(hw->dev->of_node, > - "mediatek,rsel_resistance_in_si_unit", NULL)) > + "mediatek,rsel-resistance-in-si-unit", NULL)) > hw->rsel_si_unit = true; > else > hw->rsel_si_unit = false; >