From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2518EDE988 for ; Thu, 14 Sep 2023 07:11:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235878AbjINHLZ (ORCPT ); Thu, 14 Sep 2023 03:11:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60898 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235856AbjINHLZ (ORCPT ); Thu, 14 Sep 2023 03:11:25 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4612CCD for ; Thu, 14 Sep 2023 00:11:20 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-401b393ddd2so6833465e9.0 for ; Thu, 14 Sep 2023 00:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694675479; x=1695280279; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5h0ZuDwh1rf6DxeXFX2hTo7zsJWLjsfMyXea4lnDesA=; b=yn+Mq0Gwxu96XJ0pRlPE3ZHPPEMARv/MUIyxzg9ZjQ2x+eC0yl9G7ybGOtO1VzxmSM 2RTK+7Kgtk6ZhpVU/Rto5VGGttTUp6H++SQ8IX0g913daaZddSqOoQ7zQQWb0cMS7kNe C+4sHCLoPUzbc9pLMaqgygkM9i+GaAyJM8BcW6pE4v/i3yAXAakSrhdva8O0wsuU/Qzj uKhVYEr1fg5xNMUXvdJxuldXbXey2m5B1qW+5SDWbZQjYnSfxV4V5WOEvCR9b2CRzBMr zoXIw5n8YARfWt4/OgICDrFkUOw16zgiaTyLWzdD36RHxqLhxB6X2Dn7ZB/gBtPUO3Py c1Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694675479; x=1695280279; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5h0ZuDwh1rf6DxeXFX2hTo7zsJWLjsfMyXea4lnDesA=; b=S5tX+HMGmnopGQZWTGsDtSwcoKjF1bCcwINkrWtRvhvok9ZTIOoxvXAM1kcfzacdwX 2pVEMd0PjjLWis8NnyooY6KMQD9ETO9yMZaHQzAEMb0oPZT5dVDJ1GA2iB2wmwFs589p 2Zny08clM59rScmg2b0665oh7NZR8zUjffCEH+BZYrh/K1zT+cwIUe+Pi0+RB9kmMlDT Ahi2+q5c6vqOmO54D9vssVXkGbuj0LgUK3sJixQPCI6XaeYqcTidVkGqcG1ZtNLWK/zk A4+eiMB5QHSoX99PwuYNGDDgvGgSpHBVpJ5+2Jiw1Wjs4nEkUNN5AiVnD4UnLqNs6m0o FE6g== X-Gm-Message-State: AOJu0YyGkPX03TUOmYjdGiX0hEhXmo8tUCgOs77kShCUpGLAKFRUDA1d Fv9AwbFUW1dwwTcj8dyQHxOkqg== X-Google-Smtp-Source: AGHT+IGepcioAmLDJ5yHj/4XT3khz32VPFxMtQxJjTkGxn1Sec0dfMWaMrgX4erCJapFuFurG6tFqg== X-Received: by 2002:adf:ee08:0:b0:319:8c35:37b with SMTP id y8-20020adfee08000000b003198c35037bmr4177430wrn.7.1694675479125; Thu, 14 Sep 2023 00:11:19 -0700 (PDT) Received: from [192.168.1.20] ([178.197.214.188]) by smtp.gmail.com with ESMTPSA id m6-20020adfe946000000b0031980783d78sm918742wrn.54.2023.09.14.00.11.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Sep 2023 00:11:18 -0700 (PDT) Message-ID: Date: Thu, 14 Sep 2023 09:11:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node To: Peng Fan , "Peng Fan (OSS)" , Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Stefan Agner , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , dl-linux-imx Cc: "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" References: <20230914-vf610-gpio-v1-0-3ed418182a6a@nxp.com> <20230914-vf610-gpio-v1-5-3ed418182a6a@nxp.com> <9fc4817d-00ae-aaf4-bfb6-b24361f55799@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 14/09/2023 08:53, Peng Fan wrote: >> Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node >> >> On 14/09/2023 08:04, Peng Fan wrote: >>>> Subject: Re: [PATCH 5/5] arm64: dts: imx93: update gpio node >>>> >>>> On 14/09/2023 04:21, Peng Fan (OSS) wrote: >>>>> From: Peng Fan >>>>> >>>>> Per binding doc, i.MX93 GPIO supports two interrupts, and not >>>>> compatible with i.MX7ULP. So update the node >>>>> >>>>> Signed-off-by: Peng Fan >>>>> --- >>>>> arch/arm64/boot/dts/freescale/imx93.dtsi | 20 ++++++++++++-------- >>>>> 1 file changed, 12 insertions(+), 8 deletions(-) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi >>>>> b/arch/arm64/boot/dts/freescale/imx93.dtsi >>>>> index 6f85a05ee7e1..011c34a57c53 100644 >>>>> --- a/arch/arm64/boot/dts/freescale/imx93.dtsi >>>>> +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi >>>>> @@ -825,11 +825,12 @@ usdhc3: mmc@428b0000 { >>>>> }; >>>>> >>>>> gpio2: gpio@43810080 { >>>>> - compatible = "fsl,imx93-gpio", "fsl,imx7ulp-gpio"; >>>>> + compatible = "fsl,imx93-gpio", "fsl,imx8ulp-gpio"; >>>> >>>> As your driver change points, it is breaking users, so no :( >>> >>> ok. Although i.MX93 GPIO is not compatible with i.MX7ULP from HW >>> perspective, the compatible string should keep as it is now and >>> binding >> >> If it is not compatible, then how could it work before? > > i.MX7ULP reg: > 0h Port Data Output Register (PDOR) > 4h Port Set Output Register (PSOR) > 8h Port Clear Output Register (PCOR) > Ch Port Toggle Output Register (PTOR) > 10h Port Data Input Register (PDIR) > 14h Port Data Direction Register (PDDR) > > i.MX8ULP/93 has different registers address, but > i.MX93 registers has 0x40 off as below: > 40h Port Data Output (PDOR) > > Even linux i.MX7ULP gpio driver could work with i.MX8ULP/93 > GPIO HW with dts node using an 0x40 offset + base addr > for i.MX93 gpio. I think from hw design, they are > not compatible. Besides the upper differences, > there are other differences. Sorry, I don't understand it. I asked how could they work before in Linux, if they are not compatible, and you pasted regs. So again - if they are not compatible, how could it work? Or maybe it never worked? But then commit msg would say it. Best regards, Krzysztof