From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C20E25613 for ; Fri, 15 Mar 2024 13:18:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710508686; cv=none; b=EdI7DIlJMi/wcAudPEx8xGmO3wgJ0df6kIkPSHG4yfI1DBigu7XkXPJlUEzgChlXpV1uClCUZkvk9S6g8nbrSQdCyqqGU1ELDHnCkFkzdcw1obUwCsZZNC3opbWmNUGxGJOMmRyrWKhTyR8a4wjTVD71ML+UGI5G+dzadWDG1k0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1710508686; c=relaxed/simple; bh=T/HfBhiQE1waDWYQEd1vD78rXPyQGtudkxEwrgNEHpM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=sU0SYglxjdKSOQ1fN/ABYH07my5/ZVs6ysdqQPp6ixkXRYVNFyhW+H84TwbJLOoFEtvojMMYl2wIi3YuM4bjGZZD4Kp2kdSW9eeerEJIum6tArqhWBkwZ+PR/6kzMSH/crYM/2AbNO+SzAeebxfcY+X1yIXS3ZoRlSKNOFNhYJk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=SvBaGvP/; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="SvBaGvP/" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-41324a16c9eso13360755e9.0 for ; Fri, 15 Mar 2024 06:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1710508683; x=1711113483; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BAvj14vJUGomBSxrVqhPVayHAwF+lgqULbYlbgwOBiU=; b=SvBaGvP/UksjyWCCiLK9EIV8EEDnxFbMgOrLqbR647u/fgdd+h6QPq97xOfwC8TBHB d5Z2L8NZIUiYLhF/UM+X5z6/PJ8A0SsMvlWPsLak8r/Xf70Zbl6vAudT6OogOUpHUHFQ MMAG3txLF6jTzyHwuu1vS9AKn+ylPwprBUmpEKBsMpLJH3pdyHbYIkVJ9RdFkYeMdORW ywHqs9dFiXrzzpWrreJPOb2aLNDOyM1hxf+1uz3gk1r7bVthll0mEpQ9lA99uSkSwZ8c Xb3eUhywYM8nsO6Jhh+Emwim6hXpEVfSE3clFr4naOQo6kCZ4aElB6J0bL1u4pJWdhLV 2Oww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710508683; x=1711113483; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BAvj14vJUGomBSxrVqhPVayHAwF+lgqULbYlbgwOBiU=; b=PRXjOD0IdeBKwBSqx6bxCYuRr41KOeNwXCx0+TMae81G0pIkdYty+8ar/QLgL1yuMw uRD50gOlKqPl2A0JfOTT4N58QYco+psvUhRVBKDhOhhqph8avZwdHMdOgd46L1jNGRPF m+pzTfnE0OoJ5pQyxFgPxN35bxK0GymBUngOnV34sBTJ86yEH6IL1w/RG5wgXgoDdbu0 9hSZxhfr47PdFY0Bh32oGkHJju+hJevCYVx3/nSYSmc82gCY2yhRc0rRvUsAUj7ROSu3 wY51OhdgpBpxC3m60vPNdF41XDJaTeTqFRoBrKR9cmIqlUbC7OkiR1qslJyxqI6rAkNN YYGg== X-Forwarded-Encrypted: i=1; AJvYcCWaslgTGrnLalhkwWFdob/FDE82f2Cx602an3q9CE8gawigQVKnPUgSOpj6CpMGQowZze1TNNNT1m3C9P8qsuwuvgZPioDN8UgQrw== X-Gm-Message-State: AOJu0Yw3Xs3x5oLdufqBn4i52dvPkml4xhR/f2lrgzBxWr227atkEYpi x4dPGg8ai1bchNo9cAoZUtlLwPIdJm7tiyTkQxko2aj49NICxWaTY4B2j351bG8= X-Google-Smtp-Source: AGHT+IHlUY3Az6uwRCsdn4XHEMvaEDhhX0HkGvtTN9jqjiaiqubgf+xJXK+Mvnp/afaT+k0YwpLk1g== X-Received: by 2002:a05:600c:4f94:b0:413:f1c0:8a5d with SMTP id n20-20020a05600c4f9400b00413f1c08a5dmr3796731wmq.26.1710508682802; Fri, 15 Mar 2024 06:18:02 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id fl22-20020a05600c0b9600b00414013adab2sm1909935wmb.6.2024.03.15.06.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Mar 2024 06:18:02 -0700 (PDT) Date: Fri, 15 Mar 2024 16:17:58 +0300 From: Dan Carpenter To: Jan Dakinevich Cc: Neil Armstrong , Jerome Brunet , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Kevin Hilman , Martin Blumenstingl , Liam Girdwood , Mark Brown , Linus Walleij , Jaroslav Kysela , Takashi Iwai , linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, alsa-devel@alsa-project.org, linux-sound@vger.kernel.org, linux-gpio@vger.kernel.org, kernel@salutedevices.com Subject: Re: [PATCH 06/25] ASoC: meson: g12a-toacodec: fix "Lane Select" width Message-ID: References: <20240314232201.2102178-1-jan.dakinevich@salutedevices.com> <20240314232201.2102178-7-jan.dakinevich@salutedevices.com> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240314232201.2102178-7-jan.dakinevich@salutedevices.com> On Fri, Mar 15, 2024 at 02:21:42AM +0300, Jan Dakinevich wrote: > For both G12A and SM1 the width of "Lane Select" should be 2, not 3. > Otherwise, it overlaps with "Source". > > Signed-off-by: Jan Dakinevich When you resend this, could you describe how this bug might look to a user? If a user hits this bug and they want to see if it has been fixed by reading the commit messages, I don't think this description is sufficient for that. regards, dan carpenter