linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Levente Révész" <levente.revesz@eilabs.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Martyn Welch <martyn.welch@collabora.com>,
	Haibo Chen <haibo.chen@nxp.com>, Puyou Lu <puyou.lu@gmail.com>,
	Justin Chen <justinpopo6@gmail.com>,
	Andrey Gusakov <andrey.gusakov@cogentembedded.com>,
	"Peter Robinson <pbrobinson"@gmail.com,
	Nate Drude <nate.d@variscite.com>
Cc: linux-gpio@vger.kernel.org
Subject: [PATCH v2 0/6] gpio: pca953x: Add interrupt mask support for pca953x chips
Date: Wed, 26 Oct 2022 13:17:45 +0200	[thread overview]
Message-ID: <cc987520-d95b-01b9-5b65-53442ce122f6@eilabs.com> (raw)

Hello,

Some chips in the pca953x family have an interrupt mask register in
addition to the standard 4 registers:

    0: INPUT
    1: OUTPUT
    2: POLARITY
    3: CONFIGURATION
    4: INTERRUPT MASK

Chips with this register:

    - pca9505
    - pca9506
    - pca9698

The interrupt mask register defaults to all interrupts disabled, so
interrupts are unusable unless the driver sets this register.

Interrupt masking is already implemented for pcal chips. That
implementation could be extended to support this register as well.

This patch series adds support for the interrupt mask register in
mentioned pca chips.

Kind regards,
Levente

---
Changes in v2:

    1. Implemented Andy Shevchenko's suggestions.
    2. Added pca953x_is_pcal_type(), pca953x_has_interrupt() and
       pca953x_has_int_mask_reg() functions.
    3. Included Martyn Welch's suggestion.
    4. Added interrupt support for pca9698 in a new patch.

Levente Révész (6):
  gpio: pca953x: Convert PCA_TYPE from bits to number
  gpio: pca953x: Add PCAL953X as a separate chip type
  gpio: pca953x: Add helper function to check if chip has interrupts
  gpio: pca953x: Generalize interrupt mask register handling
  gpio: pca953x: Add interrupt mask support for chips with the standard
    register set
  gpio: pca953x: Enable interrupt for pca9698

 drivers/gpio/gpio-pca953x.c | 212 ++++++++++++++++++++++++------------
 1 file changed, 140 insertions(+), 72 deletions(-)

-- 
2.37.3


             reply	other threads:[~2022-10-26 11:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-26 11:17 Levente Révész [this message]
2022-10-26 11:18 ` [PATCH v2 1/6] gpio: pca953x: Convert PCA_TYPE from bits to number Levente Révész
2022-10-26 17:18   ` Andy Shevchenko
2022-10-26 17:21     ` Andy Shevchenko
2022-10-26 11:21 ` [PATCH v2 2/6] gpio: pca953x: Add PCAL953X as a separate chip type Levente Révész
2022-10-26 17:25   ` Andy Shevchenko
2022-10-26 17:28   ` Andy Shevchenko
2022-10-27 13:36     ` Levente Révész
2022-10-27 13:54       ` Martyn Welch
2022-10-27 17:03         ` Andy Shevchenko
2022-10-28 18:57           ` Levente Révész
2022-11-16 13:51             ` Levente Révész
2025-02-26 14:02             ` Andy Shevchenko
2022-10-26 11:22 ` [PATCH v2 3/6] gpio: pca953x: Add helper function to check if chip has interrupts Levente Révész
2022-10-26 11:23 ` [PATCH v2 4/6] gpio: pca953x: Generalize interrupt mask register handling Levente Révész
2022-10-26 17:31   ` Andy Shevchenko
2022-10-26 11:25 ` [PATCH v2 5/6] gpio: pca953x: Add interrupt mask support for chips with the standard register set Levente Révész
2022-10-26 16:49   ` kernel test robot
2022-10-26 17:32   ` Andy Shevchenko
2022-10-26 22:13   ` kernel test robot
2022-10-26 22:13   ` kernel test robot
2022-10-26 11:26 ` [PATCH v2 6/6] gpio: pca953x: Enable interrupt for pca9698 Levente Révész

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cc987520-d95b-01b9-5b65-53442ce122f6@eilabs.com \
    --to=levente.revesz@eilabs.com \
    --cc="Peter Robinson <pbrobinson"@gmail.com \
    --cc=andrey.gusakov@cogentembedded.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=brgl@bgdev.pl \
    --cc=haibo.chen@nxp.com \
    --cc=justinpopo6@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=martyn.welch@collabora.com \
    --cc=nate.d@variscite.com \
    --cc=puyou.lu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).