From: Krzysztof Kozlowski <krzk@kernel.org>
To: Prasad Kumpatla <quic_pkumpatl@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Srinivas Kandagatla <srini@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: cros-qcom-dts-watchers@chromium.org,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, kernel@oss.qualcomm.com,
Mohammad Rafi Shaik <quic_mohs@quicinc.com>
Subject: Re: [PATCH v5 3/9] ASoC: qcom: dt-bindings: qcom,lpass-va-macro: Update bindings for clocks to support ADSP
Date: Thu, 3 Jul 2025 13:35:16 +0200 [thread overview]
Message-ID: <cdc33ace-0979-426e-a1db-b90c8310e8af@kernel.org> (raw)
In-Reply-To: <8fa30d8f-8737-4bda-a5dd-d7deb8f0896c@quicinc.com>
On 03/07/2025 13:18, Prasad Kumpatla wrote:
>>
>>> enabled using power domains in lpass-va-macro which is not applicable
>>> for ADSP based platform.
>>>
>>> Reference:
>>> - qcom,lpass-tx-macro.yaml
>>> - qcom,lpass-rx-macro.yaml
>>
>> I don't understand this reference.
>
> Please refer below link for more info. Which is similar kind of
> properties used.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/Documentation/devicetree/bindings/sound/qcom,lpass-rx-macro.yaml#n72
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/tree/Documentation/devicetree/bindings/sound/qcom,lpass-tx-macro.yaml#n77
I don't understand what is has to do with commit msg. Please
explain/describe in the commit msg the hardware, not point to external
references. No one is going to look to other files to understand why
this commit is like that. This commit must stand on its own.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-03 11:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-25 8:29 [PATCH v5 0/9] Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards Prasad Kumpatla
2025-06-25 8:29 ` [PATCH v5 1/9] arm64: dts: qcom: qcs6490-audioreach: Add gpr node Prasad Kumpatla
2025-06-25 8:29 ` [PATCH v5 2/9] dt-bindings: pinctrl: qcom,sc7280-lpass-lpi-pinctrl: Document the clock property Prasad Kumpatla
2025-06-25 8:46 ` Krzysztof Kozlowski
2025-07-03 11:12 ` Prasad Kumpatla
2025-06-25 8:29 ` [PATCH v5 3/9] ASoC: qcom: dt-bindings: qcom,lpass-va-macro: Update bindings for clocks to support ADSP Prasad Kumpatla
2025-06-25 8:44 ` Krzysztof Kozlowski
2025-07-03 11:18 ` Prasad Kumpatla
2025-07-03 11:35 ` Krzysztof Kozlowski [this message]
2025-06-25 8:44 ` Krzysztof Kozlowski
2025-06-25 8:29 ` [PATCH v5 4/9] arm64: dts: qcom: sc7280: Add WSA SoundWire and LPASS support Prasad Kumpatla
2025-06-25 8:29 ` [PATCH v5 5/9] arm64: dts: qcom: qcs6490-audioreach: Modify LPASS macros clock settings for audioreach Prasad Kumpatla
2025-06-25 8:29 ` [PATCH v5 6/9] arm64: dts: qcom: qcs6490-rb3gen2: Add WSA8830 speakers amplifier Prasad Kumpatla
2025-07-03 12:14 ` Konrad Dybcio
2025-06-25 8:29 ` [PATCH v5 7/9] arm64: dts: qcom: qcs6490-rb3gen2: Add sound card Prasad Kumpatla
2025-06-25 8:29 ` [PATCH v5 8/9] arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec Prasad Kumpatla
2025-06-25 8:29 ` [PATCH v5 9/9] arm64: dts: qcom: qcm6490-idp: Add sound card Prasad Kumpatla
2025-07-03 12:16 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdc33ace-0979-426e-a1db-b90c8310e8af@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=quic_mohs@quicinc.com \
--cc=quic_pkumpatl@quicinc.com \
--cc=robh@kernel.org \
--cc=srini@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).