From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan O'Donovan Subject: Re: [PATCH v2 1/3] mfd: upboard: Add UP2 platform controller driver Date: Wed, 31 Oct 2018 20:40:45 +0000 Message-ID: References: <20180421085009.28773-1-javier@emutex.com> <1539969334-24577-1-git-send-email-dan@emutex.com> <1539969334-24577-2-git-send-email-dan@emutex.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: Content-Language: en-US Content-ID: Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko , Dan O'Donovan Cc: Linux Kernel Mailing List , Andy Shevchenko , Mika Westerberg , "Krogerus, Heikki" , Lee Jones , Linus Walleij , Jacek Anaszewski , Pavel Machek , "open list:GPIO SUBSYSTEM" , Linux LED Subsystem , Carlos Iglesias List-Id: linux-gpio@vger.kernel.org DQpPbiAxMC8yMC8yMDE4IDEyOjQ5IFBNLCBBbmR5IFNoZXZjaGVua28gd3JvdGU6DQo+IE9uIEZy aSwgT2N0IDE5LCAyMDE4IGF0IDg6MjYgUE0gRGFuIE8nRG9ub3ZhbiA8ZGFuQGVtdXRleC5jb20+ IHdyb3RlOg0KPj4gRnJvbTogSmF2aWVyIEFydGVhZ2EgPGphdmllckBlbXV0ZXguY29tPg0KPj4N Cj4+IFVQIFNxdWFyZWQgKFVQMikgaXMgYSB4ODYgU0JDIGZyb20gQUFFT04gYmFzZWQgb24gSW50 ZWwgQXBvbGxvIExha2UuIEl0DQo+PiBmZWF0dXJlcyBhIE1BWCAxMCBGUEdBIHRoYXQgcm91dGVz IGxpbmVzIGZyb20gYm90aCBTb0MgYW5kIG9uLWJvYXJkDQo+PiBkZXZpY2VzIHRvIHR3byBJL08g aGVhZGVyczoNCj4+DQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICstLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0rDQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwg NDAtcGluIFJQaS1saWtlIGhlYWRlciB8DQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgKy0t LS0tLXwgICAgICAgICAoSEFUKSAgICAgICAgICB8DQo+PiAgICAgICAgICAgICAgICAgICAgICAg ICAgfCAgICAgICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0rDQo+PiAgICAgKy0tLS0tLS0rICAg ICstLS0tLS0tLSsNCj4+ICAgICB8ICAgICAgIHwgICAgfCAgICAgICAgfCAgICAgKy0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLSsNCj4+ICAgICB8ICBTb0MgIHwtLS0tfCAgRlBHQSAgfC0tLS0tfCAg Q3VzdG9tIFVQMiBwaW4gaGVhZGVyIHwNCj4+ICAgICB8ICAgICAgIHwgICAgfCAgICAgICAgfCAg ICAgfCAgICAgICAgKEVYSEFUKSAgICAgICAgIHwNCj4+ICAgICArLS0tLS0tLSsgICAgKy0tLS0t LS0tKyAgICAgKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLSsNCj4+ICAgICAgICAgICAgICAgICAg ICAgICAgICB8DQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgKy0tLS0tLSogT24tYm9hcmQg ZGV2aWNlczogTEVELCBWTFMuLi4NCj4+DQo+PiBUaGlzIGlzIGludGVuZGVkIHRvIGVuYWJsZSB2 ZW5kb3Itc3BlY2lmaWMgYXBwbGljYXRpb25zIHRvIGN1c3RvbWl6ZSBJL08NCj4+IGhlYWRlciBw aW5vdXQsIGFzIHdlbGwgYXMgaW5jbHVkZSBsb3ctbGF0ZW5jeSBmdW5jdGlvbmFsaXR5LiBJdCBh bHNvDQo+PiBwZXJmb3JtcyB2b2x0YWdlIGxldmVsIHRyYW5zbGF0aW9uIGJldHdlZW4gdGhlIFNv QyAoMS44VikgYW5kIEhBVCBoZWFkZXINCj4+ICgzLjNWKS4NCj4+DQo+PiBPdXQgb2YgdGhlIGJv eCwgdGhpcyBibG9jayBpbXBsZW1lbnRzIGEgcGxhdGZvcm0gY29udHJvbGxlciB3aXRoIGENCj4+ IEdQSU8tYml0YmFuZ2VkIGNvbnRyb2wgaW50ZXJmYWNlLiBJdCdzIGVudW1lcmF0ZWQgYnkgQUNQ SSBhbmQgcHJvdmlkZXMNCj4+IHJlZ2lzdGVycyB0byBjb250cm9sOg0KPj4NCj4+IC0gQ29uZmln dXJhdGlvbiBvZiBhbGwgRlBHQS1yb3V0ZWQgaGVhZGVyIGxpbmVzLiBUaGVzZSBjYW4gYmUgZHJp dmVuDQo+PiAgIFNvQy10by1oZWFkZXIsIGhlYWRlci10by1Tb0Mgb3Igc2V0IGluIGhpZ2ggaW1w ZWRhbmNlLg0KPj4NCj4+IC0gT24tYm9hcmQgTEVEcyBhbmQgZW5hYmxlIGxpbmVzIGZvciBvdGhl ciBwbGF0Zm9ybSBkZXZpY2VzLg0KPj4NCj4+IEFkZCBjb3JlIHN1cHBvcnQgZm9yIHRoaXMgcGxh dGZvcm0gY29udHJvbGxlciBhcyBhIE1GRCBkZXZpY2UsIGV4cG9zaW5nDQo+PiB0aGVzZSByZWdp c3RlcnMgYXMgYSByZWdtYXAuDQo+IENhbiB3ZSBzZWUgYSBsaW5rIHRvIG9yIGFuIGV4Y2VycHQg b2YgQUNQSSB0YWJsZSBmb3IgdGhpcyBkZXZpY2U/DQpTdXJlOiBodHRwczovL2dpc3QuZ2l0aHVi LmNvbS9EYW4tRW11dGV4LzYzODJjMjVmNGI4YjhjZGQ4MGU2MDU2ODg5Y2RmNDhiDQpJJ2xsIGFk ZCB0aGlzIHRvIHRoZSBjb3ZlciBsZXR0ZXIgZm9yIHYzIGFzIHdlbGwuDQoNCj4NCj4+ICsjZGVm aW5lIHNldF9jbGVhcih1LCB4KSBncGlvZF9zZXRfdmFsdWUoKHUpLT5jbGVhcl9ncGlvLCAoeCkp DQo+PiArI2RlZmluZSBzZXRfc3Ryb2JlKHUsIHgpIGdwaW9kX3NldF92YWx1ZSgodSktPnN0cm9i ZV9ncGlvLCAoeCkpDQo+PiArI2RlZmluZSBzZXRfZGF0YWluKHUsIHgpIGdwaW9kX3NldF92YWx1 ZSgodSktPmRhdGFpbl9ncGlvLCAoeCkpDQo+PiArI2RlZmluZSBnZXRfZGF0YW91dCh1KSBncGlv ZF9nZXRfdmFsdWUoKHUpLT5kYXRhb3V0X2dwaW8pDQo+IEkgdGhpbmsgdGhlc2UgbWFjcm9zIGRv bid0IGJyaW5nIG11Y2ggdmFsdWUuIChVcCB0byB5b3UgYW5kIExlZSB0byBkZWNpZGUpDQpUaGVz ZSB3ZXJlIGFkZGVkIGluIHJlc3BvbnNlIHRvIG9uZSBvZiB5b3VyIHJldmlldyBjb21tZW50cyBv biB0aGUgb3JpZ2luYWwgcGF0Y2gtc2V0IDspDQpJIHRoaW5rIHRoZXkgZG8gc2xpZ2h0bHkgaW1w cm92ZSB0aGUgY29kZSByZWFkYWJpbGl0eSBzbyBJJ2xsIGxlYXZlIHRoZW0gdGhlcmUgaWYgdGhl cmUgYXJlIG5vIG9iamVjdGlvbnMuDQoNCj4NCj4NCj4+ICtzdGF0aWMgdm9pZCBfX3JlZ19pb193 cml0ZShjb25zdCBzdHJ1Y3QgdXBib2FyZF9kZGF0YSAqIGNvbnN0IGRkYXRhLA0KPj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgdW5zaWduZWQgaW50IHNpemUsIHVuc2lnbmVkIGludCB2YWwp DQo+PiArew0KPj4gKyAgICAgICBpbnQgaTsNCj4+ICsNCj4+ICsgICAgICAgLyoNCj4+ICsgICAg ICAgICogREFUQUlOIGlzIGxhdGNoZWQgb24gZWFjaCByaXNpbmcgZWRnZSBvZiB0aGUgU1RST0JF IHNpZ25hbC4NCj4+ICsgICAgICAgICogRGF0YSAocmVnaXN0ZXIgYWRkcmVzcyBvciB2YWx1ZSkg aXMgc2VudCBNU2IgZmlyc3QuDQo+PiArICAgICAgICAqLw0KPj4gKyAgICAgICBmb3IgKGkgPSBz aXplIC0gMTsgaSA+PSAwOyBpLS0pIHsNCj4gd2hpbGUgKHNpemUtLSkNClllcCwgbXVjaCBuZWF0 ZXIuwqAgSSdsbCBjaGFuZ2UgdGhhdCwgdGhhbmtzIcKgIERpdHRvIGZvciB0aGUgb3RoZXIgY29t bWVudHMgb24gdGhpcyBmaWxlLisgcmV0ID0gdXBib2FyZF9pbml0X2dwaW8oZGV2KTsNCg0KPj4g KyAgICAgICBpZiAocmV0KSB7DQo+PiArICAgICAgICAgICAgICAgaWYgKHJldCAhPSAtRVBST0JF X0RFRkVSKQ0KPj4gKyAgICAgICAgICAgICAgICAgICAgICAgZGV2X2VycihkZXYsICJmYWlsZWQg dG8gaW5pdCBHUElPczogJWQiLCByZXQpOw0KPj4gKyAgICAgICAgICAgICAgIHJldHVybiByZXQ7 DQo+PiArICAgICAgIH0NCj4gSSBkb24ndCBrbm93IGlmIHByb2JlX2VycigpIGhlbHBlciBpcyBn b2luZyB0byBiZSBhIHBhcnQgb2YgdjQuMjENCj4gKHdoaWNoIHRoaXMgc2VyaWVzIHRhcmdldHMp LCBpdCB3b3VsZCBiZSBnb29kIHRvIHVzZSBpdC4NCkkgbGVmdCB0aGlzIG91dCBmb3Igbm93IGlu IGNhc2UgaXQgY2F1c2VzIGFueSBhd2t3YXJkbmVzcyB3aXRoIG1lcmdpbmcuwqAgSG9wZSB0aGF0 J3Mgb2suDQoNCg==