From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: contact@alex-min.fr, Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Guru Das Srinagesh <linux@gurudas.dev>,
Linus Walleij <linusw@kernel.org>,
Rob Clark <robin.clark@oss.qualcomm.com>,
Joerg Roedel <joro@8bytes.org>, Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>, Kees Cook <kees@kernel.org>,
Tony Luck <tony.luck@intel.com>,
"Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
iommu@lists.linux.dev
Subject: Re: [PATCH 8/8] ARM: dts: qcom: Add Samsung Galaxy S4
Date: Thu, 23 Apr 2026 13:36:33 +0200 [thread overview]
Message-ID: <ce26e0f7-a07f-4e17-a790-fd4f230c7e90@oss.qualcomm.com> (raw)
In-Reply-To: <20260421-mainline-send-v1-sending-v1-8-bcb0857724de@alex-min.fr>
On 4/21/26 11:45 AM, Alexandre MINETTE via B4 Relay wrote:
> From: Alexandre MINETTE <contact@alex-min.fr>
>
> Add a device tree for the Samsung Galaxy S4, codenamed jflte.
>
> This has been tested on a Samsung Galaxy S4 GT-I9505. The initial support
> covers UART, USB peripheral mode with USB networking, the front LED and
> the physical buttons.
>
> Signed-off-by: Alexandre MINETTE <contact@alex-min.fr>
> ---
[...]
> + i2c-muic {
> + compatible = "i2c-gpio";
> + sda-gpios = <&tlmm_pinmux 22 GPIO_ACTIVE_HIGH>;
> + scl-gpios = <&tlmm_pinmux 23 GPIO_ACTIVE_HIGH>;
Is this not GSBI2?
[...]
> + i2c-led {
> + compatible = "i2c-gpio";
> + sda-gpios = <&tlmm_pinmux 6 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
> + scl-gpios = <&tlmm_pinmux 7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
Likewise, GSBI3
[...]
> +&riva {
> + pinctrl-names = "default";
> + pinctrl-0 = <&riva_wlan_pin_a>, <&riva_bt_pin_a>, <&riva_fm_pin_a>;
pinctrl-n
pinctrl-names
in this order please, file-wide
[...]
> +&usb1 {
> + dr_mode = "otg";
> + extcon = <&muic>, <&usb_id>;
> + status = "okay";
Nit: please keep a \n before status
looks fairly good otherwise
Konrad
prev parent reply other threads:[~2026-04-23 11:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 9:45 [PATCH 0/8] Add Samsung Galaxy S4 support Alexandre MINETTE via B4 Relay
2026-04-21 9:45 ` [PATCH 1/8] dt-bindings: arm: qcom: Add Samsung Galaxy S4 Alexandre MINETTE via B4 Relay
2026-04-22 9:09 ` Krzysztof Kozlowski
2026-04-21 9:45 ` [PATCH 2/8] dt-bindings: extcon: qcom,pm8941-misc: Add PM8921 compatible Alexandre MINETTE via B4 Relay
2026-04-21 10:03 ` Konrad Dybcio
2026-04-22 1:43 ` Dmitry Baryshkov
2026-04-21 9:45 ` [PATCH 3/8] pinctrl: qcom: Register functions before enabling pinctrl Alexandre MINETTE via B4 Relay
2026-04-22 1:45 ` Dmitry Baryshkov
2026-04-21 9:45 ` [PATCH 4/8] iommu/msm: Look up masters per IOMMU instance Alexandre MINETTE via B4 Relay
2026-04-22 0:59 ` Dmitry Baryshkov
2026-04-21 9:45 ` [PATCH 5/8] extcon: qcom-spmi-misc: Add PM8921 compatible Alexandre MINETTE via B4 Relay
2026-04-22 1:45 ` Dmitry Baryshkov
2026-04-21 9:45 ` [PATCH 6/8] ARM: dts: qcom: apq8064: Fix USB controller clocks Alexandre MINETTE via B4 Relay
2026-04-21 12:52 ` Konrad Dybcio
2026-04-22 0:58 ` Dmitry Baryshkov
2026-04-21 9:45 ` [PATCH 7/8] ARM: dts: qcom: pm8921: Add USB ID extcon Alexandre MINETTE via B4 Relay
2026-04-22 1:49 ` Dmitry Baryshkov
2026-04-21 9:45 ` [PATCH 8/8] ARM: dts: qcom: Add Samsung Galaxy S4 Alexandre MINETTE via B4 Relay
2026-04-22 1:52 ` Dmitry Baryshkov
2026-04-23 11:36 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce26e0f7-a07f-4e17-a790-fd4f230c7e90@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=contact@alex-min.fr \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=gpiccoli@igalia.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kees@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@gurudas.dev \
--cc=myungjoo.ham@samsung.com \
--cc=robh@kernel.org \
--cc=robin.clark@oss.qualcomm.com \
--cc=robin.murphy@arm.com \
--cc=tony.luck@intel.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox