From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 103BBC388F7 for ; Mon, 9 Nov 2020 13:50:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B8A55206E3 for ; Mon, 9 Nov 2020 13:50:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AfD32ZcT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730142AbgKINuJ (ORCPT ); Mon, 9 Nov 2020 08:50:09 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:27258 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727826AbgKINuI (ORCPT ); Mon, 9 Nov 2020 08:50:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1604929806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PLsp/KuWTDbrVBv5ybtaH5oT3koUPcBqYT/mOxOLceQ=; b=AfD32ZcTAV7vsq0RkMi7YRaz+YNyxtU2BtuKTh8FlyK01szEIQS7pSt3HK+TOkowK5JMfB +6pxFNAk8SIMIpQphSiTmdzAjvwLiszYgjJlkX08Ahi6FVaLqwskB2xFqE2Q+Rd6SPGAL/ HRQJ5T14vRTOTCD+v0a8FoEbsrs5H4s= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-229-spy5dL5yMRS6ye8e4Unbrw-1; Mon, 09 Nov 2020 08:50:04 -0500 X-MC-Unique: spy5dL5yMRS6ye8e4Unbrw-1 Received: by mail-ej1-f72.google.com with SMTP id t1so3429704ejb.21 for ; Mon, 09 Nov 2020 05:50:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PLsp/KuWTDbrVBv5ybtaH5oT3koUPcBqYT/mOxOLceQ=; b=GAS9cIs75waR6ugTY4yAuCuLK/yIm2QR+uSu8eDs4Zx+nzvKgXnp5exuIryOq4A9+6 EB8Fy/Q040uAtZHFM+VGVAgi/UMJKZH5A3NGxudTMmR4j7z5InrJD5FPBOAjfEYRdlwy O4wh4sfnwclZktFWTsLKTOrInf+XL2m3n1a8cJTwzhjvu7Y1hs2OSxU36i5JbKeaqWPK WYRpqHOvcmFrPWXnF9+DHRt9RJX/tv0LMdN88foY+htLZkWM1l+3WSYdjetW4QIjHpF1 +JncAF9Pe46WICQToROYEpYIpsOTU510p7jcnQAbrpVnUv91vfzDZiuARqsLJrxDVWO/ jnmQ== X-Gm-Message-State: AOAM533QU91edDOpZnBzcpv+hna1Tm8lMEtT5Dto/76HJovwRDfJ/zQQ 0mtJNmO3pZaVBYZX1WtM3oqpKuzs/kNhYAffuvyyx1VVfiAqTX1pvAWIHjoZgEc+X06SJEmpxgs toXqgKSpppyqJl9QZwOk+0w== X-Received: by 2002:a17:906:f98e:: with SMTP id li14mr15753281ejb.75.1604929802355; Mon, 09 Nov 2020 05:50:02 -0800 (PST) X-Google-Smtp-Source: ABdhPJyG5clFDtGgr1oPP2mVomKl27liMRXknZE3eR/J1H9KeINk4KWFWJqQ2n3Bapo3TKqzD5Axdw== X-Received: by 2002:a17:906:f98e:: with SMTP id li14mr15753268ejb.75.1604929802203; Mon, 09 Nov 2020 05:50:02 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c0c-fe00-6c10-fbf3-14c4-884c.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:6c10:fbf3:14c4:884c]) by smtp.gmail.com with ESMTPSA id k23sm8760275ejs.100.2020.11.09.05.50.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Nov 2020 05:50:01 -0800 (PST) Subject: Re: [PATCH v3 1/4] pinctrl: amd: fix incorrect way to disable debounce filter To: Coiby Xu , Linus Walleij Cc: Andy Shevchenko , linux-gpio@vger.kernel.org, open list References: <20201105231912.69527-1-coiby.xu@gmail.com> <20201105231912.69527-2-coiby.xu@gmail.com> From: Hans de Goede Message-ID: Date: Mon, 9 Nov 2020 14:50:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1 MIME-Version: 1.0 In-Reply-To: <20201105231912.69527-2-coiby.xu@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi, On 11/6/20 12:19 AM, Coiby Xu wrote: > The correct way to disable debounce filter is to clear bit 5 and 6 > of the register. > > Cc: Hans de Goede > Link: https://lore.kernel.org/linux-gpio/df2c008b-e7b5-4fdd-42ea-4d1c62b52139@redhat.com/ > Signed-off-by: Coiby Xu Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/pinctrl/pinctrl-amd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c > index 9a760f5cd7ed..d6b2b4bd337c 100644 > --- a/drivers/pinctrl/pinctrl-amd.c > +++ b/drivers/pinctrl/pinctrl-amd.c > @@ -166,14 +166,14 @@ static int amd_gpio_set_debounce(struct gpio_chip *gc, unsigned offset, > pin_reg |= BIT(DB_TMR_OUT_UNIT_OFF); > pin_reg |= BIT(DB_TMR_LARGE_OFF); > } else { > - pin_reg &= ~DB_CNTRl_MASK; > + pin_reg &= ~(DB_CNTRl_MASK << DB_CNTRL_OFF); > ret = -EINVAL; > } > } else { > pin_reg &= ~BIT(DB_TMR_OUT_UNIT_OFF); > pin_reg &= ~BIT(DB_TMR_LARGE_OFF); > pin_reg &= ~DB_TMR_OUT_MASK; > - pin_reg &= ~DB_CNTRl_MASK; > + pin_reg &= ~(DB_CNTRl_MASK << DB_CNTRL_OFF); > } > writel(pin_reg, gpio_dev->base + offset * 4); > raw_spin_unlock_irqrestore(&gpio_dev->lock, flags); >