* [PATCH] gpio: mxc: use devm_platform_ioremap_resource() to simplify code
@ 2019-04-01 5:09 Anson Huang
2019-04-01 8:08 ` Bartosz Golaszewski
2019-04-01 8:11 ` Mukesh Ojha
0 siblings, 2 replies; 3+ messages in thread
From: Anson Huang @ 2019-04-01 5:09 UTC (permalink / raw)
To: linus.walleij@linaro.org, bgolaszewski@baylibre.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dl-linux-imx
Use the new helper devm_platform_ioremap_resource() which wraps the
platform_get_resource() and devm_ioremap_resource() together, to
simplify the code.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
drivers/gpio/gpio-mxc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
index e86e61d..b281358 100644
--- a/drivers/gpio/gpio-mxc.c
+++ b/drivers/gpio/gpio-mxc.c
@@ -411,7 +411,6 @@ static int mxc_gpio_probe(struct platform_device *pdev)
{
struct device_node *np = pdev->dev.of_node;
struct mxc_gpio_port *port;
- struct resource *iores;
int irq_base;
int err;
@@ -423,8 +422,7 @@ static int mxc_gpio_probe(struct platform_device *pdev)
port->dev = &pdev->dev;
- iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- port->base = devm_ioremap_resource(&pdev->dev, iores);
+ port->base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(port->base))
return PTR_ERR(port->base);
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: mxc: use devm_platform_ioremap_resource() to simplify code
2019-04-01 5:09 [PATCH] gpio: mxc: use devm_platform_ioremap_resource() to simplify code Anson Huang
@ 2019-04-01 8:08 ` Bartosz Golaszewski
2019-04-01 8:11 ` Mukesh Ojha
1 sibling, 0 replies; 3+ messages in thread
From: Bartosz Golaszewski @ 2019-04-01 8:08 UTC (permalink / raw)
To: Anson Huang
Cc: linus.walleij@linaro.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org, dl-linux-imx
pon., 1 kwi 2019 o 07:09 Anson Huang <anson.huang@nxp.com> napisał(a):
>
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> drivers/gpio/gpio-mxc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index e86e61d..b281358 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -411,7 +411,6 @@ static int mxc_gpio_probe(struct platform_device *pdev)
> {
> struct device_node *np = pdev->dev.of_node;
> struct mxc_gpio_port *port;
> - struct resource *iores;
> int irq_base;
> int err;
>
> @@ -423,8 +422,7 @@ static int mxc_gpio_probe(struct platform_device *pdev)
>
> port->dev = &pdev->dev;
>
> - iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - port->base = devm_ioremap_resource(&pdev->dev, iores);
> + port->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(port->base))
> return PTR_ERR(port->base);
>
> --
> 2.7.4
>
Patch is trivial, so applied right away. Thanks!
Bart
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: mxc: use devm_platform_ioremap_resource() to simplify code
2019-04-01 5:09 [PATCH] gpio: mxc: use devm_platform_ioremap_resource() to simplify code Anson Huang
2019-04-01 8:08 ` Bartosz Golaszewski
@ 2019-04-01 8:11 ` Mukesh Ojha
1 sibling, 0 replies; 3+ messages in thread
From: Mukesh Ojha @ 2019-04-01 8:11 UTC (permalink / raw)
To: Anson Huang, linus.walleij@linaro.org, bgolaszewski@baylibre.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: dl-linux-imx
On 4/1/2019 10:39 AM, Anson Huang wrote:
> Use the new helper devm_platform_ioremap_resource() which wraps the
> platform_get_resource() and devm_ioremap_resource() together, to
> simplify the code.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> drivers/gpio/gpio-mxc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c
> index e86e61d..b281358 100644
> --- a/drivers/gpio/gpio-mxc.c
> +++ b/drivers/gpio/gpio-mxc.c
> @@ -411,7 +411,6 @@ static int mxc_gpio_probe(struct platform_device *pdev)
> {
> struct device_node *np = pdev->dev.of_node;
> struct mxc_gpio_port *port;
> - struct resource *iores;
> int irq_base;
> int err;
>
> @@ -423,8 +422,7 @@ static int mxc_gpio_probe(struct platform_device *pdev)
>
> port->dev = &pdev->dev;
>
> - iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - port->base = devm_ioremap_resource(&pdev->dev, iores);
> + port->base = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(port->base))
> return PTR_ERR(port->base);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-04-01 8:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-04-01 5:09 [PATCH] gpio: mxc: use devm_platform_ioremap_resource() to simplify code Anson Huang
2019-04-01 8:08 ` Bartosz Golaszewski
2019-04-01 8:11 ` Mukesh Ojha
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).