linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
	Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH v2 0/2] pinctrl: renesas: Add r8a77995 bias pinconf support
Date: Wed, 30 Jun 2021 16:50:41 +0200	[thread overview]
Message-ID: <cover.1625064076.git.geert+renesas@glider.be> (raw)

	Hi all,

This patch series adds a small optimization to R-Car pin bias handling,
and adds bias pinconf support for the R-Car D3 SoC.

Changes compared to v1[1]:
  - Drop all accepted patches,
  - Add [PATCH v2 1/2],
  - Add Reviewed-by,
  - Fix NFRE# and NFWE# handling, now we received confirmation that the
    documentation is correct.

The first patch has been tested on Koelsch and Salvator-XS.
The second patch has been tested on a remote Draak development board by
specifying one of the "bias-{pull-{down,enable},disable}" properties for
the "GP_3_0" and "GP_3_1" pins from DT, and inspecting the impact on the
PUEN2 and PUD2 registers.  Due to the remote setup, actual voltage
levels could not be measured.  Note that enabling pull-down for "GP_3_0"
breaks eMMC operation, as this pin is used as the eMMC's "CMD" signal.

I plan to queue this in renesas-pinctrl for v5.15.

Thanks for your comments!

[1] [PATCH 00/12] pinctrl: renesas: Add more bias pinconf support
    https://lore.kernel.org/linux-renesas-soc/cover.1619785375.git.geert+renesas@glider.be/

Geert Uytterhoeven (2):
  pinctrl: renesas: rcar: Avoid changing PUDn when disabling bias
  pinctrl: renesas: r8a77995: Add bias pinconf support

 drivers/pinctrl/renesas/pfc-r8a77995.c | 320 ++++++++++++++++++++++++-
 drivers/pinctrl/renesas/pinctrl.c      |  16 +-
 drivers/pinctrl/renesas/sh_pfc.h       |   3 +
 3 files changed, 323 insertions(+), 16 deletions(-)

-- 
2.25.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

             reply	other threads:[~2021-06-30 14:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-30 14:50 Geert Uytterhoeven [this message]
2021-06-30 14:50 ` [PATCH v2 1/2] pinctrl: renesas: rcar: Avoid changing PUDn when disabling bias Geert Uytterhoeven
2021-06-30 21:42   ` Niklas Söderlund
2021-06-30 14:50 ` [PATCH v2 2/2] pinctrl: renesas: r8a77995: Add bias pinconf support Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1625064076.git.geert+renesas@glider.be \
    --to=geert+renesas@glider.be \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).