Re: [PATCH 1/5] media: i2c: ov5675: Wait for endpoint

[Hans de Goede <hansg@kernel.org>]

Hi,

On 10-Mar-26 14:08, Sakari Ailus wrote:
> Hi Hans,
> 
> On Tue, Mar 10, 2026 at 02:03:30PM +0100, Hans de Goede wrote:
>> Hi,
>>
>> Thank you for your patches for this, cool to see someone working
>> on supporting this!
>>
>> On 10-Mar-26 13:44, Antti Laakso wrote:
>>> Defer probe if endpoint is not yet available. And do it before acquiring
>>> clock, gpio and regulators.
>>>
>>> Signed-off-by: Antti Laakso <antti.laakso@linux.intel.com>
>>> ---
>>>  drivers/media/i2c/ov5675.c | 16 +++++++---------
>>>  1 file changed, 7 insertions(+), 9 deletions(-)
>>>
>>> diff --git a/drivers/media/i2c/ov5675.c b/drivers/media/i2c/ov5675.c
>>> index ea26df328189..81916fa8c117 100644
>>> --- a/drivers/media/i2c/ov5675.c
>>> +++ b/drivers/media/i2c/ov5675.c
>>> @@ -1181,6 +1181,13 @@ static int ov5675_get_hwcfg(struct ov5675 *ov5675)
>>>  	if (!fwnode)
>>>  		return -ENXIO;
>>>  
>>> +	ep = fwnode_graph_get_endpoint_by_id(fwnode, 0, 0,
>>> +					     FWNODE_GRAPH_ENDPOINT_NEXT);
>>> +	ret = v4l2_fwnode_endpoint_alloc_parse(ep, &bus_cfg);
>>> +	fwnode_handle_put(ep);
>>> +	if (ret)
>>> +		return ret;
>>
>> This should be:
>>
>> 		return dev_err_probe(dev, ret, "failed to parse endpoint\n");
> 
> I'd keep it as-is; see
> <URL:https://lore.kernel.org/linux-media/20260310080038.1182695-1-sakari.ailus@linux.intel.com/T/#u>.
> V4l2-fwnode also prints errors (albeit on debug level) on failures.

Ok, keeping this as is is fine with me.

There still is the issue of adding the goto-s to properly free
the bus_cfg on errors.

Regards,

Hans