From: Navya Malempati <navya.malempati@oss.qualcomm.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linusw@kernel.org>,
Bhupesh Sharma <bhupesh.sharma@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Maulik Shah <maulik.shah@oss.qualcomm.com>
Subject: Re: [PATCH] pinctrl: qcom: Fix wakeirq map by removing disconnected irqs for sm8150
Date: Fri, 24 Apr 2026 11:58:40 +0530 [thread overview]
Message-ID: <d20e8ced-9454-4924-9042-2f725de6d332@oss.qualcomm.com> (raw)
In-Reply-To: <gayeixwyvv4qjtpc6gz5ljrtpmb4ckm4up7gdxutpbatbxny74@kazqjbepwb46>
On 4/23/2026 6:09 PM, Dmitry Baryshkov wrote:
> On Thu, Apr 23, 2026 at 05:21:01PM +0530, Navya Malempati wrote:
>> From: Maulik Shah <maulik.shah@oss.qualcomm.com>
>>
>> PDC interrupts 122-125 were meant for ibi_i3c wakeup but sm8150 do not
>> support i3c. GPIOs 39,51,88 and 144 are also connected to different PDC
>> pin and already reflected in the wake irq map.
>>
>> Remove the unsupported wakeup interrupts from the map.
>>
>> Fixes: 90337380c809 ("pinctrl: qcom: sm8150: Specify PDC map")
>> Signed-off-by: Maulik Shah <maulik.shah@oss.qualcomm.com>
>> Signed-off-by: Navya Malempati <navya.malempati@oss.qualcomm.com>
>> ---
>> drivers/pinctrl/qcom/pinctrl-sm8150.c | 23 +++++++++++------------
>> 1 file changed, 11 insertions(+), 12 deletions(-)
>>
>> diff --git a/drivers/pinctrl/qcom/pinctrl-sm8150.c b/drivers/pinctrl/qcom/pinctrl-sm8150.c
>> index 0767261f5149..81c08b18ac71 100644
>> --- a/drivers/pinctrl/qcom/pinctrl-sm8150.c
>> +++ b/drivers/pinctrl/qcom/pinctrl-sm8150.c
>> @@ -1493,18 +1493,17 @@ static const struct msm_gpio_wakeirq_map sm8150_pdc_map[] = {
>> { 3, 31 }, { 5, 32 }, { 8, 33 }, { 9, 34 }, { 10, 100 },
>> { 12, 104 }, { 24, 37 }, { 26, 38 }, { 27, 41 }, { 28, 42 },
>> { 30, 39 }, { 36, 43 }, { 37, 44 }, { 38, 30 }, { 39, 118 },
>> - { 39, 125 }, { 41, 47 }, { 42, 48 }, { 46, 50 }, { 47, 49 },
>> - { 48, 51 }, { 49, 53 }, { 50, 52 }, { 51, 116 }, { 51, 123 },
>> - { 53, 54 }, { 54, 55 }, { 55, 56 }, { 56, 57 }, { 58, 58 },
>> - { 60, 60 }, { 61, 61 }, { 68, 62 }, { 70, 63 }, { 76, 71 },
>> - { 77, 66 }, { 81, 64 }, { 83, 65 }, { 86, 67 }, { 87, 84 },
>> - { 88, 117 }, { 88, 124 }, { 90, 69 }, { 91, 70 }, { 93, 75 },
>> - { 95, 72 }, { 96, 73 }, { 97, 74 }, { 101, 40 }, { 103, 77 },
>> - { 104, 78 }, { 108, 79 }, { 112, 80 }, { 113, 81 }, { 114, 82 },
>> - { 117, 85 }, { 118, 101 }, { 119, 87 }, { 120, 88 }, { 121, 89 },
>> - { 122, 90 }, { 123, 91 }, { 124, 92 }, { 125, 93 }, { 129, 94 },
>> - { 132, 105 }, { 133, 83 }, { 134, 36 }, { 136, 97 }, { 142, 103 },
>> - { 144, 115 }, { 144, 122 }, { 147, 102 }, { 150, 107 },
>> + { 41, 47 }, { 42, 48 }, { 46, 50 }, { 47, 49 }, { 48, 51 },
>> + { 49, 53 }, { 50, 52 }, { 51, 116 }, { 53, 54 }, { 54, 55 },
>> + { 55, 56 }, { 56, 57 }, { 58, 58 }, { 60, 60 }, { 61, 61 },
>> + { 68, 62 }, { 70, 63 }, { 76, 71 }, { 77, 66 }, { 81, 64 },
>> + { 83, 65 }, { 86, 67 }, { 87, 84 }, { 88, 117 }, { 90, 69 },
>> + { 91, 70 }, { 93, 75 }, { 95, 72 }, { 96, 73 }, { 97, 74 },
>> + { 101, 40 }, { 103, 77 }, { 104, 78 }, { 108, 79 }, { 112, 80 },
>> + { 113, 81 }, { 114, 82 }, { 117, 85 }, { 118, 101 }, { 119, 87 },
>> + { 120, 88 }, { 121, 89 }, { 122, 90 }, { 123, 91 }, { 124, 92 },
>> + { 125, 93 }, { 129, 94 }, { 132, 105 }, { 133, 83 }, { 134, 36 },
>> + { 136, 97 }, { 142, 103 }, { 144, 115 }, { 147, 102 }, { 150, 107 },
>
> Is there a chance of mimimising the diff here? It is harder to read than
> your v1.
>
This is v1.
True, it is little difficult to read since multiple lines have been
changed to re-adjust fitting of 5 entries in single line, otherwise it
may look non uniform across lines.
Thanks,
Navya
next prev parent reply other threads:[~2026-04-24 6:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 11:51 [PATCH] pinctrl: qcom: Fix wakeirq map by removing disconnected irqs for sm8150 Navya Malempati
2026-04-23 12:22 ` Konrad Dybcio
2026-04-23 12:39 ` Dmitry Baryshkov
2026-04-24 6:28 ` Navya Malempati [this message]
2026-04-24 8:11 ` Dmitry Baryshkov
2026-04-28 9:59 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d20e8ced-9454-4924-9042-2f725de6d332@oss.qualcomm.com \
--to=navya.malempati@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=bhupesh.sharma@linaro.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maulik.shah@oss.qualcomm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox