From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DB3F2405F1; Mon, 7 Apr 2025 13:09:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744031400; cv=none; b=Bn8j9CDdL6Ozr/bvGax3nA56vsryLR5HJS3xb8sCB6ji4Fcruq2YtemNbLEzlZvIo4rpi/NsxwPFFOGd/mKWOlSbBClfJonW3rWDUG9n0ZLUO6S3qXAzS1dhDwmdD90mYdCKVsAvNUAkdq9nnVgaTqaioo1yqHIxr99qwbRkILE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744031400; c=relaxed/simple; bh=lrEQ3fr+h9CURtK/FYz3Ba3eDcS304hMn4rCuayzuFA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OcJerPYhFEs770hojJH7pWEs+GQIe7GiqRNpvwIL3q9UwfBueSN6zR64AF6AKATgI9/eSGNsyLz0DOfzuXdVEBjpttEBBUIdKIdd6dqyM4C8Sp5OTjTPeAdLJzkORpkbQAdrX0aDjCAWD9E65qWXnLoRdUFKSD2RzQmnDU2Iz4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jeSF7Zo5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jeSF7Zo5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6F204C4CEDD; Mon, 7 Apr 2025 13:09:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744031399; bh=lrEQ3fr+h9CURtK/FYz3Ba3eDcS304hMn4rCuayzuFA=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=jeSF7Zo5CK4pyTsgDM4KiUW2HeZ6FYWOJfDP2WNoXJb5lZdDkjPW0q1P8Yh9Fiwfs EFMIgtQwk2zKQ6ASkYrDdm9lyVrEXOQv6LsgShVPS+Fw91cqdzSbesvFQoIKD+bjWV jqAk1vumbUn+lbxhc6lDaQGSgaDELXP3LHfCba0ga1kDn1XlBkH1VAAMH/sLuMRDvy qWXVzzVPmB8E5B89dih1K27xjsIA5uQf6T8DAJ6Rz0s7kn4IhEe2W87xI6QnBMzqmq Sy1Dcojs0vgzDBNEVt5nZwEXqPtHViFbr0s9OhqGsHEIAU5eagtT1GueEYpkTKR5T9 BeGA+vIR3k5iQ== Message-ID: Date: Mon, 7 Apr 2025 15:09:53 +0200 Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/11] ASoC: dt-bindings: mediatek,mt8196-afe: add audio AFE document To: "Darren.Ye" , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , AngeloGioacchino Del Regno , Jaroslav Kysela , Takashi Iwai , Linus Walleij , Bartosz Golaszewski Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org References: <20250407120708.26495-1-darren.ye@mediatek.com> <20250407120708.26495-10-darren.ye@mediatek.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20250407120708.26495-10-darren.ye@mediatek.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 07/04/2025 14:06, Darren.Ye wrote: > From: Darren Ye > > Add mt8196 audio AFE document. > > Signed-off-by: Darren Ye > --- > .../bindings/sound/mediatek,mt8196-afe.yaml | 233 ++++++++++++++++++ Bindings are before their users. Order your patches correctly (see DT submitting patches). > 1 file changed, 233 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/mediatek,mt8196-afe.yaml > > diff --git a/Documentation/devicetree/bindings/sound/mediatek,mt8196-afe.yaml b/Documentation/devicetree/bindings/sound/mediatek,mt8196-afe.yaml > new file mode 100644 > index 000000000000..44f8847b13a8 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/mediatek,mt8196-afe.yaml Filename matching compatible. > @@ -0,0 +1,233 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/mediatek,mt8196-afe.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: MediaTek Audio Front End PCM controller for MT8196 > + > +maintainers: > + - Darren Ye > + > +properties: > + compatible: > + const: mediatek,mt8196-afe-pcm > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 Blank line > + memory-region: > + maxItems: 1 > + description: | > + Shared memory region for AFE memif. A "shared-dma-pool". > + See dtschema reserved-memory/shared-dma-pool.yaml for details. Drop description Blank line > + mediatek,cksys: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of the mediatek clk systemd controller For what purpose? this should be answered here. Anyway you clocks for handling clocks of clk controller. > + > + mediatek,vlpcksys: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: The phandle of the mediatek vlpcksys controller Blank line. For what purpose? > + power-domains: > + maxItems: 1 > + > + clocks: > + items: > + - description: audio hopping clock gate > + - description: audio f26m clock gate > + - description: audio apll1 clock gate > + - description: audio apll2 clock gate > + - description: audio apll1 tuner gate > + - description: audio apll2 tuner gate > + - description: mux for audio vlp int > + - description: mux for audio vlp engen1 > + - description: mux for audio vlp engen2 > + - description: mux for audio h > + - description: vlp clock 26m > + - description: audio mainpll divide 4 > + - description: mux for audio apll1 > + - description: audio apll1 > + - description: mux for audio apll2 > + - description: audio apll2 > + - description: audio apll1 divide 4 > + - description: audio apll2 divide 4 > + - description: mux for i2sin0 mck > + - description: mux for i2sin1 mck > + - description: mux for fmi2s mck > + - description: mux for tdmout mck > + - description: auido apll12 divide for i2sin0 > + - description: auido apll12 divide for i2sin1 > + - description: auido apll12 divide for fmi2s > + - description: auido apll12 divide for tdmout mck > + - description: auido apll12 divide for tdmout bck > + - description: audio adsp clk > + - description: 26m clock Do not come with entirely different ordering than existing variants. > + > + clock-names: > + items: > + - const: aud_hopping_clk Look how this is called in upstream. > + - const: aud_f26m_clk > + - const: aud_apll1_clk > + - const: aud_apll2_clk > + - const: aud_apll_tuner1_clk > + - const: aud_apll_tuner2_clk > + - const: vlp_mux_audio_int > + - const: vlp_mux_aud_eng1 > + - const: vlp_mux_aud_eng2 > + - const: vlp_mux_audio_h > + - const: vlp_clk26m_clk > + - const: ck_mainpll_d4_d4 > + - const: ck_mux_aud_1 > + - const: ck_apll1_ck > + - const: ck_mux_aud_2 > + - const: ck_apll2_ck > + - const: ck_apll1_d4 > + - const: ck_apll2_d4 > + - const: ck_i2sin0_m_sel > + - const: ck_i2sin1_m_sel > + - const: ck_fmi2s_m_sel > + - const: ck_tdmout_m_sel > + - const: ck_apll12_div_i2sin0 > + - const: ck_apll12_div_i2sin1 > + - const: ck_apll12_div_fmi2s > + - const: ck_apll12_div_tdmout_m > + - const: ck_apll12_div_tdmout_b > + - const: ck_adsp_sel > + - const: ck_clk26m_clk The same. > + > + mediatek,etdm4-out-ch: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Number of ETDM4 output channels. > + minimum: 1 > + maximum: 8 > + > + mediatek,etdm4-in-ch: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + Number of ETDM4 input channels. > + minimum: 1 > + maximum: 8 Why is this binding so different than existing ones? I expect uniformity not rework of all properties every time you upstream new device. > + > + mediatek,etdm4-out-sync: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + ETDM4 output and input enable synchronization. > + enum: > + - 0 # Enable controlled by itself > + - 1 # Enable synchronization with ETDM4 input. > + > + mediatek,etdm4-in-sync: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: > + ETDM4 input and outpuot enable synchronization. > + enum: > + - 0 # Enable controlled by itself > + - 1 # Enable synchronization with ETDM4 output. > + > + > + Hm? But why? One blank line is enough. > + mediatek,etdm4-ip-mode: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: ETDM IP mode. > + enum: > + - 0 # One ip multi-ch mode > + - 1 # Multi-ip 2ch mode > + > +required: > + - compatible > + - reg > + - interrupts > + - mediatek,cksys > + - mediatek,vlpcksys > + - power-domains > + - memory-region > + - clocks > + - clock-names > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + afe: mt8196-afe-pcm@1a110000 { Look at other bindings. Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof