From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>,
linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com,
arnd@arndb.de, linux-gpio@vger.kernel.org,
linux-next@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH char-misc-next] misc: microchip: pci1xxxx: use DEFINE_SIMPLE_DEV_PM_OPS() in place of the SIMPLE_DEV_PM_OPS() in pci1xxxx's gpio driver
Date: Tue, 13 Sep 2022 20:44:40 +0700 [thread overview]
Message-ID: <d34d9264-1f0b-d465-bc1d-75f8c736a35b@gmail.com> (raw)
In-Reply-To: <20220912113634.167820-1-kumaravel.thiagarajan@microchip.com>
On 9/12/22 18:36, Kumaravel Thiagarajan wrote:
> build errors listed below and reported for the builds of
> riscv, s390, csky, alpha and loongarch allmodconfig are fixed in
> this patch.
>
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error: 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
> 311 | static int pci1xxxx_gpio_resume(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error: 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
> 295 | static int pci1xxxx_gpio_suspend(struct device *dev)
> | ^~~~~~~~~~~~~~~~~~~~~
>
What about this description?:
"Sudip reported unused function errors on riscv, s390, cksy, alpha,
and loongarch (allmodconfig):
<pci1xxxx_gpio_* errors>...
Fix these errors by using DEFINE_SIMPLE_DEV_PM_OPS."
> Fixes: 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.")
> Reported-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
> Signed-off-by: Kumaravel Thiagarajan <kumaravel.thiagarajan@microchip.com>
> ---
> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> index 9cc771c604ed..4cd541166b0c 100644
> --- a/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> +++ b/drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c
> @@ -405,7 +405,7 @@ static int pci1xxxx_gpio_probe(struct auxiliary_device *aux_dev,
> return devm_gpiochip_add_data(&aux_dev->dev, &priv->gpio, priv);
> }
>
> -static SIMPLE_DEV_PM_OPS(pci1xxxx_gpio_pm_ops, pci1xxxx_gpio_suspend, pci1xxxx_gpio_resume);
> +static DEFINE_SIMPLE_DEV_PM_OPS(pci1xxxx_gpio_pm_ops, pci1xxxx_gpio_suspend, pci1xxxx_gpio_resume);
>
> static const struct auxiliary_device_id pci1xxxx_gpio_auxiliary_id_table[] = {
> {.name = "mchp_pci1xxxx_gp.gp_gpio"},
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2022-09-13 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 11:36 [PATCH char-misc-next] misc: microchip: pci1xxxx: use DEFINE_SIMPLE_DEV_PM_OPS() in place of the SIMPLE_DEV_PM_OPS() in pci1xxxx's gpio driver Kumaravel Thiagarajan
2022-09-13 13:44 ` Bagas Sanjaya [this message]
2022-09-13 18:27 ` Kumaravel.Thiagarajan
2022-09-14 1:59 ` Bagas Sanjaya
2022-09-15 9:50 ` Kumaravel.Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d34d9264-1f0b-d465-bc1d-75f8c736a35b@gmail.com \
--to=bagasdotme@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kumaravel.thiagarajan@microchip.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).