From: Matti Vaittinen <mazziesaccount@gmail.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Linus Walleij <linus.walleij@linaro.org>,
Nuno Sa <nuno.sa@analog.com>,
David Lechner <dlechner@baylibre.com>,
Dumitru Ceclan <mitrutzceclan@gmail.com>,
Trevor Gamblin <tgamblin@baylibre.com>,
Matteo Martelli <matteomartelli3@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [RFC PATCH 2/5] mfd: Add ROHM BD79124 ADC/GPO
Date: Sat, 1 Feb 2025 18:04:20 +0200 [thread overview]
Message-ID: <d3c2d681-4f92-4e09-8c81-c050723c25e8@gmail.com> (raw)
In-Reply-To: <20250131171436.00002583@huawei.com>
On 31/01/2025 19:14, Jonathan Cameron wrote:
> On Fri, 31 Jan 2025 15:37:06 +0200
> Matti Vaittinen <mazziesaccount@gmail.com> wrote:
>
>> Add core driver for the ROHM BD79124 ADC / GPO.
>>
>> The core driver launches the sub-drivers for the pinmux/GPO and for the
>> IIO ADC. It also provides the regmap, and forwards the IRQ resource to
>> the ADC.
>>
>> Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
> As per response in cover letter. This is a common device combination and so
> far I don't think we ever bothered with an MFD. Lots of ADCs provide
> GPIO chips as well so I'd just squash it into the ADC driver.
You may be right with this. I still need to digest this a bit as I
explaned in the cover letter discussion :)
All of your inline comments were valid and I agree with them. Noticing
the single IC limitation was great!
I'll address all the findings if I keep the MFD approach.
Yours,
-- Matti
next prev parent reply other threads:[~2025-02-01 16:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-31 13:34 [RFC PATCH 0/5] Support ROHM BD79124 ADC/GPO Matti Vaittinen
2025-01-31 13:36 ` [RFC PATCH 1/5] dt-bindings: " Matti Vaittinen
2025-01-31 13:37 ` [RFC PATCH 2/5] mfd: Add " Matti Vaittinen
2025-01-31 17:14 ` Jonathan Cameron
2025-02-01 16:04 ` Matti Vaittinen [this message]
2025-02-05 13:40 ` Matti Vaittinen
2025-01-31 13:37 ` [RFC PATCH 3/5] iio: adc: Support ROHM BD79124 ADC Matti Vaittinen
2025-01-31 17:41 ` Jonathan Cameron
2025-02-01 15:38 ` Matti Vaittinen
2025-02-01 16:26 ` Jonathan Cameron
2025-02-05 13:58 ` Matti Vaittinen
2025-02-08 13:01 ` Jonathan Cameron
2025-01-31 13:38 ` [RFC PATCH 4/5] pinctrl: Support ROHM BD79124 pinmux / GPO Matti Vaittinen
2025-02-05 13:40 ` Matti Vaittinen
2025-02-06 9:39 ` Linus Walleij
2025-02-06 10:05 ` Matti Vaittinen
2025-02-06 10:09 ` Matti Vaittinen
2025-02-13 11:53 ` Linus Walleij
2025-02-13 12:10 ` Matti Vaittinen
2025-02-13 16:18 ` David Lechner
2025-01-31 13:38 ` [RFC PATCH 5/5] MAINTAINERS: Add ROHM BD79124 ADC/GPO Matti Vaittinen
2025-01-31 17:08 ` [RFC PATCH 0/5] Support " Jonathan Cameron
2025-02-01 15:00 ` Matti Vaittinen
2025-02-01 16:30 ` Jonathan Cameron
2025-02-01 17:12 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3c2d681-4f92-4e09-8c81-c050723c25e8@gmail.com \
--to=mazziesaccount@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matteomartelli3@gmail.com \
--cc=matti.vaittinen@fi.rohmeurope.com \
--cc=mitrutzceclan@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=tgamblin@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).