From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02E48C433F5 for ; Fri, 1 Oct 2021 20:08:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D917C61ACF for ; Fri, 1 Oct 2021 20:08:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354638AbhJAUJu (ORCPT ); Fri, 1 Oct 2021 16:09:50 -0400 Received: from sibelius.xs4all.nl ([83.163.83.176]:58852 "EHLO sibelius.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229656AbhJAUJu (ORCPT ); Fri, 1 Oct 2021 16:09:50 -0400 X-Greylist: delayed 398 seconds by postgrey-1.27 at vger.kernel.org; Fri, 01 Oct 2021 16:09:49 EDT Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id ffc3ff1d; Fri, 1 Oct 2021 22:01:23 +0200 (CEST) Date: Fri, 1 Oct 2021 22:01:23 +0200 (CEST) From: Mark Kettenis To: Joey Gouly Cc: linux-gpio@vger.kernel.org, linus.walleij@linaro.org, marcan@marcan.st, maz@kernel.org, alyssa.rosenzweig@collabora.com, sven@svenpeter.dev, devicetree@vger.kernel.org, robh+dt@kernel.org, kettenis@openbsd.org, nd@arm.com, joey.gouly@arm.com In-Reply-To: <20211001191209.29988-3-joey.gouly@arm.com> (message from Joey Gouly on Fri, 1 Oct 2021 20:12:08 +0100) Subject: Re: [PATCH v2 2/3] dt-bindings: pinctrl: Add apple,npins property to apple,pinctrl References: <20211001191209.29988-1-joey.gouly@arm.com> <20211001191209.29988-3-joey.gouly@arm.com> Message-ID: Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org > From: Joey Gouly > Date: Fri, 1 Oct 2021 20:12:08 +0100 > > This property is used to describe the total number of pins on this > particular pinctrl hardware block. > > Signed-off-by: Joey Gouly > --- > Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml | 4 ++++ > 1 file changed, 4 insertions(+) Adding does property doesn't break the U-Boot driver, so I'm ok with this. This should probably be a required property though. > diff --git a/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > index d50571affd1f..cdd8cb454e92 100644 > --- a/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > @@ -34,6 +34,9 @@ properties: > gpio-ranges: > maxItems: 1 > > + apple,npins: > + maxItems: 1 > + > interrupts: > description: One interrupt for each of the (up to 7) interrupt > groups supported by the controller sorted by interrupt group > @@ -86,6 +89,7 @@ examples: > gpio-controller; > #gpio-cells = <2>; > gpio-ranges = <&pinctrl 0 0 212>; > + apple,npins = <212>; > > interrupt-controller; > interrupt-parent = <&aic>; > -- > 2.17.1 > >