From: Hans de Goede <hdegoede@redhat.com>
To: Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Linus Walleij <linus.walleij@linaro.org>,
Alexandre Courbot <gnurou@gmail.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
joeyli <jlee@suse.com>, Takashi Iwai <tiwai@suse.de>
Subject: Re: [PATCH v6] platform/x86: Add driver for ACPI INT0002 Virtual GPIO device
Date: Thu, 8 Jun 2017 18:45:05 +0200 [thread overview]
Message-ID: <d41ff55b-e28f-85bf-d088-392e363fb41f@redhat.com> (raw)
In-Reply-To: <20170608154541.GH32509@fury>
Hi,
On 06/08/2017 05:45 PM, Darren Hart wrote:
> On Wed, Jun 07, 2017 at 05:53:38PM +0300, Andy Shevchenko wrote:
>> On Fri, Jun 2, 2017 at 6:15 PM, Hans de Goede <hdegoede@redhat.com> wrote:
>>> Some peripherals on Bay Trail and Cherry Trail platforms signal a
>>> Power Management Event (PME) to the Power Management Controller (PMC)
>>> to wakeup the system. When this happens software needs to explicitly
>>> clear the PME bus 0 status bit in the GPE0a_STS register to avoid an
>>> IRQ storm on IRQ 9.
>>>
>>> This is modelled in ACPI through the INT0002 ACPI device, which is
>>> called a "Virtual GPIO controller" in ACPI because it defines the
>>> event handler to call when the PME triggers through _AEI and _L02
>>> methods as would be done for a real GPIO interrupt in ACPI.
>>>
>>> This commit adds a driver which registers the Virtual GPIOs expected
>>> by the DSDT on these devices, letting gpiolib-acpi claim the
>>> virtual GPIO and install a GPIO-interrupt handler which call the _L02
>>> handler as it would for a real GPIO controller.
>>>
>>
>> Pushed to testing w/o Linus' tag (there is no one yet)
>
> Will you be taking this through fixes Andy? For a 4.12-rc* target per Hans'
> response to the cover letter?
Note that Rafael is planning to drop (revert) the commit which makes
it (extra) desirable for this driver to get into 4.12, so we should
perhaps reconsider that. I'm fine either way, but the primary reason
to push this as a fix for 4.12 is no longer valid AFAICT.
Regards,
Hans
next prev parent reply other threads:[~2017-06-08 16:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 15:15 [PATCH v6 0/1] platform/x86: Add driver for ACPI INT0002 Virtual GPIO Hans de Goede
2017-06-02 15:15 ` [PATCH v6] platform/x86: Add driver for ACPI INT0002 Virtual GPIO device Hans de Goede
2017-06-02 15:31 ` Andy Shevchenko
2017-06-07 14:53 ` Andy Shevchenko
2017-06-08 15:45 ` Darren Hart
2017-06-08 16:45 ` Hans de Goede [this message]
2017-06-08 17:15 ` Rafael J. Wysocki
2017-06-08 17:40 ` Andy Shevchenko
2017-06-09 0:30 ` Rafael J. Wysocki
2017-06-09 8:22 ` Andy Shevchenko
2017-06-09 9:05 ` Linus Walleij
2017-06-09 9:02 ` Linus Walleij
2017-06-09 9:18 ` Andy Shevchenko
2017-06-09 11:43 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d41ff55b-e28f-85bf-d088-392e363fb41f@redhat.com \
--to=hdegoede@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=dvhart@infradead.org \
--cc=gnurou@gmail.com \
--cc=jlee@suse.com \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).