From: Michael Walle <michael@walle.cc>
To: "Sahin, Okan" <Okan.Sahin@analog.com>
Cc: andy.shevchenko@gmail.com,
Linus Walleij <linus.walleij@linaro.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] gpio: ds4520: Add ADI DS4520 Regulator Support
Date: Wed, 26 Apr 2023 13:53:03 +0200 [thread overview]
Message-ID: <d4a6a640c373b6d939e147691efa596c@walle.cc> (raw)
In-Reply-To: <MN2PR03MB5168689A20C8D6C67F119BB7E7659@MN2PR03MB5168.namprd03.prod.outlook.com>
Hi,
> I think I understand what you are trying to say so far. I did not have
> too much
> experience related to gpio. I will set pull_up register in .set_config
> However, I did not understand where its parameters come from.
> set_config(struct gpio_chip *chip, unsigned int offset,
> unsigned long config)
> It might be trivial question, but Where does config come from?
Others have to answer that one as I don't have that much experience
either.
> At the end, I should rewrite the code using regmap_gpio, right? So if I
> rewrite
> code using regmap_gpio, how can I replace set_config(...)?
You'd have to add a .set_config to gpio_regmap_config and then in
gpio_regmap_register():
gpio->set_config = config->set_config;
I don't think it makes sense to have a default implementation in
gpio-regmap,
the variances between "simple" gpio controllers might be too broad.
-michael
next prev parent reply other threads:[~2023-04-26 11:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 13:00 [PATCH v1 0/2] Add DS4520 GPIO Expander Support Okan Sahin
2023-03-27 13:00 ` [PATCH v1 1/2] dt-bindings: gpio: ds4520: Add ADI DS4520 Okan Sahin
2023-03-27 15:37 ` Rob Herring
2023-03-27 19:05 ` Krzysztof Kozlowski
2023-03-27 13:00 ` [PATCH v1 2/2] gpio: ds4520: Add ADI DS4520 Regulator Support Okan Sahin
2023-03-31 9:41 ` Linus Walleij
2023-04-04 14:35 ` Sahin, Okan
2023-04-05 13:20 ` Linus Walleij
2023-04-05 13:57 ` Michael Walle
2023-04-07 13:48 ` Linus Walleij
2023-04-07 18:36 ` andy.shevchenko
2023-04-09 14:25 ` Sahin, Okan
2023-04-11 13:42 ` Michael Walle
2023-04-24 15:39 ` Sahin, Okan
2023-04-25 7:05 ` Michael Walle
2023-04-26 11:28 ` Sahin, Okan
2023-04-26 11:53 ` Michael Walle [this message]
2023-04-26 13:39 ` Sahin, Okan
2023-04-11 14:11 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4a6a640c373b6d939e147691efa596c@walle.cc \
--to=michael@walle.cc \
--cc=Okan.Sahin@analog.com \
--cc=andy.shevchenko@gmail.com \
--cc=brgl@bgdev.pl \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).