From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1] pinctrl: intel: Actually disable Tx and Rx buffers on GPIO request
Date: Mon, 7 Dec 2020 15:52:03 -0600 [thread overview]
Message-ID: <d5319c0f-977e-d152-ba88-033a4feafd95@linux.intel.com> (raw)
In-Reply-To: <20201207181656.GZ5246@lahna.fi.intel.com>
On 12/7/20 12:16 PM, Mika Westerberg wrote:
> On Mon, Dec 07, 2020 at 07:59:40PM +0200, Andy Shevchenko wrote:
>> Mistakenly the buffers (input and output) become together enabled for a little
>> period of time during GPIO request. This is problematic, because instead of
>> initial motive to disable them in the commit af7e3eeb84e2
>> ("pinctrl: intel: Disable input and output buffer when switching to GPIO"),
>> the driven value on the pin, which might be used as an IRQ line, brings
>> firmware of some touch pads in an awkward state that needs a full power off
>> to recover. Fix this by, as stated in a culprit commit, disabling the buffers.
>>
>> Fixes: af7e3eeb84e2 ("pinctrl: intel: Disable input and output buffer when switching to GPIO")
>> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210497
>> Reported-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
On the initial device where I reported the problem, and with the battery
disconnected to make sure there's no EC issue, this patch restores the
touchpad functionality.
Tested-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
next prev parent reply other threads:[~2020-12-07 21:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 17:59 [PATCH v1] pinctrl: intel: Actually disable Tx and Rx buffers on GPIO request Andy Shevchenko
2020-12-07 18:08 ` Andy Shevchenko
2020-12-08 8:34 ` Linus Walleij
2020-12-08 9:48 ` Andy Shevchenko
2020-12-08 9:50 ` Andy Shevchenko
2020-12-08 18:25 ` Andy Shevchenko
2020-12-08 15:38 ` Linus Walleij
2020-12-07 18:16 ` Mika Westerberg
2020-12-07 21:52 ` Pierre-Louis Bossart [this message]
2020-12-08 0:56 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5319c0f-977e-d152-ba88-033a4feafd95@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).