From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66A0AC4361B for ; Mon, 7 Dec 2020 21:53:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DBAD235F9 for ; Mon, 7 Dec 2020 21:53:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726579AbgLGVxv (ORCPT ); Mon, 7 Dec 2020 16:53:51 -0500 Received: from mga04.intel.com ([192.55.52.120]:9201 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726556AbgLGVxv (ORCPT ); Mon, 7 Dec 2020 16:53:51 -0500 IronPort-SDR: R39LUIX27zWQgIlL2VBtImaQMlLdwN7dke3lI/d6+rBJy/Jl5vHhbj4DpM8gVHazNotTba9gz+ nAOuTLbn+4mw== X-IronPort-AV: E=McAfee;i="6000,8403,9828"; a="171211317" X-IronPort-AV: E=Sophos;i="5.78,400,1599548400"; d="scan'208";a="171211317" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2020 13:52:05 -0800 IronPort-SDR: U8AZmk0xViIpXcBYm7BaywiwIl+RHz5k+AxSqyoeuifZ9z37s1yamTj9s8ToCdPb6bTZSHjDJM 7NvW2sFbmCuQ== X-IronPort-AV: E=Sophos;i="5.78,400,1599548400"; d="scan'208";a="347628969" Received: from cegeorge-mobl.amr.corp.intel.com (HELO [10.212.61.7]) ([10.212.61.7]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2020 13:52:04 -0800 Subject: Re: [PATCH v1] pinctrl: intel: Actually disable Tx and Rx buffers on GPIO request To: Mika Westerberg , Andy Shevchenko Cc: linux-gpio@vger.kernel.org, Linus Walleij References: <20201207175940.10631-1-andriy.shevchenko@linux.intel.com> <20201207181656.GZ5246@lahna.fi.intel.com> From: Pierre-Louis Bossart Message-ID: Date: Mon, 7 Dec 2020 15:52:03 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201207181656.GZ5246@lahna.fi.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 12/7/20 12:16 PM, Mika Westerberg wrote: > On Mon, Dec 07, 2020 at 07:59:40PM +0200, Andy Shevchenko wrote: >> Mistakenly the buffers (input and output) become together enabled for a little >> period of time during GPIO request. This is problematic, because instead of >> initial motive to disable them in the commit af7e3eeb84e2 >> ("pinctrl: intel: Disable input and output buffer when switching to GPIO"), >> the driven value on the pin, which might be used as an IRQ line, brings >> firmware of some touch pads in an awkward state that needs a full power off >> to recover. Fix this by, as stated in a culprit commit, disabling the buffers. >> >> Fixes: af7e3eeb84e2 ("pinctrl: intel: Disable input and output buffer when switching to GPIO") >> BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=210497 >> Reported-by: Pierre-Louis Bossart >> Signed-off-by: Andy Shevchenko > > Acked-by: Mika Westerberg On the initial device where I reported the problem, and with the battery disconnected to make sure there's no EC issue, this patch restores the touchpad functionality. Tested-by: Pierre-Louis Bossart