Re: [PATCH v3 2/2] pinctrl: rockchip: add rk3308b SoC support

Dmitry Yashin
2024-06-05T12:06:29Z

Hi Dan,

On 6/5/24 12:22 PM, Dan Carpenter wrote:

> On Tue, Jun 04, 2024 at 07:10:20PM +0500, Dmitry Yashin wrote:
> Why does this one have a Fixes tag? Isn't this new hardware support?
> Possibly patch 1/2 was not actually a fix but just preparation for this
> patch?
>
> regards,
> dan carpenter

Initial pinctrl support for rk3308 included registers for rk3308b variant, which didn't work well with some pins of the first SoC and these reg's were fixed in the patch mentioned in this tag. So I added Fixes tag as this patch brings back proper setup for rk3308b and 1/2 indeed is the preparation. Thank you for taking your time on it. Perhaps I should describe such moments better next time.

--
Thanks,
Dmitry