Re: [PATCH v3 1/2] pinctrl: rockchip: delay recalced_mask and route_mask init

Dan Carpenter
2024-06-05T07:09:21Z

On Tue, Jun 04, 2024 at 07:10:19PM +0500, Dmitry Yashin wrote:
> For some SoC's like rk3308 additional runtime setup needed, so delay
> recalced_mask and route_mask init.
>
> Signed-off-by: Dmitry Yashin <dmt.yashin@gmail.com>

This sounds like it needs a Fixes tag. Should it be backported to
stable?

I understand that you only know that rk3308 is affected, and probably
you worry that other devices are as well? Just do your best on trying
to figure out which is the first commit where this bug started to
matter. Any information is better than no information.

The commit message should say what the bug looks like to the user. Why
would a user want this patch? I can probably figure it out from reading
the code, but I shouldn't have to.

regards,
dan carpenter