From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A265C433FE for ; Wed, 30 Nov 2022 03:45:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233399AbiK3DpR (ORCPT ); Tue, 29 Nov 2022 22:45:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59090 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233223AbiK3DoV (ORCPT ); Tue, 29 Nov 2022 22:44:21 -0500 Received: from mail-pl1-x629.google.com (mail-pl1-x629.google.com [IPv6:2607:f8b0:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FBEAE0C8; Tue, 29 Nov 2022 19:43:54 -0800 (PST) Received: by mail-pl1-x629.google.com with SMTP id jn7so15405299plb.13; Tue, 29 Nov 2022 19:43:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Q2iyrgtYDuQKt/kE7+C53HCWQJvUcvpFAzkZEkz/5Fk=; b=arIafAEMNCqxxUJ6A8NnFQ1SoS9OnNxJfCm0VwcbDkv2lL2Clx8ewRYqQsEHNp6a+o CWy6BkJol8zZo2XRRAyqSsvf5qmIeI/AYSnXJhIjd2RNSR8SuUJ1FIqXt39e0SQUeyO+ RT5BZkQDKd+UFdqHgmSCYtLUsznQf7QB2LtRgvf7qDNiUFraKaCt6M411grsfG0EzdkZ L+c7FpPe/3jlZGh9TFsb6lzm5b4IUNm0T4z6mNmVIu4JSZ/wI8HTn0X7MI89GIQNxtf8 xUjGICCQmMJToDxY9Fyym4SGqZIQjjf0hhCq6OdC1olzrhM4MI6P5gCO7PILN3o/2htV 6UZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Q2iyrgtYDuQKt/kE7+C53HCWQJvUcvpFAzkZEkz/5Fk=; b=xOq02Mtm4j5v7wMPrxn7Tf3Tvm+Y7COYMSVJ6i2lrGtp8t0eKuNNCH7Y/8vb4/SII8 jRY6q0rxwSv0/k8NpvZUI/ItopFL+DMDWdk/qcsVWa5vIL9ocKEBnOcUwfgbYQixhjjZ Yzwtopdvpaw/4AKioJ9Kb/np51Dnm3Zl4qpg25/Nn8ma+ZZ7RA9WuZ2IspjCCxILtofu hl+19FCoTMu18Gxh0KP1laMm6arH6iMyRvvR+SZPH/l9zWKiNieqkQEtJS/PLp0QghtD HYsQveWsUu6BzJwG9frZv302Zjz+c2rXbGrymfGBcU/eFozNi8aZrfD/OY3h4Pelzxmc paqQ== X-Gm-Message-State: ANoB5pk40imTSb3zXJk+XOaGfRsovPdDl2u8yo0RTaC+CFSUHTmuEZND XX1WrzRziuKd+7p0ihrTPuE= X-Google-Smtp-Source: AA0mqf6RgG4UbvdUAsdQcRV2TiZBLISWyGOQCPavRvxQ949guJf0YWnsneE94lxtpEV8RpHBZcMBHQ== X-Received: by 2002:a17:902:7d89:b0:188:4ba9:79ee with SMTP id a9-20020a1709027d8900b001884ba979eemr40717697plm.83.1669779833723; Tue, 29 Nov 2022 19:43:53 -0800 (PST) Received: from [192.168.43.80] (subs32-116-206-28-61.three.co.id. [116.206.28.61]) by smtp.gmail.com with ESMTPSA id j6-20020a170903028600b00189758e2babsm88850plr.125.2022.11.29.19.43.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Nov 2022 19:43:53 -0800 (PST) Message-ID: Date: Wed, 30 Nov 2022 10:43:47 +0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 5/7] hte: Re-phrase tegra API document Content-Language: en-US To: Dipen Patel Cc: thierry.reding@gmail.com, jonathanh@nvidia.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-gpio@vger.kernel.org, linus.walleij@linaro.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, robh+dt@kernel.org, timestamp@lists.linux.dev References: <20221103174523.29592-1-dipenp@nvidia.com> <20221103174523.29592-6-dipenp@nvidia.com> <5145d9d3-d3ae-e95a-6583-803f31d6d9b7@nvidia.com> From: Bagas Sanjaya In-Reply-To: <5145d9d3-d3ae-e95a-6583-803f31d6d9b7@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 11/30/22 10:34, Dipen Patel wrote: >> I think the wording can be better: > I do not understand, can you please elaborate? Exactly where? Please quote appropriate hunks from below where do you not understand. >> >> ---- >8 ---- >> >> diff --git a/Documentation/driver-api/hte/tegra194-hte.rst b/Documentation/driver-api/hte/tegra194-hte.rst >> index 85e654772782c1..13c45bfc03a75e 100644 >> --- a/Documentation/driver-api/hte/tegra194-hte.rst >> +++ b/Documentation/driver-api/hte/tegra194-hte.rst >> @@ -5,11 +5,11 @@ HTE Kernel provider driver >> >> Description >> ----------- >> -The Nvidia tegra HTE provider also known as GTE (Generic Timestamping Engine) >> -driver implements two GTE instances: 1) GPIO GTE and 2) LIC >> -(Legacy Interrupt Controller) IRQ GTE. Both GTE instances get the timestamp >> -from the system counter TSC which has 31.25MHz clock rate, and the driver >> -converts clock tick rate to nanoseconds before storing it as timestamp value. >> +The Nvidia tegra HTE provider, also known as GTE (Generic Timestamping Engine) >> +driver implements two GTE instances: GPIO GTE and LIC (Legacy Interrupt >> +Controller) IRQ GTE. Both GTE instances get the timestamp from system counter >> +TSC which has 31.25MHz clock rate, and the driver converts clock tick rate to >> +nanoseconds before storing it as timestamp value. >> >> GPIO GTE >> -------- >> @@ -19,17 +19,17 @@ needs to be configured as input. Only the always on (AON) GPIO controller >> instance supports timestamping GPIOs in real time as it is tightly coupled with >> the GPIO GTE. To support this, GPIOLIB adds two optional APIs as mentioned >> below. The GPIO GTE code supports both kernel and userspace consumers. The >> -kernel space consumers can directly talk to HTE subsystem while userspace >> -consumers timestamp requests go through GPIOLIB CDEV framework to HTE >> -subsystem. The hte devicetree binding described at >> -``Documentation/devicetree/bindings/timestamp`` provides an example of how a >> -consumer can request an GPIO line. >> +kernel space consumers can directly talk to HTE subsystem while requests from >> +userspace consumers go through GPIOLIB CDEV framework to HTE subsystem. The hte >> +devicetree binding described at ``Documentation/devicetree/bindings/timestamp`` >> +provides an example of how a consumer can request an GPIO line. >> >> -See gpiod_enable_hw_timestamp_ns() and gpiod_disable_hw_timestamp_ns(). >> +To toggle hardware timestamp, use gpiod_enable_hw_timestamp_ns() and >> +gpiod_disable_hw_timestamp_ns(). >> >> For userspace consumers, GPIO_V2_LINE_FLAG_EVENT_CLOCK_HTE flag must be >> -specified during IOCTL calls. Refer to ``tools/gpio/gpio-event-mon.c``, which >> -returns the timestamp in nanoseconds. >> +specified during IOCTL calls. Refer to ``tools/gpio/gpio-event-mon.c`` for >> +example. >> >> LIC (Legacy Interrupt Controller) IRQ GTE >> ----------------------------------------- >> Thanks anyway. -- An old man doll... just what I always wanted! - Clara