From: Niyas Sait <niyas.sait@linaro.org>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, andriy.shevchenko@linux.intel.com,
rafael@kernel.org, linus.walleij@linaro.org
Subject: Re: [PATCH RFC v2 1/3] pinctrl: add support for ACPI PinGroup resource
Date: Thu, 17 Nov 2022 13:28:01 +0000 [thread overview]
Message-ID: <d72903a9-ba74-fc0e-5d40-6bb50f4d8354@linaro.org> (raw)
In-Reply-To: <Y3SwV2ygYb3C0w4o@black.fi.intel.com>
On 16/11/2022 09:41, Mika Westerberg wrote:
>> + * pinctrl_acpi_get_pin_groups() - Get ACPI PinGroup Descriptors for the device
>> + * @adev: ACPI device node for retrieving PinGroup descriptors
>> + * @group_desc_list: list head to add PinGroup descriptors
>> + *
>> + * This will parse ACPI PinGroup resources for the given ACPI device
>> + * and will add descriptors to the provided @group_desc_list list
> I would add here what happens to group_desc_list if the function returns
> non-zero.
>
> Also perhaps the API should use an array instead and when NULL is passed
> it returns the size as we do with properties for example. The naged
> list_head pointer looks kind of weird.
Array would be nice. However I might have to do an additional acpi walk
to find the number of PinGroups to allocate array and another iteration
to populate fields. May be two iterations are not as bad as I thought.
Open to suggestions.
--
Niyas
next prev parent reply other threads:[~2022-11-17 13:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 17:54 [PATCH RFC v2 0/3] pinctrl: add ACPI support to pin controller Niyas Sait
2022-11-15 17:54 ` [PATCH RFC v2 1/3] pinctrl: add support for ACPI PinGroup resource Niyas Sait
2022-11-16 9:41 ` Mika Westerberg
2022-11-17 13:28 ` Niyas Sait [this message]
2022-11-17 15:08 ` Mika Westerberg
2022-11-15 17:54 ` [PATCH RFC v2 2/3] pinconf-generic: clarify pull up and pull down config values Niyas Sait
2022-11-17 9:30 ` Linus Walleij
2022-11-17 10:37 ` Andy Shevchenko
2022-11-17 10:39 ` Andy Shevchenko
2022-11-17 11:53 ` Niyas Sait
2022-11-17 12:36 ` Andy Shevchenko
2022-11-15 17:54 ` [PATCH RFC v2 3/3] pinctrl: add support for ACPI pin function and config resources Niyas Sait
2022-11-16 9:57 ` Mika Westerberg
2022-11-15 18:12 ` [PATCH RFC v2 0/3] pinctrl: add ACPI support to pin controller Andy Shevchenko
2022-11-15 18:29 ` Niyas Sait
2022-11-15 18:47 ` Andy Shevchenko
2022-11-15 19:15 ` Niyas Sait
2022-11-16 10:16 ` Andy Shevchenko
2022-11-16 10:27 ` Niyas Sait
2022-11-16 9:50 ` Niyas Sait
2022-11-16 9:56 ` Andy Shevchenko
2022-11-16 10:40 ` Niyas Sait
2022-11-16 13:27 ` Andy Shevchenko
2022-11-16 13:38 ` Andy Shevchenko
2022-11-16 10:17 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d72903a9-ba74-fc0e-5d40-6bb50f4d8354@linaro.org \
--to=niyas.sait@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).