From: Neil Armstrong <neil.armstrong@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 03/12] arm64: dts: qcom: sm8250: correct LPASS pin pull down
Date: Wed, 28 Sep 2022 09:38:47 +0200 [thread overview]
Message-ID: <d78d7a8f-e116-b18f-9a4d-eadecef329ca@linaro.org> (raw)
In-Reply-To: <20220927153429.55365-4-krzysztof.kozlowski@linaro.org>
On 27/09/2022 17:34, Krzysztof Kozlowski wrote:
> The pull-down property is actually bias-pull-down.
>
> Fixes: 3160c1b894d9 ("arm64: dts: qcom: sm8250: add lpass lpi pin controller node")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index a5b62cadb129..8f402b912c62 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2454,7 +2454,7 @@ data {
> pins = "gpio7";
> function = "dmic1_data";
> drive-strength = <2>;
> - pull-down;
> + bias-pull-down;
> input-enable;
> };
> };
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2022-09-28 7:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-27 15:34 [PATCH v2 00/12] pinctrl/arm64: qcom: continued - fix Qualcomm LPASS pinctrl schema warnings Krzysztof Kozlowski
2022-09-27 15:34 ` [PATCH v2 01/12] arm64: dts: qcom: sc7280: drop clock-cells from LPASS TLMM Krzysztof Kozlowski
2022-09-28 7:37 ` Neil Armstrong
2022-09-27 15:34 ` [PATCH v2 02/12] arm64: dts: qcom: sc7280: align LPASS pin configuration with DT schema Krzysztof Kozlowski
2022-09-28 7:38 ` Neil Armstrong
2022-09-27 15:34 ` [PATCH v2 03/12] arm64: dts: qcom: sm8250: correct LPASS pin pull down Krzysztof Kozlowski
2022-09-28 7:38 ` Neil Armstrong [this message]
2022-09-27 15:34 ` [PATCH v2 04/12] arm64: dts: qcom: sm8250: align LPASS pin configuration with DT schema Krzysztof Kozlowski
2022-09-28 7:39 ` Neil Armstrong
2022-09-27 15:34 ` [PATCH v2 05/12] dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: fix gpio pattern Krzysztof Kozlowski
2022-10-17 20:07 ` (subset) " Krzysztof Kozlowski
2022-09-27 15:34 ` [PATCH v2 06/12] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi: " Krzysztof Kozlowski
2022-10-17 20:07 ` (subset) " Krzysztof Kozlowski
2022-09-27 15:34 ` [PATCH v2 07/12] dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: fix matching pin config Krzysztof Kozlowski
2022-10-17 20:07 ` (subset) " Krzysztof Kozlowski
2022-09-27 15:34 ` [PATCH v2 08/12] dt-bindings: pinctrl: qcom,sc8280xp-lpass-lpi: " Krzysztof Kozlowski
2022-10-17 20:07 ` (subset) " Krzysztof Kozlowski
2022-09-27 15:34 ` [PATCH v2 09/12] dt-bindings: pinctrl: qcom,sm8250-lpass-lpi: " Krzysztof Kozlowski
2022-10-17 20:07 ` (subset) " Krzysztof Kozlowski
2022-09-27 15:34 ` [PATCH v2 10/12] dt-bindings: pinctrl: qcom,sm8450-lpass-lpi: " Krzysztof Kozlowski
2022-10-17 20:07 ` (subset) " Krzysztof Kozlowski
2022-09-27 15:34 ` [PATCH v2 11/12] dt-bindings: pinctrl: qcom,sc7280-lpass-lpi: add bias-bus-hold Krzysztof Kozlowski
2022-10-17 20:07 ` (subset) " Krzysztof Kozlowski
2022-09-27 15:34 ` [PATCH v2 12/12] dt-bindings: pinctrl: qcom,sm8250-lpass-lpi: add bias-bus-hold and input-enable Krzysztof Kozlowski
2022-10-17 20:07 ` (subset) " Krzysztof Kozlowski
2022-11-07 3:12 ` (subset) [PATCH v2 00/12] pinctrl/arm64: qcom: continued - fix Qualcomm LPASS pinctrl schema warnings Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d78d7a8f-e116-b18f-9a4d-eadecef329ca@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).