From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8D9EC32771 for ; Wed, 28 Sep 2022 07:41:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233267AbiI1Hls (ORCPT ); Wed, 28 Sep 2022 03:41:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37728 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233288AbiI1Hk0 (ORCPT ); Wed, 28 Sep 2022 03:40:26 -0400 Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3D0A10B22A for ; Wed, 28 Sep 2022 00:38:50 -0700 (PDT) Received: by mail-wr1-x42e.google.com with SMTP id bk15so10638256wrb.13 for ; Wed, 28 Sep 2022 00:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:reply-to :references:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date; bh=9mwqVpcROHFrTuun+8fH0k0fzdJFZz46YIZVmPKpuM0=; b=dqb92086L3WbdmsM2vxAQEEN6+JbVZN0w9+uVpNEhj1bGsDBA1zzuPo+IaW2gGHqGH PhQm3zVFFKePmtYcZOnF206vDk+NEHCzAgeeQKzaKb0VCqqgHVGbYWNFyM/oDidkThwW J4CLQ0VcmO8jIoipyCrQgnKoHDr4e5vWgfXiLaQ15lmUiqoezLzsZd+cZfEYFj94cE1E 2ywyCFD8pH3wLO9TozuoR2Jafb0vxmh4es2pOHUVPrdhhuE2h7/TH2cMwTunpo7PxuRM 24VkPKFG19EHEDPrti7s1UVvWGLJPqGjCCfJ3wzEZ3PWpw01Wh4gzGvg1pCfV4fNGPtw Z6tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:reply-to :references:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=9mwqVpcROHFrTuun+8fH0k0fzdJFZz46YIZVmPKpuM0=; b=fP/IQngYVEPVYf7Jnu/5tjCY8Iti2OT0VuyGrKqRXoqq+gAI9Yj4F3D69NbupqItqW Oo4ZFW4fhF6+7MlCzXgNjcFvWn7ccGK+9+Pu7pL/7DUIut+2q2k05uCJZhdjEFtGa9Y2 XvBC1hQaUs5l24ug7R+dJ76ECbaDbrwlzD2R+wg7aZVjFc/3KkVcTnOLnlruZIEO1o4W NNY4Bb3198tOAl/zstpH/75s0W6OnFL8BnhXOemnT4r4ARAND1pawzE1uvNtU6g++IEH dsSzPUJtuU5eVPnvSHLd1ZAFzYJ6wDa8QG4ZVPy0SqjjoLuwW9zv9muwrticlafu3Ew+ c/Gw== X-Gm-Message-State: ACrzQf2gXEFaVpqSpHg57IYF5kP0oANTgqgxytqU/lUhVqhJytoLmWbT 18LLzawgM7WB41XvDcBvgfIU+Q== X-Google-Smtp-Source: AMsMyM70jaPUX0HYeQSyigtQZAXaqR1jhEaKm6f1s+rJ/gb94ZIZgWq8iycJ8wjFpkFgGA4s9wRhcg== X-Received: by 2002:a05:6000:1e14:b0:22b:3aa1:f310 with SMTP id bj20-20020a0560001e1400b0022b3aa1f310mr17725979wrb.108.1664350729006; Wed, 28 Sep 2022 00:38:49 -0700 (PDT) Received: from ?IPV6:2a01:e0a:982:cbb0:11d4:7c71:accf:6521? ([2a01:e0a:982:cbb0:11d4:7c71:accf:6521]) by smtp.gmail.com with ESMTPSA id ba11-20020a0560001c0b00b0022a9246c853sm3552446wrb.41.2022.09.28.00.38.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Sep 2022 00:38:48 -0700 (PDT) Message-ID: Date: Wed, 28 Sep 2022 09:38:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 03/12] arm64: dts: qcom: sm8250: correct LPASS pin pull down Content-Language: en-US To: Krzysztof Kozlowski , Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Srinivas Kandagatla , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220927153429.55365-1-krzysztof.kozlowski@linaro.org> <20220927153429.55365-4-krzysztof.kozlowski@linaro.org> Reply-To: neil.armstrong@linaro.org From: Neil Armstrong Organization: Linaro Developer Services In-Reply-To: <20220927153429.55365-4-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 27/09/2022 17:34, Krzysztof Kozlowski wrote: > The pull-down property is actually bias-pull-down. > > Fixes: 3160c1b894d9 ("arm64: dts: qcom: sm8250: add lpass lpi pin controller node") > Signed-off-by: Krzysztof Kozlowski > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index a5b62cadb129..8f402b912c62 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -2454,7 +2454,7 @@ data { > pins = "gpio7"; > function = "dmic1_data"; > drive-strength = <2>; > - pull-down; > + bias-pull-down; > input-enable; > }; > }; Reviewed-by: Neil Armstrong