From mboxrd@z Thu Jan 1 00:00:00 1970 From: Timur Tabi Subject: Re: [PATCH] gpiolib: Show correct direction from the beginning Date: Wed, 19 Sep 2018 06:50:25 -0500 Message-ID: References: <20180914070839.4667-1-ricardo.ribalda@gmail.com> <20180914070839.4667-2-ricardo.ribalda@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Ricardo Ribalda Delgado , Linus Walleij Cc: Timur Tabi , swboyd@chromium.org, linux-gpio@vger.kernel.org, LKML List-Id: linux-gpio@vger.kernel.org On 9/18/18 11:04 PM, Ricardo Ribalda Delgado wrote: > And should't that be tacked in qcom hardware with something like: > > if (!priv->initialized) > return INPUT; > > if you or Timur point me to the harware that was crashing I would not > mind looking into that, but the current situations seems to me like a > hack. I'd say the previous code was the hack. My comment about not touching the hardware until it is properly claimed is valid, and it applies to all platforms.