linux-gpio.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: sathyanarayanan kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Darren Hart <dvhart@infradead.org>
Cc: gnurou@gmail.com, linus.walleij@linaro.org, edubezval@gmail.com,
	rui.zhang@intel.com, lee.jones@linaro.org, andy@infradead.org,
	linux-gpio@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	platform-driver-x86@vger.kernel.org, sathyaosid@gmail.com
Subject: Re: [PATCH v2 8/8] platform: x86: intel_bxtwc_tmu: remove first level irq unmask
Date: Fri, 21 Apr 2017 15:34:05 -0700	[thread overview]
Message-ID: <d9ead97f-db7b-a0b0-4eb1-1c783ee1e841@linux.intel.com> (raw)
In-Reply-To: <20170421220025.GC31650@fury>

Hi Darren,

Thanks for the review.


On 04/21/2017 03:00 PM, Darren Hart wrote:
> On Fri, Apr 14, 2017 at 04:26:00PM -0700, sathyanarayanan.kuppuswamy@linux.intel.com wrote:
>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>>
>> Currently in WCOVE PMIC mfd driver, all second level irq chips
> By currently I believe you mean after the earlier patch in this series is
> applied, correct?
Yes.
> This one is dependent on the previous one?
Yes, one of my previous patch in this series fixes this problem in MFD 
driver.
>
>> are chained to the respective first level irqs. So there is no
>> need for explicitly unmasking the first level irq in this
>> driver. This patches removes this level 1 irq unmask support.
>>
>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
> For platform drivers x86:
>
> Reviewed-by: Darren Hart (VMware) <dvhart@infradead.org>
>
> Are you working with a specific maintainers to pull this in as a series?
Thanks for brining it up. I was planning to ask either Andy or Lee 
regarding this issue after all patches in the series are reviewed.
> With so
> many subsystems, we need to coordinate to make sure we don't make a mess for
> Linus. Given the interdependencies, I'd recommend someone pull the series in as
> a whole - maybe into MFD? Lee, do you have a preference?
>

-- 
Sathyanarayanan Kuppuswamy
Android kernel developer

  reply	other threads:[~2017-04-21 22:34 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-14 23:25 [PATCH v2 1/8] mfd: intel_soc_pmic_bxtwc: fix TMU interrupt index sathyanarayanan.kuppuswamy
2017-04-14 23:25 ` [PATCH v2 2/8] mfd: intel_soc_pmic_bxtwc: remove thermal second level irqs sathyanarayanan.kuppuswamy
2017-04-14 23:25 ` [PATCH v2 3/8] thermal: intel_bxt_pmic_thermal: use first level PMIC thermal irq sathyanarayanan.kuppuswamy
2017-05-22 10:17   ` Lee Jones
2017-05-22 19:08     ` sathyanarayanan kuppuswamy
2017-05-23  6:24   ` Zhang Rui
2017-05-23  7:26     ` Lee Jones
2017-05-23 17:29       ` [PATCH v3 1/8] mfd: intel_soc_pmic_bxtwc: fix TMU interrupt index sathyanarayanan.kuppuswamy
2017-05-23 17:30         ` [PATCH v3 2/8] mfd: intel_soc_pmic_bxtwc: remove thermal second level irqs sathyanarayanan.kuppuswamy
2017-05-23 17:30         ` [PATCH v3 3/8] thermal: intel_bxt_pmic_thermal: use first level PMIC thermal irq sathyanarayanan.kuppuswamy
2017-05-23 17:30         ` [PATCH v3 4/8] mfd: intel_soc_pmic_bxtwc: remove second level irq for gpio device sathyanarayanan.kuppuswamy
2017-05-23 17:30         ` [PATCH v3 5/8] gpio: gpio-wcove: use first level PMIC GPIO irq sathyanarayanan.kuppuswamy
2017-05-23 17:30         ` [PATCH v3 6/8] mfd: intel_soc_pmic_bxtwc: utilize devm_* functions in driver probe sathyanarayanan.kuppuswamy
2017-05-23 17:30         ` [PATCH v3 7/8] mfd: intel_soc_pmic_bxtwc: use chained irqs for second level irq chips sathyanarayanan.kuppuswamy
2017-05-23 17:30         ` [PATCH v3 8/8] platform: x86: intel_bxtwc_tmu: remove first level irq unmask sathyanarayanan.kuppuswamy
2017-05-30  8:53         ` [GIT PULL] Immutable branch between MFD, GPIO, Thermal and X86 due for the v4.13 merge window Lee Jones
2017-05-31  3:38           ` Stephen Rothwell
2017-05-31  4:27             ` Sathyanarayanan Kuppuswamy Natarajan
2017-05-31  4:29             ` Sathyanarayanan Kuppuswamy Natarajan
2017-05-31  6:57               ` Lee Jones
2017-05-31 22:33                 ` sathyanarayanan kuppuswamy
2017-06-03 17:01                   ` Darren Hart
2017-05-31  6:50             ` Lee Jones
2017-05-31  7:02           ` Lee Jones
2017-05-31 22:37             ` [PATCH v5 0/8] mfd: intel_soc_pmic_bxtwc: Add chained IRQ support sathyanarayanan.kuppuswamy
2017-05-31 22:37               ` [PATCH v5 1/8] mfd: intel_soc_pmic_bxtwc: Fix TMU interrupt index sathyanarayanan.kuppuswamy
2017-05-31 22:37               ` [PATCH v5 2/8] mfd: intel_soc_pmic_bxtwc: Remove thermal second level irqs sathyanarayanan.kuppuswamy
2017-05-31 22:37               ` [PATCH v5 3/8] thermal: intel_bxt_pmic_thermal: Use first level PMIC thermal irq sathyanarayanan.kuppuswamy
2017-06-03 13:00                 ` Andy Shevchenko
2017-06-03 17:28                   ` Sathyanarayanan Kuppuswamy Natarajan
2017-06-03 17:32                     ` Andy Shevchenko
2017-06-03 17:53                       ` Sathyanarayanan Kuppuswamy Natarajan
2017-06-03 18:18                         ` Andy Shevchenko
2017-06-05 19:08                           ` [PATCH v6 0/6] mfd: intel_soc_pmic_bxtwc: Add chained IRQ support sathyanarayanan.kuppuswamy
2017-06-05 19:08                             ` [PATCH v6 1/6] mfd: intel_soc_pmic_bxtwc: Fix TMU interrupt index sathyanarayanan.kuppuswamy
2017-06-05 19:08                             ` [PATCH v6 2/6] mfd: intel_soc_pmic_bxtwc: Remove thermal second level IRQs sathyanarayanan.kuppuswamy
2017-06-05 19:08                             ` [PATCH v6 3/6] mfd: intel_soc_pmic_bxtwc: Remove second level IRQ for gpio device sathyanarayanan.kuppuswamy
2017-06-05 19:08                             ` [PATCH v6 4/6] mfd: intel_soc_pmic_bxtwc: Utilize devm_* functions in driver probe sathyanarayanan.kuppuswamy
2017-06-05 19:08                             ` [PATCH v6 5/6] mfd: intel_soc_pmic_bxtwc: Use chained IRQs for second level IRQ chips sathyanarayanan.kuppuswamy
2017-06-06  9:29                               ` Heikki Krogerus
2017-06-05 19:08                             ` [PATCH v6 6/6] platform/x86: intel_bxtwc_tmu: Remove first level IRQ unmask sathyanarayanan.kuppuswamy
2017-06-06  9:36                             ` [PATCH v6 0/6] mfd: intel_soc_pmic_bxtwc: Add chained IRQ support Andy Shevchenko
2017-06-19 14:48                             ` [GIT PULL] Immutable branch between MFD and X86 due for the v4.13 merge window Lee Jones
2017-06-19 15:08                               ` Andy Shevchenko
2017-06-19 19:54                                 ` Darren Hart
2017-05-31 22:37               ` [PATCH v5 4/8] mfd: intel_soc_pmic_bxtwc: Remove second level irq for gpio device sathyanarayanan.kuppuswamy
2017-05-31 22:37               ` [PATCH v5 5/8] gpio: gpio-wcove: Use first level PMIC GPIO irq sathyanarayanan.kuppuswamy
2017-06-03 13:01                 ` Andy Shevchenko
2017-05-31 22:37               ` [PATCH v5 7/8] mfd: intel_soc_pmic_bxtwc: Use chained irqs for second level irq chips sathyanarayanan.kuppuswamy
2017-06-03 13:26                 ` Andy Shevchenko
2017-05-31 22:37               ` [PATCH v5 8/8] platform/x86: intel_bxtwc_tmu: Remove first level irq unmask sathyanarayanan.kuppuswamy
2017-06-03 13:27               ` [PATCH v5 0/8] mfd: intel_soc_pmic_bxtwc: Add chained IRQ support Andy Shevchenko
     [not found]             ` <cover.1496266871.git.sathyanarayanan.kuppuswamy-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2017-05-31 22:37               ` [PATCH v5 6/8] mfd: intel_soc_pmic_bxtwc: Utilize devm_* functions in driver probe sathyanarayanan.kuppuswamy-VuQAYsv1563Yd54FQh9/CA
2017-06-03 13:03                 ` Andy Shevchenko
2017-04-14 23:25 ` [PATCH v2 4/8] mfd: intel_soc_pmic_bxtwc: remove second level irq for gpio device sathyanarayanan.kuppuswamy
2017-04-14 23:25 ` [PATCH v2 5/8] gpio: gpio-wcove: use first level PMIC GPIO irq sathyanarayanan.kuppuswamy
2017-04-24 13:17   ` Linus Walleij
2017-04-26 15:40     ` Andy Shevchenko
2017-04-14 23:25 ` [PATCH v2 6/8] mfd: intel_soc_pmic_bxtwc: utilize devm_* functions in driver probe sathyanarayanan.kuppuswamy
2017-04-24 12:03   ` Lee Jones
2017-04-14 23:25 ` [PATCH v2 7/8] mfd: intel_soc_pmic_bxtwc: use chained irqs for second level irq chips sathyanarayanan.kuppuswamy
2017-04-24 12:04   ` Lee Jones
2017-04-14 23:26 ` [PATCH v2 8/8] platform: x86: intel_bxtwc_tmu: remove first level irq unmask sathyanarayanan.kuppuswamy
2017-04-21 22:00   ` Darren Hart
2017-04-21 22:34     ` sathyanarayanan kuppuswamy [this message]
2017-04-22  2:52       ` Andy Shevchenko
2017-04-24  9:24         ` Lee Jones
2017-04-24  9:44           ` Andy Shevchenko
2017-04-24 12:24             ` Lee Jones
2017-04-26 15:44               ` Andy Shevchenko
2017-04-24  9:26     ` Lee Jones
2017-05-30  8:54 ` [PATCH v2 1/8] mfd: intel_soc_pmic_bxtwc: fix TMU interrupt index Lee Jones
2017-05-30 18:00   ` sathyanarayanan kuppuswamy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d9ead97f-db7b-a0b0-4eb1-1c783ee1e841@linux.intel.com \
    --to=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=andy@infradead.org \
    --cc=dvhart@infradead.org \
    --cc=edubezval@gmail.com \
    --cc=gnurou@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=sathyaosid@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).