From: Andrei Stefanescu <andrei.stefanescu@oss.nxp.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Chester Lin <chester62515@gmail.com>,
Matthias Brugger <mbrugger@suse.com>,
Ghennadi Procopciuc <Ghennadi.Procopciuc@nxp.com>,
Larisa Grigore <larisa.grigore@nxp.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
NXP S32 Linux Team <s32@nxp.com>
Subject: Re: [PATCH 2/3] drivers: gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support
Date: Mon, 26 Aug 2024 17:03:32 +0300 [thread overview]
Message-ID: <daaec2b0-0eaa-4a54-9cf9-70ad9aee34c7@oss.nxp.com> (raw)
In-Reply-To: <CACRpkdaZbHsi1zeHr+HyUgfdCDHm1DaA1=peH8BjVSirga_sVg@mail.gmail.com>
Hi Linus,
On 26/08/2024 12:42, Linus Walleij wrote:
> Hi Andrei,
>
> thanks for your patch!
>
> On Mon, Aug 26, 2024 at 10:43 AM Andrei Stefanescu
> <andrei.stefanescu@oss.nxp.com> wrote:
>
Thank you for the quick review!
>
> As Krzysztof points out: the driver is based on something really old and
> needs an overhaul. Luckily GPIO drivers are not that big so it should be
> pretty straight-forward.
>
Are there other changes, apart from the ones in this email and those already
suggested by Krzysztof, that I should consider for v2?
I will fix the other comments in v2.
Best regards,
Andrei
next prev parent reply other threads:[~2024-08-26 14:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-26 8:42 [PATCH 0/3] gpio: siul2-s32g2: add initial GPIO driver Andrei Stefanescu
2024-08-26 8:42 ` [PATCH 1/3] dt-bindings: gpio: add schema for NXP S32G2/S32G3 SoCs Andrei Stefanescu
2024-08-26 9:14 ` Krzysztof Kozlowski
2024-08-26 9:36 ` Krzysztof Kozlowski
2024-08-26 8:42 ` [PATCH 2/3] drivers: gpio: siul2-s32g2: add NXP S32G2/S32G3 SoCs support Andrei Stefanescu
2024-08-26 9:10 ` Krzysztof Kozlowski
2024-08-26 14:03 ` Andrei Stefanescu
2024-08-26 14:04 ` Krzysztof Kozlowski
2024-09-06 8:43 ` Andrei Stefanescu
2024-09-06 9:39 ` Krzysztof Kozlowski
2024-09-06 9:45 ` Andrei Stefanescu
2024-09-06 9:53 ` Krzysztof Kozlowski
2024-09-06 11:50 ` Andrei Stefanescu
2024-09-06 12:02 ` Krzysztof Kozlowski
2024-08-26 9:42 ` Linus Walleij
2024-08-26 14:03 ` Andrei Stefanescu [this message]
2024-08-26 14:06 ` Andrew Lunn
2024-08-27 2:23 ` kernel test robot
2024-08-27 4:38 ` kernel test robot
2024-08-26 8:42 ` [PATCH 3/3] MAINTAINERS: add MAINTAINER for S32G2 SIUL2 GPIO driver Andrei Stefanescu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=daaec2b0-0eaa-4a54-9cf9-70ad9aee34c7@oss.nxp.com \
--to=andrei.stefanescu@oss.nxp.com \
--cc=Ghennadi.Procopciuc@nxp.com \
--cc=brgl@bgdev.pl \
--cc=chester62515@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=larisa.grigore@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbrugger@suse.com \
--cc=robh@kernel.org \
--cc=s32@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).