From: Krzysztof Kozlowski <krzk@kernel.org>
To: David Leonard <David.Leonard@digi.com>
Cc: linux-arm-kernel@lists.infradead.org,
Dong Aisheng <aisheng.dong@nxp.com>,
Fabio Estevam <festevam@gmail.com>,
Shawn Guo <shawnguo@kernel.org>, Jacky Bai <ping.bai@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] dt-bindings: pinctrl: Add fsl,ls1012a-pinctrl yaml file
Date: Tue, 27 Aug 2024 19:28:41 +0200 [thread overview]
Message-ID: <db12d221-d3b1-4df5-91e4-d31fb0acdb8b@kernel.org> (raw)
In-Reply-To: <f682476b-f7af-0d66-7105-1d064f5f1739@digi.com>
On 27/08/2024 18:51, David Leonard wrote:
>>> +properties:
>>> + compatible:
>>> + const: fsl,ls1012a-pinctrl
>>> +
>>> + reg:
>>> + description: Specifies the base address of the PMUXCR0 register.
>>> + maxItems: 2
>>
>> Instead list and describe the items.
>
> Changed to
>
> reg:
> items:
> - description: Physical base address of the PMUXCR0 register.
> - description: Size of the PMUXCR0 register (4).
>
> Is this what you meant?
Almost, second reg is not a size. You claim there are two IO address
spaces. Each address space contains base address and size. Look at other
bindings how they do it.
>
>>> +
>>> + big-endian:
>>> + description: If present, the PMUXCR0 register is implemented in big-endian.
>>
>> Why is this here? Either it is or it is not?
>
> You're right. Changed to
>
> big-endian: true
>
> (This also lead to some code simplification)
OK, but I still wonder why is it here. Without it the hardware will work
in little-endian?
>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-27 17:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 2:10 [PATCH 3/6] dt-bindings: pinctrl: Add fsl,ls1012a-pinctrl yaml file David Leonard
2024-08-27 3:22 ` Rob Herring (Arm)
2024-08-27 6:17 ` Krzysztof Kozlowski
2024-08-27 16:51 ` David Leonard
2024-08-27 17:28 ` Krzysztof Kozlowski [this message]
2024-08-28 0:43 ` David Leonard
2024-08-28 2:51 ` David Leonard
2024-08-28 5:43 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db12d221-d3b1-4df5-91e4-d31fb0acdb8b@kernel.org \
--to=krzk@kernel.org \
--cc=David.Leonard@digi.com \
--cc=aisheng.dong@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ping.bai@nxp.com \
--cc=robh@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).