From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Kumaravel.Thiagarajan@microchip.com,
linux-kernel@vger.kernel.org, sudipm.mukherjee@gmail.com,
arnd@arndb.de, linux-gpio@vger.kernel.org,
linux-next@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH char-misc-next] misc: microchip: pci1xxxx: use DEFINE_SIMPLE_DEV_PM_OPS() in place of the SIMPLE_DEV_PM_OPS() in pci1xxxx's gpio driver
Date: Wed, 14 Sep 2022 08:59:33 +0700 [thread overview]
Message-ID: <db2fdc22-44b8-1e81-ace2-c83c143ac20e@gmail.com> (raw)
In-Reply-To: <BN8PR11MB3668C9D5BD38AECBE160D013E9479@BN8PR11MB3668.namprd11.prod.outlook.com>
On 9/14/22 01:27, Kumaravel.Thiagarajan@microchip.com wrote:
>> On 9/12/22 18:36, Kumaravel Thiagarajan wrote:
>>> build errors listed below and reported for the builds of riscv, s390,
>>> csky, alpha and loongarch allmodconfig are fixed in this patch.
>>>
>>> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error:
>> 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function]
>>> 311 | static int pci1xxxx_gpio_resume(struct device *dev)
>>> | ^~~~~~~~~~~~~~~~~~~~
>>> drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error:
>> 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function]
>>> 295 | static int pci1xxxx_gpio_suspend(struct device *dev)
>>> | ^~~~~~~~~~~~~~~~~~~~~
>>>
>>
>> What about this description?:
>>
>> "Sudip reported unused function errors on riscv, s390, cksy, alpha, and
>> loongarch (allmodconfig):
>> <pci1xxxx_gpio_* errors>...
>>
>> Fix these errors by using DEFINE_SIMPLE_DEV_PM_OPS."
> It looks good even though it does not include all the details.
> But is not how much of detail good enough subjective?
> I thought some might be looking for more information and chose this way.
> Do you think I need to change this? Please let me know.
Yes, with full error text as Sudip had reported.
--
An old man doll... just what I always wanted! - Clara
next prev parent reply other threads:[~2022-09-14 1:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 11:36 [PATCH char-misc-next] misc: microchip: pci1xxxx: use DEFINE_SIMPLE_DEV_PM_OPS() in place of the SIMPLE_DEV_PM_OPS() in pci1xxxx's gpio driver Kumaravel Thiagarajan
2022-09-13 13:44 ` Bagas Sanjaya
2022-09-13 18:27 ` Kumaravel.Thiagarajan
2022-09-14 1:59 ` Bagas Sanjaya [this message]
2022-09-15 9:50 ` Kumaravel.Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=db2fdc22-44b8-1e81-ace2-c83c143ac20e@gmail.com \
--to=bagasdotme@gmail.com \
--cc=Kumaravel.Thiagarajan@microchip.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).