Re: [PATCH] pinctrl: k210: Modify the wrong "#undef"

[Damien Le Moal <dlemoal@kernel.org>]

On 11/13/24 10:20, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> 
> Here shuld be undef "K210_PC_DEFAULT", not "DEFAULT".

Here ? Please be specific.
Also:

s/shuld/must

So something like:

The definition of the array k210_pinconf_mode_id_to_mode is done using the
temporary macro K210_PC_DEFAULT. When this macro is not needed anymore and its
definition removed, make sure to use its name in the #undef statement instead of
the incorrect "DEFAULT" name.

> 
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>

This needs a Fixes tag as well.

> ---
>  drivers/pinctrl/pinctrl-k210.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
> index caf20215aaba..eddb01796a83 100644
> --- a/drivers/pinctrl/pinctrl-k210.c
> +++ b/drivers/pinctrl/pinctrl-k210.c
> @@ -181,7 +181,7 @@ static const u32 k210_pinconf_mode_id_to_mode[] = {
>  	[K210_PC_DEFAULT_INT13] = K210_PC_MODE_IN | K210_PC_PU,
>  };
>  
> -#undef DEFAULT
> +#undef K210_PC_DEFAULT
>  
>  /*
>   * Pin functions configuration information.


-- 
Damien Le Moal
Western Digital Research