* [PATCH] pinctrl: k210: Modify the wrong "#undef"
@ 2024-11-13 1:20 zhangjiao2
2024-11-13 4:41 ` Damien Le Moal
2024-12-11 22:32 ` patchwork-bot+linux-riscv
0 siblings, 2 replies; 4+ messages in thread
From: zhangjiao2 @ 2024-11-13 1:20 UTC (permalink / raw)
To: dlemoal; +Cc: linus.walleij, linux-riscv, linux-gpio, linux-kernel, zhang jiao
From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
Here shuld be undef "K210_PC_DEFAULT", not "DEFAULT".
Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
---
drivers/pinctrl/pinctrl-k210.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
index caf20215aaba..eddb01796a83 100644
--- a/drivers/pinctrl/pinctrl-k210.c
+++ b/drivers/pinctrl/pinctrl-k210.c
@@ -181,7 +181,7 @@ static const u32 k210_pinconf_mode_id_to_mode[] = {
[K210_PC_DEFAULT_INT13] = K210_PC_MODE_IN | K210_PC_PU,
};
-#undef DEFAULT
+#undef K210_PC_DEFAULT
/*
* Pin functions configuration information.
--
2.33.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: k210: Modify the wrong "#undef"
2024-11-13 1:20 [PATCH] pinctrl: k210: Modify the wrong "#undef" zhangjiao2
@ 2024-11-13 4:41 ` Damien Le Moal
2024-12-11 22:32 ` patchwork-bot+linux-riscv
1 sibling, 0 replies; 4+ messages in thread
From: Damien Le Moal @ 2024-11-13 4:41 UTC (permalink / raw)
To: zhangjiao2; +Cc: linus.walleij, linux-riscv, linux-gpio, linux-kernel
On 11/13/24 10:20, zhangjiao2 wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> Here shuld be undef "K210_PC_DEFAULT", not "DEFAULT".
Here ? Please be specific.
Also:
s/shuld/must
So something like:
The definition of the array k210_pinconf_mode_id_to_mode is done using the
temporary macro K210_PC_DEFAULT. When this macro is not needed anymore and its
definition removed, make sure to use its name in the #undef statement instead of
the incorrect "DEFAULT" name.
>
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
This needs a Fixes tag as well.
> ---
> drivers/pinctrl/pinctrl-k210.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-k210.c b/drivers/pinctrl/pinctrl-k210.c
> index caf20215aaba..eddb01796a83 100644
> --- a/drivers/pinctrl/pinctrl-k210.c
> +++ b/drivers/pinctrl/pinctrl-k210.c
> @@ -181,7 +181,7 @@ static const u32 k210_pinconf_mode_id_to_mode[] = {
> [K210_PC_DEFAULT_INT13] = K210_PC_MODE_IN | K210_PC_PU,
> };
>
> -#undef DEFAULT
> +#undef K210_PC_DEFAULT
>
> /*
> * Pin functions configuration information.
--
Damien Le Moal
Western Digital Research
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pinctrl: k210: Modify the wrong "#undef"
2024-11-13 1:20 [PATCH] pinctrl: k210: Modify the wrong "#undef" zhangjiao2
2024-11-13 4:41 ` Damien Le Moal
@ 2024-12-11 22:32 ` patchwork-bot+linux-riscv
2024-12-20 12:36 ` Linus Walleij
1 sibling, 1 reply; 4+ messages in thread
From: patchwork-bot+linux-riscv @ 2024-12-11 22:32 UTC (permalink / raw)
To: zhangjiao2; +Cc: linux-riscv, dlemoal, linus.walleij, linux-gpio, linux-kernel
Hello:
This patch was applied to riscv/linux.git (fixes)
by Linus Walleij <linus.walleij@linaro.org>:
On Wed, 13 Nov 2024 09:20:29 +0800 you wrote:
> From: zhang jiao <zhangjiao2@cmss.chinamobile.com>
>
> Here shuld be undef "K210_PC_DEFAULT", not "DEFAULT".
>
> Signed-off-by: zhang jiao <zhangjiao2@cmss.chinamobile.com>
> ---
> drivers/pinctrl/pinctrl-k210.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Here is the summary with links:
- pinctrl: k210: Modify the wrong "#undef"
https://git.kernel.org/riscv/c/7e86490c5dee
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-12-20 12:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-13 1:20 [PATCH] pinctrl: k210: Modify the wrong "#undef" zhangjiao2
2024-11-13 4:41 ` Damien Le Moal
2024-12-11 22:32 ` patchwork-bot+linux-riscv
2024-12-20 12:36 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox